[issue27472] add the 'unix_shell' attribute to test.support

[Xavier de Gaye]

Changes by Xavier de Gaye :


--
resolution:  -> fixed
stage: commit review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27472] add the 'unix_shell' attribute to test.support

[Roundup Robot]

Roundup Robot added the comment:

New changeset 15835311b5e6 by Xavier de Gaye in branch 'default':
Issue #27472: Add test.support.unix_shell as the path to the default shell.
https://hg.python.org/cpython/rev/15835311b5e6

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27472] add the 'unix_shell' attribute to test.support

[Xavier de Gaye]

Changes by Xavier de Gaye :


--
nosy: +haypo
stage: patch review -> commit review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27472] add the 'unix_shell' attribute to test.support

[Xavier de Gaye]

Xavier de Gaye added the comment:

The attached patch ignores the following test modules listed in msg266084:

Lib/distutils/tests/test_build_scripts.py|68 col 31| ("#!/bin/sh\n"
Lib/distutils/tests/test_install_scripts.py|57 col 38| write_script("shell.sh", 
("#!/bin/sh\n"
reason:
The scripts are not meant to be run.

Lib/test/test__osx_support.py|46 col 24| f.write("#!/bin/sh\n/bin/echo OK\n")
Lib/test/test__osx_support.py|58 col 24| f.write("#!/bin/sh\n/bin/echo 
ExpectedOutput\n")
Lib/test/test__osx_support.py|149 col 28| f.write("#!/bin/sh\n/bin/echo " + 
c_output)
Lib/test/test__osx_support.py|205 col 24| f.write("#!/bin/sh\nexit 255")
reason:
These tests run only on the darwin platform.

Lib/test/test_subprocess.py|1645 col 15| sh = '/bin/sh'
Lib/test/test_subprocess.py|1647 col 33| # Test will fail if /bin/sh is a 
symlink to csh.
reason:
This test is specific to bash or ksh.

--
keywords: +patch
stage: needs patch -> patch review
Added file: http://bugs.python.org/file43687/unix_shell_27472.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27472] add the 'unix_shell' attribute to test.support

[Xavier de Gaye]

Xavier de Gaye added the comment:

Yes, issue 27027 adds test.support.is_android and there is no need now to wait 
for issue 16353. Thanks David for reminding me, I have just added a 
cross-reference to issue 16353.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27472] add the 'unix_shell' attribute to test.support

[R. David Murray]

R. David Murray added the comment:

I think a cross reference to issue 16353 is worth making here :)  I presume 
your intent with this issue is to avoid having to wait for that issue to get 
resolved.

--
nosy: +r.david.murray

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27472] add the 'unix_shell' attribute to test.support

[Xavier de Gaye]

Changes by Xavier de Gaye :


--
dependencies: +add the 'is_android' attribute to test.support

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27472] add the 'unix_shell' attribute to test.support

[Xavier de Gaye]

New submission from Xavier de Gaye:

'/bin/sh' is hard-coded in few places in the test suite, but the Android shell 
is at '/system/bin/sh', see msg266084.

--
assignee: xdegaye
components: Tests
messages: 270044
nosy: xdegaye
priority: normal
severity: normal
stage: needs patch
status: open
title: add the 'unix_shell' attribute to test.support
type: behavior
versions: Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com