[issue32682] test_zlib improve version parsing

[pmp-p]

Change by pmp-p :


--
status: closed -> pending

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32682] test_zlib improve version parsing

[pmp-p]

Change by pmp-p :


--
pull_requests: +21399
pull_request: https://github.com/python/cpython/pull/22361

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32682] test_zlib improve version parsing

[miss-islington]

miss-islington  added the comment:


New changeset b0fd935360e81b6bb4733deed69f51516c771f7a by Miss Islington (bot) 
in branch '3.6':
bpo-32682: Improve libz version parsing in test_zilb (GH-5347)
https://github.com/python/cpython/commit/b0fd935360e81b6bb4733deed69f51516c771f7a


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32682] test_zlib improve version parsing

[pmpp]

Change by pmpp :


--
resolution:  -> fixed
stage: commit review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32682] test_zlib improve version parsing

[miss-islington]

miss-islington  added the comment:


New changeset 0cd35817e8278588f04dc574f6eca53273799f25 by Miss Islington (bot) 
in branch '3.7':
bpo-32682: Improve libz version parsing in test_zilb (GH-5347)
https://github.com/python/cpython/commit/0cd35817e8278588f04dc574f6eca53273799f25


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32682] test_zlib improve version parsing

[Zachary Ware]

Change by Zachary Ware :


--
stage: patch review -> commit review
versions: +Python 3.6, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32682] test_zlib improve version parsing

[miss-islington]

Change by miss-islington :


--
pull_requests: +5528

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32682] test_zlib improve version parsing

[miss-islington]

Change by miss-islington :


--
pull_requests: +5527

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32682] test_zlib improve version parsing

[Zachary Ware]

Zachary Ware  added the comment:


New changeset 4c7108a77144493d0aa6fc0105b67d3797e143f5 by Zachary Ware (pmp-p) 
in branch 'master':
bpo-32682: Improve libz version parsing in test_zilb (GH-5347)
https://github.com/python/cpython/commit/4c7108a77144493d0aa6fc0105b67d3797e143f5


--
nosy: +zach.ware

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32682] test_zlib improve version parsing

[pmpp]

Change by pmpp :


--
keywords: +patch
pull_requests: +5195
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32682] test_zlib improve version parsing

[pmpp]

New submission from pmpp :

On some OS like android 4.0+, system libz.so gives funny versions number that 
prevent test_zlib from correctly parse it from zlib.ZLIB_RUNTIME_VERSION

https://patch-diff.githubusercontent.com/raw/vstinner/cpython/pull/1.patch

seems to fix "1.2.8-linuxfoundation-mods-v1" and 
"1.2.8.f-linuxfoundation-mods-v1" cases as already encountered on an popular 
operating system and maybe others yet unknown.

--
components: Tests
messages: 310773
nosy: pmpp
priority: normal
severity: normal
status: open
title: test_zlib improve version parsing
versions: Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com