[issue40291] socket library support for CAN_J1939

[miss-islington]

miss-islington  added the comment:


New changeset 12fa658d0565c6c53d25f464f29ef596a0df5e2a by Miss Islington (bot) 
in branch '3.9':
bpo-40291: Mention socket.CAN_J1939 in What's New (GH-20248)
https://github.com/python/cpython/commit/12fa658d0565c6c53d25f464f29ef596a0df5e2a


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40291] socket library support for CAN_J1939

[miss-islington]

miss-islington  added the comment:


New changeset 550f30c8f33a2ba844db2ce3da8a897b3e882c9a by karl ding in branch 
'master':
bpo-40291: Mention socket.CAN_J1939 in What's New (GH-20248)
https://github.com/python/cpython/commit/550f30c8f33a2ba844db2ce3da8a897b3e882c9a


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40291] socket library support for CAN_J1939

[miss-islington]

Change by miss-islington :


--
pull_requests: +19537
pull_request: https://github.com/python/cpython/pull/20249

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40291] socket library support for CAN_J1939

[Karl Ding]

Karl Ding  added the comment:

Should this be added to the What's New for 3.9? I see a smaller change that 
exposes the CAN_RAW_JOIN_FILTERS constant mentioned.

I've created https://github.com/python/cpython/pull/20248 if this is needed.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40291] socket library support for CAN_J1939

[Karl Ding]

Change by Karl Ding :


--
pull_requests: +19536
pull_request: https://github.com/python/cpython/pull/20248

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40291] socket library support for CAN_J1939

[Guido van Rossum]

Guido van Rossum  added the comment:

Thanks, good luck using this!

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40291] socket library support for CAN_J1939

[miss-islington]

miss-islington  added the comment:


New changeset 360371f79c48f15bbcee7aeecacf97a899913b25 by karl ding in branch 
'master':
bpo-40291: Add support for CAN_J1939 sockets (GH-19538)
https://github.com/python/cpython/commit/360371f79c48f15bbcee7aeecacf97a899913b25


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40291] socket library support for CAN_J1939

[Senthil Kumaran]

Change by Senthil Kumaran :


--
nosy: +orsenthil

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40291] socket library support for CAN_J1939

[Guido van Rossum]

Guido van Rossum  added the comment:

Looks reasonable.

--
nosy: +gvanrossum

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40291] socket library support for CAN_J1939

[Karl Ding]

Change by Karl Ding :


--
keywords: +patch
pull_requests: +18886
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/19538

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40291] socket library support for CAN_J1939

[Karl Ding]

New submission from Karl Ding :

It would be nice to have support J1939 sockets.

Support for J1939 landed as part of the SAE J1939 SocketCAN patches, which are 
available after the Linux 5.4rc1 kernel. This is another protocol family for 
SocketCAN, much like the existing support for ISOTP and BCM.

Effectively, supporting this would hand off as much to the kernel as possible, 
which gives Python programs the ability deal with J1939 without having to 
implement the logic existing in the kernel in userspace.

This is provided to userspace [0] via the  header.

I'd be happy to work on this and provide a PR.

[0] https://www.kernel.org/doc/html/latest/networking/j1939.html

--
components: Library (Lib)
messages: 366487
nosy: karlding
priority: normal
severity: normal
status: open
title: socket library support for CAN_J1939
type: enhancement
versions: Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com