Re: [Qemu-block] [PATCH v3] iotests: Fix CID for VMDK afl image
On Wed, 02/28 18:50, Max Reitz wrote: > On 2018-02-02 06:23, Fam Zheng wrote: > > This reverts commit 76bf133c4 which updated the reference output, and > > fixed the reference image, because the code path we want to exercise is > > actually the invalid image size. > > > > The descriptor block in the image, which includes the CID to verify, has > > been > > invalid since the reference image was added. Since commit 9877860e7bd we > > report > > this error earlier than the "file too large", so 059.out mismatches. > > > > The binary change is generated along the operations of: > > > > $ bunzip2 afl9.vmdk.bz2 > > $ qemu-img create -f vmdk fix.vmdk 1G > > $ dd if=afl9.vmdk of=fix.vmdk bs=512 count=1 conv=notrunc > > $ mv fix.vmdk afl9.vmdk > > $ bzip2 afl9.vmdk > > > > Signed-off-by: Fam Zheng > > > > --- > > Could you rebase this on master (so only the _notrun portion remains)? > It appears that v2 has hit master already... OK, will do! Fam
Re: [Qemu-block] [PATCH v3] iotests: Fix CID for VMDK afl image
On 2018-02-02 06:23, Fam Zheng wrote: > This reverts commit 76bf133c4 which updated the reference output, and > fixed the reference image, because the code path we want to exercise is > actually the invalid image size. > > The descriptor block in the image, which includes the CID to verify, has been > invalid since the reference image was added. Since commit 9877860e7bd we > report > this error earlier than the "file too large", so 059.out mismatches. > > The binary change is generated along the operations of: > > $ bunzip2 afl9.vmdk.bz2 > $ qemu-img create -f vmdk fix.vmdk 1G > $ dd if=afl9.vmdk of=fix.vmdk bs=512 count=1 conv=notrunc > $ mv fix.vmdk afl9.vmdk > $ bzip2 afl9.vmdk > > Signed-off-by: Fam Zheng > > --- Could you rebase this on master (so only the _notrun portion remains)? It appears that v2 has hit master already... Max signature.asc Description: OpenPGP digital signature
Re: [Qemu-block] [PATCH v3] iotests: Fix CID for VMDK afl image
On 2018-02-02 06:23, Fam Zheng wrote: > This reverts commit 76bf133c4 which updated the reference output, and > fixed the reference image, because the code path we want to exercise is > actually the invalid image size. > > The descriptor block in the image, which includes the CID to verify, has been > invalid since the reference image was added. Since commit 9877860e7bd we > report > this error earlier than the "file too large", so 059.out mismatches. > > The binary change is generated along the operations of: > > $ bunzip2 afl9.vmdk.bz2 > $ qemu-img create -f vmdk fix.vmdk 1G > $ dd if=afl9.vmdk of=fix.vmdk bs=512 count=1 conv=notrunc > $ mv fix.vmdk afl9.vmdk > $ bzip2 afl9.vmdk > > Signed-off-by: Fam Zheng > > --- > > v3: Skip test when ENOMEM. [Max, Eric] > > v2: Fix commit message "qcow2 -> vmdk". [Kevin] > Revert 76bf133c4. > --- > tests/qemu-iotests/059 | 5 ++--- > tests/qemu-iotests/059.out | 2 +- > tests/qemu-iotests/sample_images/afl9.vmdk.bz2 | Bin 178 -> 618 bytes > 3 files changed, 3 insertions(+), 4 deletions(-) Nice, thanks. Reviewed-by: Max Reitz signature.asc Description: OpenPGP digital signature