Re: [Qemu-devel] [PATCH] Target-arm: Add the Cortex-M4 CPU
El 10/6/2015 7:45, "Peter Maydell" escribió: > > On 10 June 2015 at 10:58, Liviu Ionescu wrote: > > > >> On 29 May 2015, at 22:16, Martin Galvan < martin.gal...@tallertechnologies.com> wrote: > >> > >> > >> ... I think Peter M is the maintainer for Target-ARM. > >> > >> Peter, is this OK to commit? > > > > was this patch accepted? > > No; as Peter C suggested, Martin split it into two patches. > Those patches then got code review, but I don't think Martin > has sent out a revised series yet. Aurelio is the primary author of the patch. He's busy these days but he will commit the new version soon, hopefully during the weekend. > > -- PMM
[Qemu-devel] Re: Re: [PATCH] Fix to 'gdb detach' stub
Hello Kevin, please let me know if this works. If so, please remember that I'd need somebody to commit this for me, since I don't have write-access. Undoing line wrap and tabs. Thanks! Daniel. [old same text.] With this patch, 'gdb detach' correctly resumes the inferior execution after detaching the debugger. The bug was caused by qemu asking gdb to execute a syscall (isatty) after the detach, and then waiting (forever) for the reply. I fixed this by properly setting gdb_syscall_mode appropriately in the 'detach' packet handling, so subsequent syscalls are solved by qemu rather than gdb. Signed-off-by: Daniel Gutson --- gdbstub.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 91c5f68..92bb36d 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1848,6 +1848,7 @@ static int gdb_handle_packet(GDBState *s, const char *line_buf) case 'D': /* Detach packet */ gdb_breakpoint_remove_all(); +gdb_syscall_mode = GDB_SYS_DISABLED; gdb_continue(s); put_packet(s, "OK"); break; -- 1.6.2.4
[Qemu-devel] Re: [PATCH] Fix to 'gdb detach' stub
[Re-done with git.] With this patch, 'gdb detach' correctly resumes the inferior execution after detaching the debugger. The bug was caused by qemu asking gdb to execute a syscall (isatty) after the detach, and then waiting (forever) for the reply. I fixed this by properly setting gdb_syscall_mode appropriately in the 'detach' packet handling, so subsequent syscalls are solved by qemu rather than gdb. Signed-off-by: Daniel Gutson --- gdbstub.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 91c5f68..92bb36d 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1848,6 +1848,7 @@ static int gdb_handle_packet(GDBState *s, const char *line_buf) case 'D': /* Detach packet */ gdb_breakpoint_remove_all(); + gdb_syscall_mode = GDB_SYS_DISABLED; gdb_continue(s); put_packet(s, "OK"); break; -- 1.6.2.4
[Qemu-devel] [PATCH] Fix to 'gdb detach' stub
With this patch, 'gdb detach' correctly resumes the inferior execution after detaching the debugger. The bug was caused by qemu asking gdb to execute a syscall (isatty) after the detach, and then waiting (forever) for the reply. I fixed this by properly setting gdb_syscall_mode appropriately in the 'detach' packet handling, so subsequent syscalls are solved by qemu rather than gdb. I tested this manually. Please commit it for me if accepted, since I don't have write privileges. Thanks! Daniel. 2010-02-22 Daniel Gutson * gdbstub.c (gdb_handle_packet): set gdb_syscall_mode properly. -- Daniel Gutson CodeSourcery www.codesourcery.com diff --git a/gdbstub.c b/gdbstub.c index 91c5f68..92bb36d 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1848,6 +1848,7 @@ static int gdb_handle_packet(GDBState *s, const char *line_buf) case 'D': /* Detach packet */ gdb_breakpoint_remove_all(); + gdb_syscall_mode = GDB_SYS_DISABLED; gdb_continue(s); put_packet(s, "OK"); break;
[Qemu-devel] Re: [PATCH] ARM NEON shift emulation fix
Hi, friendly reminder about this patch. Thanks, Daniel. Daniel Gutson wrote: Any update on this? Thanks, Daniel. Daniel Gutson wrote: Hi, the attached patch fixes a bug that caused some NEON shift operations to shift a wrong amount of bytes. The problem was that a variable holding an immediate value representing the amount of bits to shift was later overwritten with another value (used for something different) within a loop. Please commit this for me if approved, since I don't have write access. Thanks! Daniel. --- 2009-08-21 Daniel Gutson * target-arm/translate.c (disas_neon_data_insn): Fixed shift operand. -- Daniel Gutson CodeSourcery www.codesourcery.com
