Re: [PATCH 0/7] Remove some unused structures
07.06.2024 17:04, Dr. David Alan Gilbert пишет: * Dr. David Alan Gilbert (d...@treblig.org) wrote: A bunch of structs that are currently unused, found with a simple script and a bit of eyeballing. The only one I'm that suspicious of is the SPARC one, where the patch which removed the use is a bit confusing to me. Copying in Trivial; I think there are 4 of these that are still outstanding: [PATCH 1/7] linux-user: cris: Remove unused struct 'rt_signal_frame' (Although cris is going) [PATCH 3/7] linux-user: sparc: Remove unused struct 'target_mc_fq' [PATCH 5/7] hw/arm/bcm2836: Remove unusued struct 'BCM283XClass' [PATCH 7/7] net/can: Remove unused struct 'CanBusState' Can Trivial pick these up please? Applied to qemu-trivial, thanks! /mjt -- GPG Key transition (from rsa2048 to rsa4096) since 2024-04-24. New key: rsa4096/61AD3D98ECDF2C8E 9D8B E14E 3F2A 9DD7 9199 28F1 61AD 3D98 ECDF 2C8E Old key: rsa2048/457CE0A0804465C5 6EE1 95D1 886E 8FFB 810D 4324 457C E0A0 8044 65C5 Transition statement: http://www.corpit.ru/mjt/gpg-transition-2024.txt
Re: [PATCH 0/7] Remove some unused structures
* Dr. David Alan Gilbert (d...@treblig.org) wrote: > A bunch of structs that are currently unused, > found with a simple script and a bit of eyeballing. > > The only one I'm that suspicious of is the SPARC > one, where the patch which removed the use is a bit > confusing to me. Copying in Trivial; I think there are 4 of these that are still outstanding: [PATCH 1/7] linux-user: cris: Remove unused struct 'rt_signal_frame' (Although cris is going) [PATCH 3/7] linux-user: sparc: Remove unused struct 'target_mc_fq' [PATCH 5/7] hw/arm/bcm2836: Remove unusued struct 'BCM283XClass' [PATCH 7/7] net/can: Remove unused struct 'CanBusState' Can Trivial pick these up please? Dave > Tested with a > > --target-list=ppc-softmmu,m68k-softmmu,x86_64-softmmu,arm-softmmu,aarch64-softmmu,cris-linux-user,i386-linux-user,sparc-linux-user > and 'make check' on x86 linux. > > Dave > > Dr. David Alan Gilbert (7): > linux-user: cris: Remove unused struct 'rt_signal_frame' > linux-user: i386/signal: Remove unused fp structs > linux-user: sparc: Remove unused struct 'target_mc_fq' > hw/usb/dev-network: Remove unused struct 'rndis_config_parameter' > hw/arm/bcm2836: Remove unusued struct 'BCM283XClass' > target/ppc: Remove unused struct 'mmu_ctx_hash32' > net/can: Remove unused struct 'CanBusState' > > hw/arm/bcm2836.c | 12 > hw/usb/dev-network.c | 8 > linux-user/cris/signal.c | 8 > linux-user/i386/signal.c | 10 -- > linux-user/sparc/signal.c | 5 - > net/can/can_host.c| 6 -- > target/ppc/mmu-hash32.c | 6 -- > 7 files changed, 55 deletions(-) > > -- > 2.45.0 > > -- -Open up your eyes, open up your mind, open up your code --- / Dr. David Alan Gilbert| Running GNU/Linux | Happy \ \dave @ treblig.org | | In Hex / \ _|_ http://www.treblig.org |___/
[PATCH 0/7] Remove some unused structures
A bunch of structs that are currently unused, found with a simple script and a bit of eyeballing. The only one I'm that suspicious of is the SPARC one, where the patch which removed the use is a bit confusing to me. Tested with a --target-list=ppc-softmmu,m68k-softmmu,x86_64-softmmu,arm-softmmu,aarch64-softmmu,cris-linux-user,i386-linux-user,sparc-linux-user and 'make check' on x86 linux. Dave Dr. David Alan Gilbert (7): linux-user: cris: Remove unused struct 'rt_signal_frame' linux-user: i386/signal: Remove unused fp structs linux-user: sparc: Remove unused struct 'target_mc_fq' hw/usb/dev-network: Remove unused struct 'rndis_config_parameter' hw/arm/bcm2836: Remove unusued struct 'BCM283XClass' target/ppc: Remove unused struct 'mmu_ctx_hash32' net/can: Remove unused struct 'CanBusState' hw/arm/bcm2836.c | 12 hw/usb/dev-network.c | 8 linux-user/cris/signal.c | 8 linux-user/i386/signal.c | 10 -- linux-user/sparc/signal.c | 5 - net/can/can_host.c| 6 -- target/ppc/mmu-hash32.c | 6 -- 7 files changed, 55 deletions(-) -- 2.45.0
