Re: [PATCH 00/26] Various qom & qdev enhancements
On 10/01/20 16:38, Marc-André Lureau wrote: > Hi > > > Something went wrong with git-publish & "git branch > --edit-description" interaction (which I started to play with - I > think git-publish should make use of it). It seems it got the mail > summary from git-publish and content from git description, fun :) > > On Fri, Jan 10, 2020 at 7:31 PM Marc-André Lureau > wrote: >> aa bpkwef > That should read instead: > > The following series has some qom/qdev cleanups, moves qdev instance > properties to class properites, and return the default values in help > and QMP commands. Queued, thanks. Paolo
Re: [PATCH 00/26] Various qom & qdev enhancements
On Fri, Jan 10, 2020 at 07:38:02PM +0400, Marc-André Lureau wrote: > Something went wrong with git-publish & "git branch > --edit-description" interaction (which I started to play with - I > think git-publish should make use of it). It seems it got the mail > summary from git-publish and content from git description, fun :) Yes, the branch description might be a good place to stash the cover letter or at least part of it. Stefan signature.asc Description: PGP signature
Re: [PATCH 00/26] Various qom & qdev enhancements
Hi Something went wrong with git-publish & "git branch --edit-description" interaction (which I started to play with - I think git-publish should make use of it). It seems it got the mail summary from git-publish and content from git description, fun :) On Fri, Jan 10, 2020 at 7:31 PM Marc-André Lureau wrote: > > aa bpkwef That should read instead: The following series has some qom/qdev cleanups, moves qdev instance properties to class properites, and return the default values in help and QMP commands. Thanks > Marc-André Lureau (26): > object: add extra sanity checks > qdev: remove duplicated qdev_property_add_static() doc > qdev: remove extraneous error > qdev: move helper function to monitor/misc > object: avoid extra class property key duplication > object: add class property initializer > object: add object_property_get_defaut() > object: make object_class_property_add* return property > qstring: add qstring_free() > object: add object_property_set_defaut_{bool,str,int,uint}() > object: do not free class properties > object: check strong flag with & > object: rename link "child" to "target" > object: add direct link flag > object: express const link with link property > object: add object_class_property_add_link() > object: release all props > object: return self in object_ref() > qdev: set properties with device_class_set_props() > qdev: move instance properties to class properties > qdev: register properties as class properties > vl: print default value in object help > qom: simplify qmp_device_list_properties() > qom: introduce object_property_help() > qapi/qmp: add ObjectPropertyInfo.default-value > qdev: use object_property_help() > > qapi/qom.json | 7 +- > include/hw/qdev-core.h | 8 +- > include/hw/qdev-properties.h| 3 +- > include/qapi/qmp/qstring.h | 1 + > include/qom/object.h| 126 ++-- > hw/9pfs/virtio-9p-device.c | 2 +- > hw/acpi/generic_event_device.c | 2 +- > hw/acpi/piix4.c | 2 +- > hw/acpi/vmgenid.c | 2 +- > hw/arm/armsse.c | 2 +- > hw/arm/armv7m.c | 4 +- > hw/arm/aspeed_soc.c | 2 +- > hw/arm/bcm2836.c| 2 +- > hw/arm/integratorcp.c | 2 +- > hw/arm/msf2-soc.c | 2 +- > hw/arm/musicpal.c | 2 +- > hw/arm/nrf51_soc.c | 2 +- > hw/arm/pxa2xx.c | 4 +- > hw/arm/pxa2xx_gpio.c| 2 +- > hw/arm/smmu-common.c| 2 +- > hw/arm/spitz.c | 2 +- > hw/arm/stm32f205_soc.c | 2 +- > hw/arm/strongarm.c | 2 +- > hw/arm/xlnx-versal.c| 2 +- > hw/arm/xlnx-zynqmp.c| 2 +- > hw/audio/ac97.c | 2 +- > hw/audio/adlib.c| 2 +- > hw/audio/cs4231.c | 2 +- > hw/audio/cs4231a.c | 2 +- > hw/audio/es1370.c | 2 +- > hw/audio/gus.c | 2 +- > hw/audio/hda-codec.c| 2 +- > hw/audio/intel-hda.c| 4 +- > hw/audio/milkymist-ac97.c | 2 +- > hw/audio/pcspk.c| 2 +- > hw/audio/pl041.c| 2 +- > hw/audio/sb16.c | 2 +- > hw/audio/wm8750.c | 2 +- > hw/block/fdc.c | 8 +- > hw/block/m25p80.c | 2 +- > hw/block/nand.c | 2 +- > hw/block/nvme.c | 2 +- > hw/block/onenand.c | 2 +- > hw/block/pflash_cfi01.c | 2 +- > hw/block/pflash_cfi02.c | 2 +- > hw/block/swim.c | 2 +- > hw/block/vhost-user-blk.c | 2 +- > hw/block/virtio-blk.c | 2 +- > hw/block/xen-block.c| 2 +- > hw/char/bcm2835_aux.c | 2 +- > hw/char/cadence_uart.c | 2 +- > hw/char/cmsdk-apb-uart.c| 2 +- > hw/char/debugcon.c | 2 +- > hw/char/digic-uart.c| 2 +- > hw/char/escc.c | 2 +- > hw/char/etraxfs_ser.c | 2 +- > hw/char/exynos4210_uart.c | 2 +- > hw/char/grlib_apbuart.c | 2 +- > hw/char/imx_serial.c| 2 +- > hw/char/ipoctal232.c| 2 +- > hw/char/lm32_juart.c| 2 +- > hw/char/lm32_uart.c | 2 +- > hw/char/mcf_uart.c | 2 +- > hw/char/milkymist-uart.c| 2 +- > hw/char/nrf51_uart.c| 2 +- > hw/char/parallel.c | 2 +- > hw/char/pl011.c | 2 +- > hw/char/sclpconsole-lm.c|
[PATCH 00/26] Various qom & qdev enhancements
aa bpkwef Marc-André Lureau (26): object: add extra sanity checks qdev: remove duplicated qdev_property_add_static() doc qdev: remove extraneous error qdev: move helper function to monitor/misc object: avoid extra class property key duplication object: add class property initializer object: add object_property_get_defaut() object: make object_class_property_add* return property qstring: add qstring_free() object: add object_property_set_defaut_{bool,str,int,uint}() object: do not free class properties object: check strong flag with & object: rename link "child" to "target" object: add direct link flag object: express const link with link property object: add object_class_property_add_link() object: release all props object: return self in object_ref() qdev: set properties with device_class_set_props() qdev: move instance properties to class properties qdev: register properties as class properties vl: print default value in object help qom: simplify qmp_device_list_properties() qom: introduce object_property_help() qapi/qmp: add ObjectPropertyInfo.default-value qdev: use object_property_help() qapi/qom.json | 7 +- include/hw/qdev-core.h | 8 +- include/hw/qdev-properties.h| 3 +- include/qapi/qmp/qstring.h | 1 + include/qom/object.h| 126 ++-- hw/9pfs/virtio-9p-device.c | 2 +- hw/acpi/generic_event_device.c | 2 +- hw/acpi/piix4.c | 2 +- hw/acpi/vmgenid.c | 2 +- hw/arm/armsse.c | 2 +- hw/arm/armv7m.c | 4 +- hw/arm/aspeed_soc.c | 2 +- hw/arm/bcm2836.c| 2 +- hw/arm/integratorcp.c | 2 +- hw/arm/msf2-soc.c | 2 +- hw/arm/musicpal.c | 2 +- hw/arm/nrf51_soc.c | 2 +- hw/arm/pxa2xx.c | 4 +- hw/arm/pxa2xx_gpio.c| 2 +- hw/arm/smmu-common.c| 2 +- hw/arm/spitz.c | 2 +- hw/arm/stm32f205_soc.c | 2 +- hw/arm/strongarm.c | 2 +- hw/arm/xlnx-versal.c| 2 +- hw/arm/xlnx-zynqmp.c| 2 +- hw/audio/ac97.c | 2 +- hw/audio/adlib.c| 2 +- hw/audio/cs4231.c | 2 +- hw/audio/cs4231a.c | 2 +- hw/audio/es1370.c | 2 +- hw/audio/gus.c | 2 +- hw/audio/hda-codec.c| 2 +- hw/audio/intel-hda.c| 4 +- hw/audio/milkymist-ac97.c | 2 +- hw/audio/pcspk.c| 2 +- hw/audio/pl041.c| 2 +- hw/audio/sb16.c | 2 +- hw/audio/wm8750.c | 2 +- hw/block/fdc.c | 8 +- hw/block/m25p80.c | 2 +- hw/block/nand.c | 2 +- hw/block/nvme.c | 2 +- hw/block/onenand.c | 2 +- hw/block/pflash_cfi01.c | 2 +- hw/block/pflash_cfi02.c | 2 +- hw/block/swim.c | 2 +- hw/block/vhost-user-blk.c | 2 +- hw/block/virtio-blk.c | 2 +- hw/block/xen-block.c| 2 +- hw/char/bcm2835_aux.c | 2 +- hw/char/cadence_uart.c | 2 +- hw/char/cmsdk-apb-uart.c| 2 +- hw/char/debugcon.c | 2 +- hw/char/digic-uart.c| 2 +- hw/char/escc.c | 2 +- hw/char/etraxfs_ser.c | 2 +- hw/char/exynos4210_uart.c | 2 +- hw/char/grlib_apbuart.c | 2 +- hw/char/imx_serial.c| 2 +- hw/char/ipoctal232.c| 2 +- hw/char/lm32_juart.c| 2 +- hw/char/lm32_uart.c | 2 +- hw/char/mcf_uart.c | 2 +- hw/char/milkymist-uart.c| 2 +- hw/char/nrf51_uart.c| 2 +- hw/char/parallel.c | 2 +- hw/char/pl011.c | 2 +- hw/char/sclpconsole-lm.c| 2 +- hw/char/sclpconsole.c | 2 +- hw/char/serial-isa.c| 2 +- hw/char/serial-pci-multi.c | 4 +- hw/char/serial-pci.c| 2 +- hw/char/serial.c| 4 +- hw/char/spapr_vty.c | 2 +- hw/char/stm32f2xx_usart.c | 2 +- hw/char/terminal3270.c | 2 +- hw/char/virtio-console.c| 2 +- hw/char/virtio-serial-bus.c | 4 +- hw/char/xilinx_uartlite.c | 2 +- hw/core/cpu.c | 2 +- hw/core/generic-loader.c| 2 +- hw/core/or-irq.c| 2 +- hw/core/platform-bus.c | 2 +-