Re: [PATCH v6 01/11] gdbstub: Clean up process_string_cmd

[Philippe Mathieu-Daudé]

On 28/6/24 07:08, Gustavo Romero wrote:

Change 'process_string_cmd' to return true on success and false on
failure, instead of 0 and -1.

Signed-off-by: Gustavo Romero 
Reviewed-by: Alex Bennée 
Reviewed-by: Richard Henderson 
---
  gdbstub/gdbstub.c | 40 
  1 file changed, 20 insertions(+), 20 deletions(-)


Reviewed-by: Philippe Mathieu-Daudé 

[PATCH v6 01/11] gdbstub: Clean up process_string_cmd

[Gustavo Romero]

Change 'process_string_cmd' to return true on success and false on
failure, instead of 0 and -1.

Signed-off-by: Gustavo Romero 
Reviewed-by: Alex Bennée 
Reviewed-by: Richard Henderson 
---
 gdbstub/gdbstub.c | 40 
 1 file changed, 20 insertions(+), 20 deletions(-)

diff --git a/gdbstub/gdbstub.c b/gdbstub/gdbstub.c
index b3574997ea..37314b92e5 100644
--- a/gdbstub/gdbstub.c
+++ b/gdbstub/gdbstub.c
@@ -962,14 +962,14 @@ static inline int startswith(const char *string, const 
char *pattern)
   return !strncmp(string, pattern, strlen(pattern));
 }
 
-static int process_string_cmd(const char *data,
-  const GdbCmdParseEntry *cmds, int num_cmds)
+static bool process_string_cmd(const char *data,
+   const GdbCmdParseEntry *cmds, int num_cmds)
 {
 int i;
 g_autoptr(GArray) params = g_array_new(false, true, sizeof(GdbCmdVariant));
 
 if (!cmds) {
-return -1;
+return false;
 }
 
 for (i = 0; i < num_cmds; i++) {
@@ -984,16 +984,16 @@ static int process_string_cmd(const char *data,
 if (cmd->schema) {
 if (cmd_parse_params([strlen(cmd->cmd)],
  cmd->schema, params)) {
-return -1;
+return false;
 }
 }
 
 gdbserver_state.allow_stop_reply = cmd->allow_stop_reply;
 cmd->handler(params, NULL);
-return 0;
+return true;
 }
 
-return -1;
+return false;
 }
 
 static void run_cmd_parser(const char *data, const GdbCmdParseEntry *cmd)
@@ -1007,7 +1007,7 @@ static void run_cmd_parser(const char *data, const 
GdbCmdParseEntry *cmd)
 
 /* In case there was an error during the command parsing we must
 * send a NULL packet to indicate the command is not supported */
-if (process_string_cmd(data, cmd, 1)) {
+if (!process_string_cmd(data, cmd, 1)) {
 gdb_put_packet("");
 }
 }
@@ -1523,9 +1523,9 @@ static void handle_v_commands(GArray *params, void 
*user_ctx)
 return;
 }
 
-if (process_string_cmd(get_param(params, 0)->data,
-   gdb_v_commands_table,
-   ARRAY_SIZE(gdb_v_commands_table))) {
+if (!process_string_cmd(get_param(params, 0)->data,
+gdb_v_commands_table,
+ARRAY_SIZE(gdb_v_commands_table))) {
 gdb_put_packet("");
 }
 }
@@ -1889,15 +1889,15 @@ static void handle_gen_query(GArray *params, void 
*user_ctx)
 return;
 }
 
-if (!process_string_cmd(get_param(params, 0)->data,
-gdb_gen_query_set_common_table,
-ARRAY_SIZE(gdb_gen_query_set_common_table))) {
+if (process_string_cmd(get_param(params, 0)->data,
+   gdb_gen_query_set_common_table,
+   ARRAY_SIZE(gdb_gen_query_set_common_table))) {
 return;
 }
 
-if (process_string_cmd(get_param(params, 0)->data,
-   gdb_gen_query_table,
-   ARRAY_SIZE(gdb_gen_query_table))) {
+if (!process_string_cmd(get_param(params, 0)->data,
+gdb_gen_query_table,
+ARRAY_SIZE(gdb_gen_query_table))) {
 gdb_put_packet("");
 }
 }
@@ -1908,13 +1908,13 @@ static void handle_gen_set(GArray *params, void 
*user_ctx)
 return;
 }
 
-if (!process_string_cmd(get_param(params, 0)->data,
-gdb_gen_query_set_common_table,
-ARRAY_SIZE(gdb_gen_query_set_common_table))) {
+if (process_string_cmd(get_param(params, 0)->data,
+   gdb_gen_query_set_common_table,
+   ARRAY_SIZE(gdb_gen_query_set_common_table))) {
 return;
 }
 
-if (process_string_cmd(get_param(params, 0)->data,
+if (!process_string_cmd(get_param(params, 0)->data,
gdb_gen_set_table,
ARRAY_SIZE(gdb_gen_set_table))) {
 gdb_put_packet("");
-- 
2.34.1