[Qemu-devel] [PATCH 2/9] qemu-io: remove unnecessary assignment

2011-09-04 Thread Blue Swirl
Remove an unnecessary assignment, spotted by clang analyzer:
/src/qemu/qemu-io.c:995:9: warning: Value stored to 'offset' is never read
offset += reqs[i].qiov->size;

Signed-off-by: Blue Swirl 
---
 qemu-io.c |1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/qemu-io.c b/qemu-io.c
index 7e40c48..5e46213 100644
--- a/qemu-io.c
+++ b/qemu-io.c
@@ -992,7 +992,6 @@ static int multiwrite_f(int argc, char **argv)

 optind = j + 1;

-offset += reqs[i].qiov->size;
 pattern++;
 }

-- 
1.6.2.4
From f092cf2775a0398a3267100ff0c8cd3caac5d5d6 Mon Sep 17 00:00:00 2001
Message-Id: 
In-Reply-To: <70f99a25b7732d4c9ea54f74c089ccb9bb323ea6.1315150286.git.blauwir...@gmail.com>
References: <70f99a25b7732d4c9ea54f74c089ccb9bb323ea6.1315150286.git.blauwir...@gmail.com>
From: Blue Swirl 
Date: Sun, 4 Sep 2011 10:38:01 +
Subject: [PATCH 2/9] qemu-io: remove unnecessary assignment

Remove an unnecessary assignment, spotted by clang analyzer:
/src/qemu/qemu-io.c:995:9: warning: Value stored to 'offset' is never read
offset += reqs[i].qiov->size;

Signed-off-by: Blue Swirl 
---
 qemu-io.c |1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/qemu-io.c b/qemu-io.c
index 7e40c48..5e46213 100644
--- a/qemu-io.c
+++ b/qemu-io.c
@@ -992,7 +992,6 @@ static int multiwrite_f(int argc, char **argv)
 
 optind = j + 1;
 
-offset += reqs[i].qiov->size;
 pattern++;
 }
 
-- 
1.7.2.5



Re: [Qemu-devel] [PATCH 2/9] qemu-io: remove unnecessary assignment

2011-09-05 Thread Kevin Wolf
Am 04.09.2011 17:47, schrieb Blue Swirl:
> Remove an unnecessary assignment, spotted by clang analyzer:
> /src/qemu/qemu-io.c:995:9: warning: Value stored to 'offset' is never read
> offset += reqs[i].qiov->size;
> 
> Signed-off-by: Blue Swirl 

Acked-by: Kevin Wolf