Re: [Qemu-devel] [PATCH 49/52] target-m68k: cmp manages word and bytes operands

[Richard Henderson]

On 05/04/2016 11:21 AM, Laurent Vivier wrote:

Signed-off-by: Laurent Vivier 
---
 target-m68k/translate.c | 10 --
 1 file changed, 4 insertions(+), 6 deletions(-)


Reviewed-by: Richard Henderson 


r~

[Qemu-devel] [PATCH 49/52] target-m68k: cmp manages word and bytes operands

[Laurent Vivier]

Signed-off-by: Laurent Vivier 
---
 target-m68k/translate.c | 10 --
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/target-m68k/translate.c b/target-m68k/translate.c
index f880a2a..a22ee67 100644
--- a/target-m68k/translate.c
+++ b/target-m68k/translate.c
@@ -2724,10 +2724,9 @@ DISAS_INSN(cmp)
 int opsize;
 
 opsize = insn_opsize(insn);
-SRC_EA(env, src, opsize, -1, NULL);
-reg = DREG(insn, 9);
-gen_update_cc_add(reg, src);
-set_cc_op(s, CC_OP_CMP);
+SRC_EA(env, src, opsize, 1, NULL);
+reg = gen_extend(DREG(insn, 9), opsize, 1);
+gen_update_cc_cmp(s, reg, src, opsize);
 }
 
 DISAS_INSN(cmpa)
@@ -2743,8 +2742,7 @@ DISAS_INSN(cmpa)
 }
 SRC_EA(env, src, opsize, 1, NULL);
 reg = AREG(insn, 9);
-gen_update_cc_add(reg, src);
-set_cc_op(s, CC_OP_CMP);
+gen_update_cc_cmp(s, reg, src, opsize);
 }
 
 DISAS_INSN(eor)
-- 
2.5.5