Re: [PATCH 3/5] target/riscv: Fix pointer mask transformation for vector address
On 2023/3/27 18:00, Weiwei Li wrote: actual_address = (requested_address & ~mpmmask) | mpmbase. Signed-off-by: Weiwei Li Signed-off-by: Junqiang Wang --- target/riscv/vector_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/riscv/vector_helper.c b/target/riscv/vector_helper.c index 2423affe37..a58d82af8c 100644 --- a/target/riscv/vector_helper.c +++ b/target/riscv/vector_helper.c @@ -172,7 +172,7 @@ static inline uint32_t vext_get_total_elems(CPURISCVState *env, uint32_t desc, static inline target_ulong adjust_addr(CPURISCVState *env, target_ulong addr) { -return (addr & env->cur_pmmask) | env->cur_pmbase; +return (addr & ~env->cur_pmmask) | env->cur_pmbase; It's my typo. Thanks. Reviewed-by: LIU Zhiwei Zhiwei } /*
Re: [PATCH 3/5] target/riscv: Fix pointer mask transformation for vector address
On 3/27/23 07:00, Weiwei Li wrote: actual_address = (requested_address & ~mpmmask) | mpmbase. Signed-off-by: Weiwei Li Signed-off-by: Junqiang Wang --- target/riscv/vector_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/riscv/vector_helper.c b/target/riscv/vector_helper.c index 2423affe37..a58d82af8c 100644 --- a/target/riscv/vector_helper.c +++ b/target/riscv/vector_helper.c @@ -172,7 +172,7 @@ static inline uint32_t vext_get_total_elems(CPURISCVState *env, uint32_t desc, static inline target_ulong adjust_addr(CPURISCVState *env, target_ulong addr) { -return (addr & env->cur_pmmask) | env->cur_pmbase; +return (addr & ~env->cur_pmmask) | env->cur_pmbase; I'm impressed that this flew under the radar for so long. Reviewed-by: Daniel Henrique Barboza } /*
[PATCH 3/5] target/riscv: Fix pointer mask transformation for vector address
actual_address = (requested_address & ~mpmmask) | mpmbase. Signed-off-by: Weiwei Li Signed-off-by: Junqiang Wang --- target/riscv/vector_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/riscv/vector_helper.c b/target/riscv/vector_helper.c index 2423affe37..a58d82af8c 100644 --- a/target/riscv/vector_helper.c +++ b/target/riscv/vector_helper.c @@ -172,7 +172,7 @@ static inline uint32_t vext_get_total_elems(CPURISCVState *env, uint32_t desc, static inline target_ulong adjust_addr(CPURISCVState *env, target_ulong addr) { -return (addr & env->cur_pmmask) | env->cur_pmbase; +return (addr & ~env->cur_pmmask) | env->cur_pmbase; } /* -- 2.25.1