Re: [PULL 00/25] QAPI patches patches for 2021-09-25

2021-09-27 Thread Markus Armbruster
Peter Maydell  writes:

> On Sat, 25 Sept 2021 at 07:25, Markus Armbruster  wrote:
>>
>> The following changes since commit 11a11998460ed84d9a127c025f50f7234e5a483f:
>>
>>   Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20210921' into 
>> staging (2021-09-24 13:21:18 -0400)
>>
>> are available in the Git repository at:
>>
>>   git://repo.or.cz/qemu/armbru.git tags/pull-qapi-2021-09-25
>>
>> for you to fetch changes up to 5757c0904e2e8a7f5d9ff359b30542cfcb70556b:
>>
>>   tests/qapi-schema: Make test-qapi.py -u work when files are absent 
>> (2021-09-25 07:00:50 +0200)
>>
>> 
>> QAPI patches patches for 2021-09-25
>>
>
> Fails to build, all hosts except x86-64 Linux:
>
> In file included from qapi/qapi-visit-char.h:17,
>  from qapi/qapi-commands-char.c:19:
> qapi/qapi-types-char.h:500:5: error: unknown type name 'ChardevSpiceChannel'
>   500 | ChardevSpiceChannel *data;
>   | ^~~
> qapi/qapi-types-char.h:507:5: error: unknown type name 'ChardevSpicePort'
>   507 | ChardevSpicePort *data;
>   | ^~~~
> qapi/qapi-types-char.h:514:5: error: unknown type name 'ChardevQemuVDAgent'
>   514 | ChardevQemuVDAgent *data;
>   | ^~

Sorry about that.  Respin on the way.




Re: [PULL 00/25] QAPI patches patches for 2021-09-25

2021-09-25 Thread Peter Maydell
On Sat, 25 Sept 2021 at 07:25, Markus Armbruster  wrote:
>
> The following changes since commit 11a11998460ed84d9a127c025f50f7234e5a483f:
>
>   Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20210921' into 
> staging (2021-09-24 13:21:18 -0400)
>
> are available in the Git repository at:
>
>   git://repo.or.cz/qemu/armbru.git tags/pull-qapi-2021-09-25
>
> for you to fetch changes up to 5757c0904e2e8a7f5d9ff359b30542cfcb70556b:
>
>   tests/qapi-schema: Make test-qapi.py -u work when files are absent 
> (2021-09-25 07:00:50 +0200)
>
> 
> QAPI patches patches for 2021-09-25
>

Fails to build, all hosts except x86-64 Linux:

In file included from qapi/qapi-visit-char.h:17,
 from qapi/qapi-commands-char.c:19:
qapi/qapi-types-char.h:500:5: error: unknown type name 'ChardevSpiceChannel'
  500 | ChardevSpiceChannel *data;
  | ^~~
qapi/qapi-types-char.h:507:5: error: unknown type name 'ChardevSpicePort'
  507 | ChardevSpicePort *data;
  | ^~~~
qapi/qapi-types-char.h:514:5: error: unknown type name 'ChardevQemuVDAgent'
  514 | ChardevQemuVDAgent *data;
  | ^~


thanks
-- PMM



[PULL 00/25] QAPI patches patches for 2021-09-25

2021-09-25 Thread Markus Armbruster
The following changes since commit 11a11998460ed84d9a127c025f50f7234e5a483f:

  Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20210921' into 
staging (2021-09-24 13:21:18 -0400)

are available in the Git repository at:

  git://repo.or.cz/qemu/armbru.git tags/pull-qapi-2021-09-25

for you to fetch changes up to 5757c0904e2e8a7f5d9ff359b30542cfcb70556b:

  tests/qapi-schema: Make test-qapi.py -u work when files are absent 
(2021-09-25 07:00:50 +0200)


QAPI patches patches for 2021-09-25


Markus Armbruster (25):
  qapi: Tidy up unusual line breaks
  qapi: Stop enforcing "type name should not end in 'Kind'
  qapi: Convert simple union KeyValue to flat one
  qapi: Convert simple union InputEvent to flat one
  qapi: Convert simple union TpmTypeOptions to flat one
  qapi: Convert simple union MemoryDeviceInfo to flat one
  qapi: Convert simple union ChardevBackend to flat one
  qapi: Convert simple union SocketAddressLegacy to flat one
  qapi: Convert simple union ImageInfoSpecific to flat one
  qapi: Convert simple union TransactionAction to flat one
  tests/qapi-schema: Prepare for simple union UserDefListUnion removal
  test-qobject-input-visitor: Wean off UserDefListUnion
  test-qobject-output-visitor: Wean off UserDefListUnion
  test-clone-visitor: Wean off UserDefListUnion
  tests/qapi-schema: Wean off UserDefListUnion
  tests/qapi-schema: Simple union UserDefListUnion is now unused, drop
  tests/qapi-schema: Rewrite simple union TestIfUnion to be flat
  test-clone-visitor: Wean off __org.qemu_x-Union1
  tests/qapi-schema: Drop simple union __org.qemu_x-Union1
  tests/qapi-schema: Purge simple unions from tests
  qapi: Drop simple unions
  tests/qapi-schema: Rename flat-union-* test cases to union-*
  test-clone-visitor: Correct an accidental rename
  tests/qapi-schema: Use Python OSError instead of outmoded IOError
  tests/qapi-schema: Make test-qapi.py -u work when files are absent

 docs/devel/qapi-code-gen.rst   | 137 ++
 qapi/block-core.json   |  59 ++-
 qapi/char.json | 187 -
 qapi/machine.json  |  42 +-
 qapi/sockets.json  |  46 ++-
 qapi/tpm.json  |  24 +-
 qapi/transaction.json  | 139 +--
 qapi/ui.json   |  72 +++-
 backends/tpm/tpm_emulator.c|   2 +-
 backends/tpm/tpm_passthrough.c |   2 +-
 chardev/char-socket.c  |   6 +-
 chardev/char-udp.c |   4 +-
 monitor/hmp-cmds.c |   8 +-
 tests/unit/test-clone-visitor.c|  98 +++--
 tests/unit/test-qmp-cmds.c |  18 +-
 tests/unit/test-qobject-input-visitor.c| 460 +++--
 tests/unit/test-qobject-output-visitor.c   | 391 +-
 tests/unit/test-yank.c |   6 +-
 util/qemu-sockets.c|   8 +-
 scripts/qapi/expr.py   |  27 +-
 scripts/qapi/schema.py | 101 +
 tests/qapi-schema/args-union.err   |   2 +-
 tests/qapi-schema/args-union.json  |   8 +-
 tests/qapi-schema/bad-base.err |   2 +-
 tests/qapi-schema/bad-base.json|   8 +-
 tests/qapi-schema/doc-good.json|  13 +-
 tests/qapi-schema/doc-good.out |  22 -
 tests/qapi-schema/doc-good.txt |  20 -
 tests/qapi-schema/enum-if-invalid.json |   4 +-
 tests/qapi-schema/flat-union-array-branch.err  |   2 -
 tests/qapi-schema/flat-union-bad-base.err  |   2 -
 tests/qapi-schema/flat-union-bad-discriminator.err |   2 -
 tests/qapi-schema/flat-union-base-any.err  |   2 -
 tests/qapi-schema/flat-union-base-union.err|   2 -
 tests/qapi-schema/flat-union-clash-member.err  |   2 -
 .../flat-union-discriminator-bad-name.err  |   2 -
 tests/qapi-schema/flat-union-empty.err |   2 -
 tests/qapi-schema/flat-union-empty.json|   4 -
 .../qapi-schema/flat-union-inline-invalid-dict.err |   2 -
 tests/qapi-schema/flat-union-int-branch.err|   2 -
 .../qapi-schema/flat-union-invalid-branch-key.err  |   2 -
 .../flat-union-invalid-discriminator.err   |   2 -
 .../flat-union-invalid-if-discriminator.err|   2 -
 tests/qapi-schema/flat-union-no-base.err   |   2 -
 .../flat-union-optional-discriminator.err  |   2 -
 .../flat-union-string-discriminator.err