Re: [Qemu-devel] [PATCH] Fix some typos found by codespell
23.03.2016 17:59, Stefan Weil wrote: [...] FINALLY! Applied to -trivial. With the additional fix suggested by Peter, and without util/qemu-sockets.c change which has been applied meanwhile. Thank you! /mjt
Re: [Qemu-devel] [PATCH] Fix some typos found by codespell
Quoting Stefan Weil (2016-03-23 09:59:57)
> Signed-off-by: Stefan Weil
> ---
>
> I hope that it is fine not to split this in lots of
> small patches.
>
> Regards
> Stefan
>
> audio/mixeng.c | 2 +-
> audio/ossaudio.c| 2 +-
> contrib/ivshmem-server/ivshmem-server.h | 2 +-
> docs/specs/rocker.txt | 2 +-
> docs/throttle.txt | 2 +-
> hw/i2c/imx_i2c.c| 2 +-
> hw/net/vmxnet3.c| 4 ++--
> hw/pci/msi.c| 2 +-
> hw/pci/pci_bridge.c | 2 +-
> hw/scsi/spapr_vscsi.c | 2 +-
> hw/scsi/vmw_pvscsi.c| 2 +-
> hw/timer/a9gtimer.c | 2 +-
> hw/timer/aspeed_timer.c | 4 ++--
> include/crypto/random.h | 2 +-
> include/hw/xen/xen_common.h | 2 +-
> include/io/task.h | 2 +-
> include/qemu/osdep.h| 2 +-
> kvm-all.c | 2 +-
> migration/migration.c | 2 +-
> migration/ram.c | 2 +-
> nbd/client.c| 2 +-
> qga/channel-win32.c | 2 +-
> qga/commands.c | 2 +-
> scripts/checkpatch.pl | 2 +-
> slirp/socket.c | 2 +-
> target-cris/translate.c | 4 ++--
> target-cris/translate_v10.c | 2 +-
> target-i386/cpu.c | 2 +-
> target-i386/cpu.h | 2 +-
> target-mips/op_helper.c | 2 +-
> target-tricore/translate.c | 2 +-
> tcg/README | 2 +-
> tests/tcg/cris/check_addo.c | 14 +++---
> trace/simple.c | 4 ++--
> ui/cocoa.m | 2 +-
> util/qemu-sockets.c | 2 +-
> util/timed-average.c| 4 ++--
> 37 files changed, 48 insertions(+), 48 deletions(-)
>
> diff --git a/audio/mixeng.c b/audio/mixeng.c
> index 981b97a..61ef869 100644
> --- a/audio/mixeng.c
> +++ b/audio/mixeng.c
> @@ -270,7 +270,7 @@ f_sample *mixeng_clip[2][2][2][3] = {
> * August 21, 1998
> * Copyright 1998 Fabrice Bellard.
> *
> - * [Rewrote completly the code of Lance Norskog And Sundry
> + * [Rewrote completely the code of Lance Norskog And Sundry
> * Contributors with a more efficient algorithm.]
> *
> * This source code is freely redistributable and may be used for
> diff --git a/audio/ossaudio.c b/audio/ossaudio.c
> index 349e9dd..a0d9cda 100644
> --- a/audio/ossaudio.c
> +++ b/audio/ossaudio.c
> @@ -898,7 +898,7 @@ static struct audio_option oss_options[] = {
> .name = "EXCLUSIVE",
> .tag = AUD_OPT_BOOL,
> .valp = &glob_conf.exclusive,
> -.descr = "Open device in exclusive mode (vmix wont work)"
> +.descr = "Open device in exclusive mode (vmix won't work)"
> },
> #ifdef USE_DSP_POLICY
> {
> diff --git a/contrib/ivshmem-server/ivshmem-server.h
> b/contrib/ivshmem-server/ivshmem-server.h
> index 3851639..d37ca85 100644
> --- a/contrib/ivshmem-server/ivshmem-server.h
> +++ b/contrib/ivshmem-server/ivshmem-server.h
> @@ -15,7 +15,7 @@
> * unix socket. For each client, the server will create some eventfd
> * (see EVENTFD(2)), one per vector. These fd are transmitted to all
> * clients using the SCM_RIGHTS cmsg message. Therefore, each client is
> - * able to send a notification to another client without beeing
> + * able to send a notification to another client without being
> * "profixied" by the server.
> *
> * We use this mechanism to send interruptions between guests.
> diff --git a/docs/specs/rocker.txt b/docs/specs/rocker.txt
> index d2a8262..1857b31 100644
> --- a/docs/specs/rocker.txt
> +++ b/docs/specs/rocker.txt
> @@ -303,7 +303,7 @@ Endianness
> --
>
> Device registers are hard-coded to little-endian (LE). The driver should
> -convert to/from host endianess to LE for device register accesses.
> +convert to/from host endianness to LE for device register accesses.
>
> Descriptors are LE. Descriptor buffer TLVs will have LE type and length
> fields, but the value field can either be LE or network-byte-order, depending
> diff --git a/docs/throttle.txt b/docs/throttle.txt
> index 28204e4..06ed9b3 100644
> --- a/docs/throttle.txt
> +++ b/docs/throttle.txt
> @@ -10,7 +10,7 @@ Introduction
>
> QEMU includes a throttling module that can be used to set limits to
> I/O operations. The code itself is generic and independent of the I/O
> -units, but it is currenly used to limit the number of bytes per second
> +units, but it is currently used to limit the number of bytes per second
> and operations per second (IOPS) when performing disk I/O.
>
> This document explains how
Re: [Qemu-devel] [PATCH] Fix some typos found by codespell
On Wed, Mar 23, 2016 at 03:59:57PM +0100, Stefan Weil wrote: > trace/simple.c | 4 ++-- Acked-by: Stefan Hajnoczi signature.asc Description: PGP signature
Re: [Qemu-devel] [PATCH] Fix some typos found by codespell
On 03/23/2016 11:13 AM, Stefan Weil wrote: > I'm no longer sure which spelling is correct. :-) > >>From https://www.fsf.org/about/history.html: > 1985 Richard Stallman creates the Free Sofware Foundation I got a good chuckle out of that; then sent off a bug report to the webmaster. That page is now fixed :) -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature
Re: [Qemu-devel] [PATCH] Fix some typos found by codespell
Am 23.03.2016 um 17:36 schrieb Peter Maydell: > On 23 March 2016 at 14:59, Stefan Weil wrote: >> - * This program is free sofware: you can redistribute it and/or modify >> + * This program is free software: you can redistribute it and/or modify >> * it under the terms of the GNU General Public License as published by >> - * the Free Sofware Foundation, either version 2 of the License, or >> + * the Free Software Foundation, either version 2 of the License, or >> * (at your option) version 3 or any later version. >> * >> * This program is distributed in the hope that it will be useful, > > ...I wonder how we ended up with a license boilerplate with typos; > they're almost always just cut-n-pasted from another copy... I'm no longer sure which spelling is correct. :-) >From https://www.fsf.org/about/history.html: 1985 Richard Stallman creates the Free Sofware Foundation Google finds around 1000 more instances. Thanks for the review and the additional correction. I think it can be added manually when the patch is applied to qemu-trivial, therefore I won't send an updated patch. Regards, Stefan
Re: [Qemu-devel] [PATCH] Fix some typos found by codespell
On 23 March 2016 at 14:59, Stefan Weil wrote: > Signed-off-by: Stefan Weil > --- > > I hope that it is fine not to split this in lots of > small patches. > --- a/qga/channel-win32.c > +++ b/qga/channel-win32.c > @@ -77,7 +77,7 @@ static gboolean ga_channel_prepare(GSource *source, gint > *timeout_ms) > } > > out: > -/* dont block forever, iterate the main loop every once and a while */ > +/* don't block forever, iterate the main loop every once and a while */ Should be "once in a while". > *timeout_ms = 500; > /* if there's data in the read buffer, or another event is pending, > * skip polling and issue user cb. > --- a/util/timed-average.c > +++ b/util/timed-average.c > @@ -8,9 +8,9 @@ > * Benoît Canet > * Alberto Garcia > * > - * This program is free sofware: you can redistribute it and/or modify > + * This program is free software: you can redistribute it and/or modify > * it under the terms of the GNU General Public License as published by > - * the Free Sofware Foundation, either version 2 of the License, or > + * the Free Software Foundation, either version 2 of the License, or > * (at your option) version 3 or any later version. > * > * This program is distributed in the hope that it will be useful, ...I wonder how we ended up with a license boilerplate with typos; they're almost always just cut-n-pasted from another copy... Otherwise Reviewed-by: Peter Maydell thanks -- PMM thanks -- PMM
[Qemu-devel] [PATCH] Fix some typos found by codespell
Signed-off-by: Stefan Weil
---
I hope that it is fine not to split this in lots of
small patches.
Regards
Stefan
audio/mixeng.c | 2 +-
audio/ossaudio.c| 2 +-
contrib/ivshmem-server/ivshmem-server.h | 2 +-
docs/specs/rocker.txt | 2 +-
docs/throttle.txt | 2 +-
hw/i2c/imx_i2c.c| 2 +-
hw/net/vmxnet3.c| 4 ++--
hw/pci/msi.c| 2 +-
hw/pci/pci_bridge.c | 2 +-
hw/scsi/spapr_vscsi.c | 2 +-
hw/scsi/vmw_pvscsi.c| 2 +-
hw/timer/a9gtimer.c | 2 +-
hw/timer/aspeed_timer.c | 4 ++--
include/crypto/random.h | 2 +-
include/hw/xen/xen_common.h | 2 +-
include/io/task.h | 2 +-
include/qemu/osdep.h| 2 +-
kvm-all.c | 2 +-
migration/migration.c | 2 +-
migration/ram.c | 2 +-
nbd/client.c| 2 +-
qga/channel-win32.c | 2 +-
qga/commands.c | 2 +-
scripts/checkpatch.pl | 2 +-
slirp/socket.c | 2 +-
target-cris/translate.c | 4 ++--
target-cris/translate_v10.c | 2 +-
target-i386/cpu.c | 2 +-
target-i386/cpu.h | 2 +-
target-mips/op_helper.c | 2 +-
target-tricore/translate.c | 2 +-
tcg/README | 2 +-
tests/tcg/cris/check_addo.c | 14 +++---
trace/simple.c | 4 ++--
ui/cocoa.m | 2 +-
util/qemu-sockets.c | 2 +-
util/timed-average.c| 4 ++--
37 files changed, 48 insertions(+), 48 deletions(-)
diff --git a/audio/mixeng.c b/audio/mixeng.c
index 981b97a..61ef869 100644
--- a/audio/mixeng.c
+++ b/audio/mixeng.c
@@ -270,7 +270,7 @@ f_sample *mixeng_clip[2][2][2][3] = {
* August 21, 1998
* Copyright 1998 Fabrice Bellard.
*
- * [Rewrote completly the code of Lance Norskog And Sundry
+ * [Rewrote completely the code of Lance Norskog And Sundry
* Contributors with a more efficient algorithm.]
*
* This source code is freely redistributable and may be used for
diff --git a/audio/ossaudio.c b/audio/ossaudio.c
index 349e9dd..a0d9cda 100644
--- a/audio/ossaudio.c
+++ b/audio/ossaudio.c
@@ -898,7 +898,7 @@ static struct audio_option oss_options[] = {
.name = "EXCLUSIVE",
.tag = AUD_OPT_BOOL,
.valp = &glob_conf.exclusive,
-.descr = "Open device in exclusive mode (vmix wont work)"
+.descr = "Open device in exclusive mode (vmix won't work)"
},
#ifdef USE_DSP_POLICY
{
diff --git a/contrib/ivshmem-server/ivshmem-server.h
b/contrib/ivshmem-server/ivshmem-server.h
index 3851639..d37ca85 100644
--- a/contrib/ivshmem-server/ivshmem-server.h
+++ b/contrib/ivshmem-server/ivshmem-server.h
@@ -15,7 +15,7 @@
* unix socket. For each client, the server will create some eventfd
* (see EVENTFD(2)), one per vector. These fd are transmitted to all
* clients using the SCM_RIGHTS cmsg message. Therefore, each client is
- * able to send a notification to another client without beeing
+ * able to send a notification to another client without being
* "profixied" by the server.
*
* We use this mechanism to send interruptions between guests.
diff --git a/docs/specs/rocker.txt b/docs/specs/rocker.txt
index d2a8262..1857b31 100644
--- a/docs/specs/rocker.txt
+++ b/docs/specs/rocker.txt
@@ -303,7 +303,7 @@ Endianness
--
Device registers are hard-coded to little-endian (LE). The driver should
-convert to/from host endianess to LE for device register accesses.
+convert to/from host endianness to LE for device register accesses.
Descriptors are LE. Descriptor buffer TLVs will have LE type and length
fields, but the value field can either be LE or network-byte-order, depending
diff --git a/docs/throttle.txt b/docs/throttle.txt
index 28204e4..06ed9b3 100644
--- a/docs/throttle.txt
+++ b/docs/throttle.txt
@@ -10,7 +10,7 @@ Introduction
QEMU includes a throttling module that can be used to set limits to
I/O operations. The code itself is generic and independent of the I/O
-units, but it is currenly used to limit the number of bytes per second
+units, but it is currently used to limit the number of bytes per second
and operations per second (IOPS) when performing disk I/O.
This document explains how to use the throttling code in QEMU, and how
diff --git a/hw/i2c/imx_i2c.c b/hw/i2c/imx_i2c.c
index a01e43e..e19d4fa 100644
--- a/hw/i2c/imx_i2c.c
+++ b/hw/i2c/imx_i2c.c
@@ -247,7 +247,7 @@ static void imx_i2c_write(void *opaque, hwaddr offset,
if (s->ad
