Re: [Qemu-devel] [PATCH 00/11] qdev: remove DeviceClass::init/exit()
Hi, This series failed docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 20180116131555.14242-1-f4...@amsat.org Subject: [Qemu-devel] [PATCH 00/11] qdev: remove DeviceClass::init/exit() === TEST SCRIPT BEGIN === #!/bin/bash set -e git submodule update --init dtc # Let docker tests dump environment info export SHOW_ENV=1 export J=8 time make docker-test-mingw@fedora === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu t [tag update]patchew/20180115170243.24578-1-berra...@redhat.com -> patchew/20180115170243.24578-1-berra...@redhat.com Switched to a new branch 'test' 8a511044fd qdev: rename typedef qdev_resetfn() -> DeviceReset() 7b8b539cc2 qdev: remove empty realize/unrealize stubs 8eb472976f qdev: remove DeviceClass::exit 0f4697db59 qdev: remove DeviceClass::init a2de037067 qdev: simplify the SysBusDeviceClass::init path d84d6882ed sysbus: add realize() and unrealize() dae9ccfb44 virtio-ccw: convert VirtIOCCWDeviceClass::init -> realize 2c474c1777 usb-ccid: convert CCIDCardClass::init -> realize bc93b82615 hw/i2c: convert I2CSlaveClass::init -> realize 515a5a9b11 smbus_eeprom: replace SMBusDeviceClass::init by DeviceClass::reset 224b669cd4 smbus: add a NULL check for SMBusDeviceClass::init callbacks === OUTPUT BEGIN === Submodule 'dtc' (git://git.qemu-project.org/dtc.git) registered for path 'dtc' Cloning into '/var/tmp/patchew-tester-tmp-t68avrnp/src/dtc'... Submodule path 'dtc': checked out 'e54388015af1fb4bf04d0bca99caba1074d9cc42' BUILD fedora make[1]: Entering directory '/var/tmp/patchew-tester-tmp-t68avrnp/src' GEN /var/tmp/patchew-tester-tmp-t68avrnp/src/docker-src.2018-01-17-00.43.41.32609/qemu.tar Cloning into '/var/tmp/patchew-tester-tmp-t68avrnp/src/docker-src.2018-01-17-00.43.41.32609/qemu.tar.vroot'... done. Checking out files: 44% (2547/5723) Checking out files: 45% (2576/5723) Checking out files: 46% (2633/5723) Checking out files: 47% (2690/5723) Checking out files: 48% (2748/5723) Checking out files: 49% (2805/5723) Checking out files: 50% (2862/5723) Checking out files: 51% (2919/5723) Checking out files: 52% (2976/5723) Checking out files: 53% (3034/5723) Checking out files: 54% (3091/5723) Checking out files: 55% (3148/5723) Checking out files: 56% (3205/5723) Checking out files: 57% (3263/5723) Checking out files: 58% (3320/5723) Checking out files: 59% (3377/5723) Checking out files: 60% (3434/5723) Checking out files: 61% (3492/5723) Checking out files: 62% (3549/5723) Checking out files: 63% (3606/5723) Checking out files: 64% (3663/5723) Checking out files: 65% (3720/5723) Checking out files: 66% (3778/5723) Checking out files: 67% (3835/5723) Checking out files: 68% (3892/5723) Checking out files: 69% (3949/5723) Checking out files: 70% (4007/5723) Checking out files: 71% (4064/5723) Checking out files: 72% (4121/5723) Checking out files: 73% (4178/5723) Checking out files: 74% (4236/5723) Checking out files: 75% (4293/5723) Checking out files: 76% (4350/5723) Checking out files: 77% (4407/5723) Checking out files: 78% (4464/5723) Checking out files: 79% (4522/5723) Checking out files: 80% (4579/5723) Checking out files: 81% (4636/5723) Checking out files: 82% (4693/5723) Checking out files: 83% (4751/5723) Checking out files: 84% (4808/5723) Checking out files: 85% (4865/5723) Checking out files: 86% (4922/5723) Checking out files: 87% (4980/5723) Checking out files: 88% (5037/5723) Checking out files: 89% (5094/5723) Checking out files: 90% (5151/5723) Checking out files: 91% (5208/5723) Checking out files: 92% (5266/5723) Checking out files: 93% (5323/5723) Checking out files: 94% (5380/5723) Checking out files: 95% (5437/5723) Checking out files: 96% (5495/5723) Checking out files: 97% (5552/5723) Checking out files: 98% (5609/5723) Checking out files: 99% (5666/5723) Checking out files: 100% (5723/5723) Checking out files: 100% (5723/5723), done. Your branch is up-to-date with 'origin/test'. Submodule 'dtc' (git://git.qemu-project.org/dtc.git) registered for path 'dtc' Cloning into '/var/tmp/patchew-tester-tmp-t68avrnp/src/docker-src.2018-01-17-00.43.41.32609/qemu.tar.vroot/dtc'... Submodule path 'dtc': checked out 'e54388015af1fb4bf04d0bca99caba1074d9cc42' Submodule 'ui/keycodemapdb' (git://git.qemu.org/keycodemapdb.git) registered for path 'ui/keycodemapdb' Cloning into '/var/tmp/patchew-tester-tmp-t68avrnp/src/docker-src.2018-01-17-00.43.41.3
[Qemu-devel] [PATCH 00/11] qdev: remove DeviceClass::init/exit()
Hi, This series finalize the qdev QOMification. We first convert the I2CSlave/SMBusDevice, then the usb-ccid and virtio-ccw, and finally the SysBusDevice. At the end we get one less TODO :) /* TODO remove, once users are converted to unrealize */ There is still one standing in SysBusDeviceClass::init(). Regards, Phil. Philippe Mathieu-Daudé (11): smbus: add a NULL check for SMBusDeviceClass::init callbacks smbus_eeprom: replace SMBusDeviceClass::init by DeviceClass::reset hw/i2c: convert I2CSlaveClass::init -> realize usb-ccid: convert CCIDCardClass::init -> realize virtio-ccw: convert VirtIOCCWDeviceClass::init -> realize sysbus: add realize() and unrealize() qdev: simplify the SysBusDeviceClass::init path qdev: remove DeviceClass::init qdev: remove DeviceClass::exit qdev: remove empty realize/unrealize stubs qdev: rename typedef qdev_resetfn() -> DeviceReset() hw/s390x/virtio-ccw.h | 2 +- hw/usb/ccid.h | 9 +-- include/hw/i2c/i2c.h | 2 +- include/hw/i2c/smbus.h| 2 +- include/hw/qdev-core.h| 8 ++ include/hw/sysbus.h | 4 +++ hw/audio/wm8750.c | 8 +++--- hw/core/qdev.c| 28 - hw/core/sysbus.c | 30 +++ hw/display/ssd0303.c | 5 ++-- hw/gpio/max7310.c | 6 ++--- hw/i2c/core.c | 10 +++- hw/i2c/smbus.c| 8 +++--- hw/i2c/smbus_eeprom.c | 5 ++-- hw/input/lm832x.c | 5 ++-- hw/misc/tmp105.c | 6 ++--- hw/misc/tmp421.c | 6 ++--- hw/nvram/eeprom_at24c.c | 24 +- hw/s390x/virtio-ccw.c | 35 +- hw/timer/twl92230.c | 12 - hw/usb/ccid-card-emulated.c | 42 --- hw/usb/ccid-card-passthru.c | 10 hw/usb/dev-smartcard-reader.c | 57 +++ 23 files changed, 145 insertions(+), 179 deletions(-) -- 2.15.1
