Re: [Qemu-devel] [PATCH 04/19] tests/tcg: comment unused code

[Alex Bennée]

Pranith Kumar  writes:

> From: Marc-André Lureau 
>
> I didn't remove it, as suggest by checkpatch, because it looks like it
> may eventually be restored back.

I'm not so sure, especially with having full source control. Either fix
it or delete it please.

>
> Signed-off-by: Marc-André Lureau 
> Signed-off-by: Pranith Kumar 
> ---
>  tests/tcg/linux-test.c  | 8 ++--
>  tests/tcg/test-i386-fprem.c | 4 
>  2 files changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/tests/tcg/linux-test.c b/tests/tcg/linux-test.c
> index 5070d31..38d163c 100644
> --- a/tests/tcg/linux-test.c
> +++ b/tests/tcg/linux-test.c
> @@ -350,6 +350,7 @@ void test_socket(void)
>
>  #define WCOUNT_MAX 512
>
> +#if 0
>  void test_pipe(void)
>  {
>  fd_set rfds, wfds;
> @@ -421,11 +422,13 @@ void test_clone(void)
>
>  stack1 = malloc(STACK_SIZE);
>  pid1 = chk_error(clone(thread1_func, stack1 + STACK_SIZE,
> -   CLONE_VM | CLONE_FS | CLONE_FILES | SIGCHLD, 
> "hello1"));
> +   CLONE_VM | CLONE_FS | CLONE_FILES |
> +   SIGCHLD, (void *)"hello1"));
>
>  stack2 = malloc(STACK_SIZE);
>  pid2 = chk_error(clone(thread2_func, stack2 + STACK_SIZE,
> -   CLONE_VM | CLONE_FS | CLONE_FILES | SIGCHLD, 
> "hello2"));
> +   CLONE_VM | CLONE_FS | CLONE_FILES | SIGCHLD,
> +   (void *)"hello2"));
>
>  while (waitpid(pid1, , 0) != pid1);
>  free(stack1);
> @@ -435,6 +438,7 @@ void test_clone(void)
>  thread2_res != 6)
>  error("clone");
>  }
> +#endif
>
>  /***/
>
> diff --git a/tests/tcg/test-i386-fprem.c b/tests/tcg/test-i386-fprem.c
> index 1a71623..1a2b144 100644
> --- a/tests/tcg/test-i386-fprem.c
> +++ b/tests/tcg/test-i386-fprem.c
> @@ -54,6 +54,7 @@ union float80u {
>
>  #define IEEE854_LONG_DOUBLE_BIAS 0x3fff
>
> +#if 0
>  static const union float80u q_nan = {
>  .ieee_nan.negative = 0,  /* X */
>  .ieee_nan.exponent = 0x7fff,
> @@ -61,6 +62,7 @@ static const union float80u q_nan = {
>  .ieee_nan.quiet_nan = 1,
>  .ieee_nan.mantissa = 0,
>  };
> +#endif
>
>  static const union float80u s_nan = {
>  .ieee_nan.negative = 0,  /* X */
> @@ -91,12 +93,14 @@ static const union float80u pos_denorm = {
>  .ieee.mantissa = 1,
>  };
>
> +#if 0
>  static const union float80u smallest_positive_norm = {
>  .ieee.negative = 0,
>  .ieee.exponent = 1,
>  .ieee.one = 1,
>  .ieee.mantissa = 0,
>  };
> +#endif
>
>  static void fninit()
>  {


--
Alex Bennée

[Qemu-devel] [PATCH 04/19] tests/tcg: comment unused code

[Pranith Kumar]

From: Marc-André Lureau 

I didn't remove it, as suggest by checkpatch, because it looks like it
may eventually be restored back.

Signed-off-by: Marc-André Lureau 
Signed-off-by: Pranith Kumar 
---
 tests/tcg/linux-test.c  | 8 ++--
 tests/tcg/test-i386-fprem.c | 4 
 2 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/tests/tcg/linux-test.c b/tests/tcg/linux-test.c
index 5070d31..38d163c 100644
--- a/tests/tcg/linux-test.c
+++ b/tests/tcg/linux-test.c
@@ -350,6 +350,7 @@ void test_socket(void)
 
 #define WCOUNT_MAX 512
 
+#if 0
 void test_pipe(void)
 {
 fd_set rfds, wfds;
@@ -421,11 +422,13 @@ void test_clone(void)
 
 stack1 = malloc(STACK_SIZE);
 pid1 = chk_error(clone(thread1_func, stack1 + STACK_SIZE,
-   CLONE_VM | CLONE_FS | CLONE_FILES | SIGCHLD, 
"hello1"));
+   CLONE_VM | CLONE_FS | CLONE_FILES |
+   SIGCHLD, (void *)"hello1"));
 
 stack2 = malloc(STACK_SIZE);
 pid2 = chk_error(clone(thread2_func, stack2 + STACK_SIZE,
-   CLONE_VM | CLONE_FS | CLONE_FILES | SIGCHLD, 
"hello2"));
+   CLONE_VM | CLONE_FS | CLONE_FILES | SIGCHLD,
+   (void *)"hello2"));
 
 while (waitpid(pid1, , 0) != pid1);
 free(stack1);
@@ -435,6 +438,7 @@ void test_clone(void)
 thread2_res != 6)
 error("clone");
 }
+#endif
 
 /***/
 
diff --git a/tests/tcg/test-i386-fprem.c b/tests/tcg/test-i386-fprem.c
index 1a71623..1a2b144 100644
--- a/tests/tcg/test-i386-fprem.c
+++ b/tests/tcg/test-i386-fprem.c
@@ -54,6 +54,7 @@ union float80u {
 
 #define IEEE854_LONG_DOUBLE_BIAS 0x3fff
 
+#if 0
 static const union float80u q_nan = {
 .ieee_nan.negative = 0,  /* X */
 .ieee_nan.exponent = 0x7fff,
@@ -61,6 +62,7 @@ static const union float80u q_nan = {
 .ieee_nan.quiet_nan = 1,
 .ieee_nan.mantissa = 0,
 };
+#endif
 
 static const union float80u s_nan = {
 .ieee_nan.negative = 0,  /* X */
@@ -91,12 +93,14 @@ static const union float80u pos_denorm = {
 .ieee.mantissa = 1,
 };
 
+#if 0
 static const union float80u smallest_positive_norm = {
 .ieee.negative = 0,
 .ieee.exponent = 1,
 .ieee.one = 1,
 .ieee.mantissa = 0,
 };
+#endif
 
 static void fninit()
 {
-- 
2.10.2