Re: [Qemu-devel] [RFC][PATCH v2 08/17] qapi: fix Error usage in qemu-sockets.c

2011-04-21 Thread Jes Sorensen 
On 04/18/11 17:02, Michael Roth wrote:
 Fix spurious errors due to not initializing Error pointer to NULL before
 checking for errors.
 
 Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com
 ---
  qemu-sockets.c |2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)
 
 diff --git a/qemu-sockets.c b/qemu-sockets.c
 index dc8beeb..e709e5f 100644
 --- a/qemu-sockets.c
 +++ b/qemu-sockets.c
 @@ -630,7 +630,7 @@ int unix_connect(const char *path)
  {
  QemuOpts *opts;
  int sock;
 -Error *err;
 +Error *err = NULL;
  
  opts = qemu_opts_create(dummy_opts, NULL, 0, err);
  if (err) {

This one really should go into the tree asap, even if the rest of the
virt agent patches are still pending.

Reviewed-by: Jes Sorensen jes.soren...@redhat.com

[Qemu-devel] [RFC][PATCH v2 08/17] qapi: fix Error usage in qemu-sockets.c

2011-04-18 Thread Michael Roth 
Fix spurious errors due to not initializing Error pointer to NULL before
checking for errors.

Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com
---
 qemu-sockets.c |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/qemu-sockets.c b/qemu-sockets.c
index dc8beeb..e709e5f 100644
--- a/qemu-sockets.c
+++ b/qemu-sockets.c
@@ -630,7 +630,7 @@ int unix_connect(const char *path)
 {
 QemuOpts *opts;
 int sock;
-Error *err;
+Error *err = NULL;
 
 opts = qemu_opts_create(dummy_opts, NULL, 0, err);
 if (err) {
-- 
1.7.0.4