Re: [Rd] R Language Definition: Subsetting matrices with negative indices is *not* an error

2015-05-09 Thread peter dalgaard

> On 09 May 2015, at 22:33 , Henrik Bengtsson  wrote:
> 
> On Sat, May 9, 2015 at 12:55 AM, peter dalgaard  wrote:
>> 
>> 
>> Rephrasing would seem to be in order
> 
> Ah... definitely a "parse error" (I read it as a new paragraph).  I
> second rephrasing this; your ""Indexing matrices may not contain
> negative indices" is non-ambiguous.

Now in R-devel.

-- 
Peter Dalgaard, Professor,
Center for Statistics, Copenhagen Business School
Solbjerg Plads 3, 2000 Frederiksberg, Denmark
Phone: (+45)38153501
Email: pd@cbs.dk  Priv: pda...@gmail.com

__
R-devel@r-project.org mailing list
https://stat.ethz.ch/mailman/listinfo/r-devel


[Rd] PATCH: library(..., quietly=TRUE) still outputs "Loading required package: ..." (forgot to pass down 'quietly')

2015-05-09 Thread Henrik Bengtsson
Calling library(..., quietly=TRUE) may still output:

   Loading required package: 

in some cases, e.g.

> library("R.utils", quietly=TRUE)
Loading required package: R.methodsS3
[...]

I traced this to base:::.getRequiredPackages2(), which forgets to pass
'quietly' to an internal library() call:

if (!attached) {
if (!quietly)
packageStartupMessage(gettextf("Loading required package: %s",
  pkg), domain = NA)
library(pkg, character.only = TRUE, logical.return = TRUE,
lib.loc = lib.loc) || stop(gettextf("package %s could not be loaded",

sQuote(pkg)), call. = FALSE, domain = NA)
}

It's from that library() call the message is generated.


Here's a patch:

$ svn diff src\library\base\R\library.R
Index: src/library/base/R/library.R
===
--- src/library/base/R/library.R(revision 68345)
+++ src/library/base/R/library.R(working copy)
@@ -871,7 +871,7 @@
 packageStartupMessage(gettextf("Loading required package: %s",
pkg), domain = NA)
 library(pkg, character.only = TRUE, logical.return = TRUE,
-lib.loc = lib.loc) ||
+lib.loc = lib.loc, quietly = quietly) ||
 stop(gettextf("package %s could not be loaded", sQuote(pkg)),
  call. = FALSE, domain = NA)
 }

I can submit it via http://bugs.r-project.org/ if preferred.


Thanks,

Henrik

__
R-devel@r-project.org mailing list
https://stat.ethz.ch/mailman/listinfo/r-devel


Re: [Rd] R Language Definition: Subsetting matrices with negative indices is *not* an error

2015-05-09 Thread Bert Gunter
Ah, the woes of English word order -- even this native English speaker
frequently gets messed up!

(but maybe I'm just a bear of little brain).

Best,
Bert

Bert Gunter
Genentech Nonclinical Biostatistics
(650) 467-7374

"Data is not information. Information is not knowledge. And knowledge
is certainly not wisdom."
Clifford Stoll




On Sat, May 9, 2015 at 1:33 PM, Henrik Bengtsson
 wrote:
> On Sat, May 9, 2015 at 12:55 AM, peter dalgaard  wrote:
>>
>>> On 09 May 2015, at 02:53 , Henrik Bengtsson  
>>> wrote:
>>>
>>> Hi,
>>>
>>> I spotted what looks like another(*) mistake in 'R Language
>>> Definition' on how subsetting should work.  In Section 'Indexing
>>> matrices and arrays'
>>> [http://cran.r-project.org/doc/manuals/r-release/R-lang.html#Indexing-matrices-and-arrays]
>>> one can read
>>>
>>>   "Negative indices are not allowed in indexing matrices."
>>
>> Parse error: I believe that this is intended to mean
>>
>> "Indexing matrices may not contain negative indices"
>>
>> not
>>
>> "You cannot use negative indices when indexing matrices".
>>
>> This is consistent with the help page:
>>
>> "
>>  A third form of indexing is via a numeric matrix with the one
>>  column for each dimension: each row of the index matrix then
>>  selects a single element of the array, and the result is a vector.
>>  Negative indices are not allowed in the index matrix.
>> "
>>
>> Rephrasing would seem to be in order
>
> Ah... definitely a "parse error" (I read it as a new paragraph).  I
> second rephrasing this; your ""Indexing matrices may not contain
> negative indices" is non-ambiguous.
>
> Thanks Peter
>
> /Henrik
>
>>
>> -pd
>>
>>>
>>> but this is not true, e.g.
>>>
 x <- matrix(1:12, nrow=4)
 x
>>> [,1] [,2] [,3]
>>> [1,]159
>>> [2,]26   10
>>> [3,]37   11
>>> [4,]48   12
>>>
 x[c(-2,-4),]
>>> [,1] [,2] [,3]
>>> [1,]159
>>> [2,]37   11
>>>
>>> /Henrik
>>>
>>> (*) https://stat.ethz.ch/pipermail/r-devel/2015-May/071091.html [docs
>>> have been fixed]
>>>
>>> __
>>> R-devel@r-project.org mailing list
>>> https://stat.ethz.ch/mailman/listinfo/r-devel
>>
>> --
>> Peter Dalgaard, Professor,
>> Center for Statistics, Copenhagen Business School
>> Solbjerg Plads 3, 2000 Frederiksberg, Denmark
>> Phone: (+45)38153501
>> Email: pd@cbs.dk  Priv: pda...@gmail.com
>>
>>
>>
>>
>>
>>
>>
>>
>
> __
> R-devel@r-project.org mailing list
> https://stat.ethz.ch/mailman/listinfo/r-devel

__
R-devel@r-project.org mailing list
https://stat.ethz.ch/mailman/listinfo/r-devel


Re: [Rd] R Language Definition: Subsetting matrices with negative indices is *not* an error

2015-05-09 Thread Henrik Bengtsson
On Sat, May 9, 2015 at 12:55 AM, peter dalgaard  wrote:
>
>> On 09 May 2015, at 02:53 , Henrik Bengtsson  
>> wrote:
>>
>> Hi,
>>
>> I spotted what looks like another(*) mistake in 'R Language
>> Definition' on how subsetting should work.  In Section 'Indexing
>> matrices and arrays'
>> [http://cran.r-project.org/doc/manuals/r-release/R-lang.html#Indexing-matrices-and-arrays]
>> one can read
>>
>>   "Negative indices are not allowed in indexing matrices."
>
> Parse error: I believe that this is intended to mean
>
> "Indexing matrices may not contain negative indices"
>
> not
>
> "You cannot use negative indices when indexing matrices".
>
> This is consistent with the help page:
>
> "
>  A third form of indexing is via a numeric matrix with the one
>  column for each dimension: each row of the index matrix then
>  selects a single element of the array, and the result is a vector.
>  Negative indices are not allowed in the index matrix.
> "
>
> Rephrasing would seem to be in order

Ah... definitely a "parse error" (I read it as a new paragraph).  I
second rephrasing this; your ""Indexing matrices may not contain
negative indices" is non-ambiguous.

Thanks Peter

/Henrik

>
> -pd
>
>>
>> but this is not true, e.g.
>>
>>> x <- matrix(1:12, nrow=4)
>>> x
>> [,1] [,2] [,3]
>> [1,]159
>> [2,]26   10
>> [3,]37   11
>> [4,]48   12
>>
>>> x[c(-2,-4),]
>> [,1] [,2] [,3]
>> [1,]159
>> [2,]37   11
>>
>> /Henrik
>>
>> (*) https://stat.ethz.ch/pipermail/r-devel/2015-May/071091.html [docs
>> have been fixed]
>>
>> __
>> R-devel@r-project.org mailing list
>> https://stat.ethz.ch/mailman/listinfo/r-devel
>
> --
> Peter Dalgaard, Professor,
> Center for Statistics, Copenhagen Business School
> Solbjerg Plads 3, 2000 Frederiksberg, Denmark
> Phone: (+45)38153501
> Email: pd@cbs.dk  Priv: pda...@gmail.com
>
>
>
>
>
>
>
>

__
R-devel@r-project.org mailing list
https://stat.ethz.ch/mailman/listinfo/r-devel


Re: [Rd] R Language Definition: Subsetting matrices with negative indices is *not* an error

2015-05-09 Thread peter dalgaard

> On 09 May 2015, at 02:53 , Henrik Bengtsson  wrote:
> 
> Hi,
> 
> I spotted what looks like another(*) mistake in 'R Language
> Definition' on how subsetting should work.  In Section 'Indexing
> matrices and arrays'
> [http://cran.r-project.org/doc/manuals/r-release/R-lang.html#Indexing-matrices-and-arrays]
> one can read
> 
>   "Negative indices are not allowed in indexing matrices."

Parse error: I believe that this is intended to mean

"Indexing matrices may not contain negative indices"

not

"You cannot use negative indices when indexing matrices".

This is consistent with the help page:

"
 A third form of indexing is via a numeric matrix with the one
 column for each dimension: each row of the index matrix then
 selects a single element of the array, and the result is a vector.
 Negative indices are not allowed in the index matrix. 
"

Rephrasing would seem to be in order

-pd

> 
> but this is not true, e.g.
> 
>> x <- matrix(1:12, nrow=4)
>> x
> [,1] [,2] [,3]
> [1,]159
> [2,]26   10
> [3,]37   11
> [4,]48   12
> 
>> x[c(-2,-4),]
> [,1] [,2] [,3]
> [1,]159
> [2,]37   11
> 
> /Henrik
> 
> (*) https://stat.ethz.ch/pipermail/r-devel/2015-May/071091.html [docs
> have been fixed]
> 
> __
> R-devel@r-project.org mailing list
> https://stat.ethz.ch/mailman/listinfo/r-devel

-- 
Peter Dalgaard, Professor,
Center for Statistics, Copenhagen Business School
Solbjerg Plads 3, 2000 Frederiksberg, Denmark
Phone: (+45)38153501
Email: pd@cbs.dk  Priv: pda...@gmail.com

__
R-devel@r-project.org mailing list
https://stat.ethz.ch/mailman/listinfo/r-devel