Re: Review Request 108516: Do not hardcode site-packages for the python libdir.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108516/#review26006 --- Personally and from a I know nothing about python perspective, I'd prefer this to not go to 4.10.0, seems like something a bit fragile that might break and we can't really afford that in 4.10.0 at the moment. I wouldn't mind seening it in master if you think that fixing the problems that might arise in the future should not be hard. So could this as a half-shipit. I'd like Kevin, Luca, Christophe to comment here too, but we can't all get what we want :D - Albert Astals Cid On Jan. 21, 2013, 11 a.m., Michael Jansen wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108516/ --- (Updated Jan. 21, 2013, 11 a.m.) Review request for Build System, Release Team and Kevin Kofler. Description --- Do not hardcode site-packages for the python libdir. Diffs - cmake/modules/FindPythonLibrary.cmake 7cef79b16521c759f38f1deea539a28a50c5d708 Diff: http://git.reviewboard.kde.org/r/108516/diff/ Testing --- Not much. Works the same as before. Need someone to check on debian. Need someone to check when installing into /usr. I think the strequal to check if PYTHON_SITE_PACKAGES_INSTALL_DIR is different from PYTHON_SITE_PACKAGES_DIR is not optimal but good enough. The only problem could be a trailing slash or different case on windows. Any hints to improve it? Thanks, Michael Jansen ___ release-team mailing list release-team@kde.org https://mail.kde.org/mailman/listinfo/release-team
Re: Review Request 108516: Do not hardcode site-packages for the python libdir.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108516/#review26007 --- Personally and from a I know nothing about python perspective, I'd prefer this to not go to 4.10.0, seems like something a bit fragile that might break and we can't really afford that in 4.10.0 at the moment. I wouldn't mind seening it in master if you think that fixing the problems that might arise in the future should not be hard. So could this as a half-shipit. I'd like Kevin, Luca, Christophe to comment here too, but we can't all get what we want :D - Albert Astals Cid On Jan. 21, 2013, 11 a.m., Michael Jansen wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108516/ --- (Updated Jan. 21, 2013, 11 a.m.) Review request for Build System, Release Team and Kevin Kofler. Description --- Do not hardcode site-packages for the python libdir. Diffs - cmake/modules/FindPythonLibrary.cmake 7cef79b16521c759f38f1deea539a28a50c5d708 Diff: http://git.reviewboard.kde.org/r/108516/diff/ Testing --- Not much. Works the same as before. Need someone to check on debian. Need someone to check when installing into /usr. I think the strequal to check if PYTHON_SITE_PACKAGES_INSTALL_DIR is different from PYTHON_SITE_PACKAGES_DIR is not optimal but good enough. The only problem could be a trailing slash or different case on windows. Any hints to improve it? Thanks, Michael Jansen ___ release-team mailing list release-team@kde.org https://mail.kde.org/mailman/listinfo/release-team
Re: Review Request 108516: Do not hardcode site-packages for the python libdir.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108516/#review26008 --- Personally and from a I know nothing about python perspective, I'd prefer this to not go to 4.10.0, seems like something a bit fragile that might break and we can't really afford that in 4.10.0 at the moment. I wouldn't mind seening it in master if you think that fixing the problems that might arise in the future should not be hard. So could this as a half-shipit. I'd like Kevin, Luca, Christophe to comment here too, but we can't all get what we want :D - Albert Astals Cid On Jan. 21, 2013, 11 a.m., Michael Jansen wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108516/ --- (Updated Jan. 21, 2013, 11 a.m.) Review request for Build System, Release Team and Kevin Kofler. Description --- Do not hardcode site-packages for the python libdir. Diffs - cmake/modules/FindPythonLibrary.cmake 7cef79b16521c759f38f1deea539a28a50c5d708 Diff: http://git.reviewboard.kde.org/r/108516/diff/ Testing --- Not much. Works the same as before. Need someone to check on debian. Need someone to check when installing into /usr. I think the strequal to check if PYTHON_SITE_PACKAGES_INSTALL_DIR is different from PYTHON_SITE_PACKAGES_DIR is not optimal but good enough. The only problem could be a trailing slash or different case on windows. Any hints to improve it? Thanks, Michael Jansen ___ release-team mailing list release-team@kde.org https://mail.kde.org/mailman/listinfo/release-team
Re: Review Request 108516: Do not hardcode site-packages for the python libdir.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108516/#review26009 --- Personally and from a I know nothing about python perspective, I'd prefer this to not go to 4.10.0, seems like something a bit fragile that might break and we can't really afford that in 4.10.0 at the moment. I wouldn't mind seening it in master if you think that fixing the problems that might arise in the future should not be hard. So could this as a half-shipit. I'd like Kevin, Luca, Christophe to comment here too, but we can't all get what we want :D - Albert Astals Cid On Jan. 21, 2013, 11 a.m., Michael Jansen wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108516/ --- (Updated Jan. 21, 2013, 11 a.m.) Review request for Build System, Release Team and Kevin Kofler. Description --- Do not hardcode site-packages for the python libdir. Diffs - cmake/modules/FindPythonLibrary.cmake 7cef79b16521c759f38f1deea539a28a50c5d708 Diff: http://git.reviewboard.kde.org/r/108516/diff/ Testing --- Not much. Works the same as before. Need someone to check on debian. Need someone to check when installing into /usr. I think the strequal to check if PYTHON_SITE_PACKAGES_INSTALL_DIR is different from PYTHON_SITE_PACKAGES_DIR is not optimal but good enough. The only problem could be a trailing slash or different case on windows. Any hints to improve it? Thanks, Michael Jansen ___ release-team mailing list release-team@kde.org https://mail.kde.org/mailman/listinfo/release-team
Re: Review Request 108516: Do not hardcode site-packages for the python libdir.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108516/ --- (Updated Jan. 22, 2013, 7:28 p.m.) Review request for Build System, Release Team, Christophe Giboudeaux, Kevin Kofler, and Luca Beltrame. Description --- Do not hardcode site-packages for the python libdir. Diffs - cmake/modules/FindPythonLibrary.cmake 7cef79b16521c759f38f1deea539a28a50c5d708 Diff: http://git.reviewboard.kde.org/r/108516/diff/ Testing --- Not much. Works the same as before. Need someone to check on debian. Need someone to check when installing into /usr. I think the strequal to check if PYTHON_SITE_PACKAGES_INSTALL_DIR is different from PYTHON_SITE_PACKAGES_DIR is not optimal but good enough. The only problem could be a trailing slash or different case on windows. Any hints to improve it? Thanks, Michael Jansen ___ release-team mailing list release-team@kde.org https://mail.kde.org/mailman/listinfo/release-team
Re: Review Request 108516: Do not hardcode site-packages for the python libdir.
On Jan. 22, 2013, 7:27 p.m., Albert Astals Cid wrote: Personally and from a I know nothing about python perspective, I'd prefer this to not go to 4.10.0, seems like something a bit fragile that might break and we can't really afford that in 4.10.0 at the moment. I wouldn't mind seening it in master if you think that fixing the problems that might arise in the future should not be hard. So could this as a half-shipit. I'd like Kevin, Luca, Christophe to comment here too, but we can't all get what we want :D The patch looks right to me (as a non-Python-expert). - Kevin --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108516/#review26009 --- On Jan. 22, 2013, 7:28 p.m., Michael Jansen wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108516/ --- (Updated Jan. 22, 2013, 7:28 p.m.) Review request for Build System, Release Team, Christophe Giboudeaux, Kevin Kofler, and Luca Beltrame. Description --- Do not hardcode site-packages for the python libdir. Diffs - cmake/modules/FindPythonLibrary.cmake 7cef79b16521c759f38f1deea539a28a50c5d708 Diff: http://git.reviewboard.kde.org/r/108516/diff/ Testing --- Not much. Works the same as before. Need someone to check on debian. Need someone to check when installing into /usr. I think the strequal to check if PYTHON_SITE_PACKAGES_INSTALL_DIR is different from PYTHON_SITE_PACKAGES_DIR is not optimal but good enough. The only problem could be a trailing slash or different case on windows. Any hints to improve it? Thanks, Michael Jansen ___ release-team mailing list release-team@kde.org https://mail.kde.org/mailman/listinfo/release-team
Re: Review Request 108516: Do not hardcode site-packages for the python libdir.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108516/#review26018 --- From my perspective it looks OK, but I'm not putting any ship it because I already broke build systems too many times out of my CMake ignorance. If also Crirstophe gives his assent, I think this can go in. - Luca Beltrame On Jan. 22, 2013, 7:28 p.m., Michael Jansen wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108516/ --- (Updated Jan. 22, 2013, 7:28 p.m.) Review request for Build System, Release Team, Christophe Giboudeaux, Kevin Kofler, and Luca Beltrame. Description --- Do not hardcode site-packages for the python libdir. Diffs - cmake/modules/FindPythonLibrary.cmake 7cef79b16521c759f38f1deea539a28a50c5d708 Diff: http://git.reviewboard.kde.org/r/108516/diff/ Testing --- Not much. Works the same as before. Need someone to check on debian. Need someone to check when installing into /usr. I think the strequal to check if PYTHON_SITE_PACKAGES_INSTALL_DIR is different from PYTHON_SITE_PACKAGES_DIR is not optimal but good enough. The only problem could be a trailing slash or different case on windows. Any hints to improve it? Thanks, Michael Jansen ___ release-team mailing list release-team@kde.org https://mail.kde.org/mailman/listinfo/release-team
Re: Review Request 108516: Do not hardcode site-packages for the python libdir.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108516/#review26016 --- From my perspective it looks OK, but I'm not putting any ship it because I already broke build systems too many times out of my CMake ignorance. If also Crirstophe gives his assent, I think this can go in. - Luca Beltrame On Jan. 22, 2013, 7:28 p.m., Michael Jansen wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108516/ --- (Updated Jan. 22, 2013, 7:28 p.m.) Review request for Build System, Release Team, Christophe Giboudeaux, Kevin Kofler, and Luca Beltrame. Description --- Do not hardcode site-packages for the python libdir. Diffs - cmake/modules/FindPythonLibrary.cmake 7cef79b16521c759f38f1deea539a28a50c5d708 Diff: http://git.reviewboard.kde.org/r/108516/diff/ Testing --- Not much. Works the same as before. Need someone to check on debian. Need someone to check when installing into /usr. I think the strequal to check if PYTHON_SITE_PACKAGES_INSTALL_DIR is different from PYTHON_SITE_PACKAGES_DIR is not optimal but good enough. The only problem could be a trailing slash or different case on windows. Any hints to improve it? Thanks, Michael Jansen ___ release-team mailing list release-team@kde.org https://mail.kde.org/mailman/listinfo/release-team
Re: Review Request 108516: Do not hardcode site-packages for the python libdir.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108516/#review26019 --- From my perspective it looks OK, but I'm not putting any ship it because I already broke build systems too many times out of my CMake ignorance. If also Crirstophe gives his assent, I think this can go in. - Luca Beltrame On Jan. 22, 2013, 7:28 p.m., Michael Jansen wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108516/ --- (Updated Jan. 22, 2013, 7:28 p.m.) Review request for Build System, Release Team, Christophe Giboudeaux, Kevin Kofler, and Luca Beltrame. Description --- Do not hardcode site-packages for the python libdir. Diffs - cmake/modules/FindPythonLibrary.cmake 7cef79b16521c759f38f1deea539a28a50c5d708 Diff: http://git.reviewboard.kde.org/r/108516/diff/ Testing --- Not much. Works the same as before. Need someone to check on debian. Need someone to check when installing into /usr. I think the strequal to check if PYTHON_SITE_PACKAGES_INSTALL_DIR is different from PYTHON_SITE_PACKAGES_DIR is not optimal but good enough. The only problem could be a trailing slash or different case on windows. Any hints to improve it? Thanks, Michael Jansen ___ release-team mailing list release-team@kde.org https://mail.kde.org/mailman/listinfo/release-team
Re: Review Request 108516: Do not hardcode site-packages for the python libdir.
Hi Need someone to check when installing into /usr. I've tested the python patch on kde 4.9.98 and installed it into /usr/lib64/ and haven't had anything go wrong... yet ;) --- On Tue, 1/22/13, Albert Astals Cid aa...@kde.org wrote: From: Albert Astals Cid aa...@kde.org Subject: Re: Review Request 108516: Do not hardcode site-packages for the python libdir. To: Kevin Kofler kevin.kof...@chello.at Cc: Albert Astals Cid aa...@kde.org, Release Team release-team@kde.org, Build System kde-buildsys...@kde.org Date: Tuesday, January 22, 2013, 12:27 PM This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108516/ Personally and from a I know nothing about python perspective, I'd prefer this to not go to 4.10.0, seems like something a bit fragile that might break and we can't really afford that in 4.10.0 at the moment. I wouldn't mind seening it in master if you think that fixing the problems that might arise in the future should not be hard. So could this as a half-shipit. I'd like Kevin, Luca, Christophe to comment here too, but we can't all get what we want :D - Albert On January 21st, 2013, 11 a.m. UTC, Michael Jansen wrote: Review request for Build System, Release Team and Kevin Kofler. By Michael Jansen. Updated Jan. 21, 2013, 11 a.m. Description Do not hardcode site-packages for the python libdir. Testing Not much. Works the same as before. Need someone to check on debian. Need someone to check when installing into /usr. I think the strequal to check if PYTHON_SITE_PACKAGES_INSTALL_DIR is different from PYTHON_SITE_PACKAGES_DIR is not optimal but good enough. The only problem could be a trailing slash or different case on windows. Any hints to improve it? Diffs cmake/modules/FindPythonLibrary.cmake (7cef79b16521c759f38f1deea539a28a50c5d708) View Diff -Inline Attachment Follows- ___ release-team mailing list release-team@kde.org https://mail.kde.org/mailman/listinfo/release-team ___ release-team mailing list release-team@kde.org https://mail.kde.org/mailman/listinfo/release-team
Re: Review Request 108516: Do not hardcode site-packages for the python libdir.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108516/#review26029 --- Ship it! Looks good, Thanks ! - Christophe Giboudeaux On Jan. 22, 2013, 7:28 p.m., Michael Jansen wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108516/ --- (Updated Jan. 22, 2013, 7:28 p.m.) Review request for Build System, Release Team, Christophe Giboudeaux, Kevin Kofler, and Luca Beltrame. Description --- Do not hardcode site-packages for the python libdir. Diffs - cmake/modules/FindPythonLibrary.cmake 7cef79b16521c759f38f1deea539a28a50c5d708 Diff: http://git.reviewboard.kde.org/r/108516/diff/ Testing --- Not much. Works the same as before. Need someone to check on debian. Need someone to check when installing into /usr. I think the strequal to check if PYTHON_SITE_PACKAGES_INSTALL_DIR is different from PYTHON_SITE_PACKAGES_DIR is not optimal but good enough. The only problem could be a trailing slash or different case on windows. Any hints to improve it? Thanks, Michael Jansen ___ release-team mailing list release-team@kde.org https://mail.kde.org/mailman/listinfo/release-team
Re: Review Request 108516: Do not hardcode site-packages for the python libdir.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108516/#review26030 --- Ship it! Looks good, Thanks ! - Christophe Giboudeaux On Jan. 22, 2013, 7:28 p.m., Michael Jansen wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108516/ --- (Updated Jan. 22, 2013, 7:28 p.m.) Review request for Build System, Release Team, Christophe Giboudeaux, Kevin Kofler, and Luca Beltrame. Description --- Do not hardcode site-packages for the python libdir. Diffs - cmake/modules/FindPythonLibrary.cmake 7cef79b16521c759f38f1deea539a28a50c5d708 Diff: http://git.reviewboard.kde.org/r/108516/diff/ Testing --- Not much. Works the same as before. Need someone to check on debian. Need someone to check when installing into /usr. I think the strequal to check if PYTHON_SITE_PACKAGES_INSTALL_DIR is different from PYTHON_SITE_PACKAGES_DIR is not optimal but good enough. The only problem could be a trailing slash or different case on windows. Any hints to improve it? Thanks, Michael Jansen ___ release-team mailing list release-team@kde.org https://mail.kde.org/mailman/listinfo/release-team
Review Request 108516: Do not hardcode site-packages for the python libdir.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108516/ --- Review request for Build System, Release Team and Kevin Kofler. Description --- Do not hardcode site-packages for the python libdir. Diffs - cmake/modules/FindPythonLibrary.cmake 7cef79b16521c759f38f1deea539a28a50c5d708 Diff: http://git.reviewboard.kde.org/r/108516/diff/ Testing --- Not much. Works the same as before. Need someone to check on debian. Need someone to check when installing into /usr. I think the strequal to check if PYTHON_SITE_PACKAGES_INSTALL_DIR is different from PYTHON_SITE_PACKAGES_DIR is not optimal but good enough. The only problem could be a trailing slash or different case on windows. Any hints to improve it? Thanks, Michael Jansen ___ release-team mailing list release-team@kde.org https://mail.kde.org/mailman/listinfo/release-team
Re: Review Request 108516: Do not hardcode site-packages for the python libdir.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108516/#review25911 --- $ python -c from distutils.sysconfig import get_python_lib; print(get_python_lib(True, prefix='/usr/')) /usr/lib/python2.7/dist-packages is on a debian system. I think that might be right. - Sune Vuorela On Jan. 21, 2013, 11 a.m., Michael Jansen wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108516/ --- (Updated Jan. 21, 2013, 11 a.m.) Review request for Build System, Release Team and Kevin Kofler. Description --- Do not hardcode site-packages for the python libdir. Diffs - cmake/modules/FindPythonLibrary.cmake 7cef79b16521c759f38f1deea539a28a50c5d708 Diff: http://git.reviewboard.kde.org/r/108516/diff/ Testing --- Not much. Works the same as before. Need someone to check on debian. Need someone to check when installing into /usr. I think the strequal to check if PYTHON_SITE_PACKAGES_INSTALL_DIR is different from PYTHON_SITE_PACKAGES_DIR is not optimal but good enough. The only problem could be a trailing slash or different case on windows. Any hints to improve it? Thanks, Michael Jansen ___ release-team mailing list release-team@kde.org https://mail.kde.org/mailman/listinfo/release-team
