Issue 933 in reviewboard: Clicking expand triggers review comment
Comment #3 on issue 933 by chipx86: Clicking expand triggers review comment http://code.google.com/p/reviewboard/issues/detail?id=933 Issue 961 has been merged into this issue. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 965 in reviewboard: Edit buttons on Review Request screen are not accessible
Comment #2 on issue 965 by brad.taylor: Edit buttons on Review Request screen are not accessible http://code.google.com/p/reviewboard/issues/detail?id=965 Additionally, the edit buttons are not focusable, so I'll have to figure a way to make that happen also. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 965 in reviewboard: Edit buttons on Review Request screen are not accessible
Updates: Status: Confirmed Labels: Milestone-Release1.0 Component-Reviews Comment #3 on issue 965 by chipx86: Edit buttons on Review Request screen are not accessible http://code.google.com/p/reviewboard/issues/detail?id=965 Can you submit this to our Review Board server? -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 965 in reviewboard: Edit buttons on Review Request screen are not accessible
Comment #4 on issue 965 by brad.taylor: Edit buttons on Review Request screen are not accessible http://code.google.com/p/reviewboard/issues/detail?id=965 Updated patch to make the button focusable (by using an a tag) and thus clickable via Firefox (when a user hits Enter, Firefox will generate the onClick event for focused items). Unfortunately, the aria-label will only show up with FF 3.1 and the latest Orca. Attachments: edit-button-a11y-v2.patch - patch to Djiblets to change the image properties edit-button-a11y-v2-part2.patch - some style fixes I tried to post this to demo.review-board.org, but it seems that the patch to Djiblets (which is a svn:external) is freaking it out. Any tips? Attachments: edit-button-a11y-v2.patch 774 bytes edit-button-a11y-v2-part2.patch 401 bytes -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 914 in reviewboard: API Broken Alpha2: api/json/reviewrequests/rid/reviews/
Comment #1 on issue 914 by ciaomary: API Broken Alpha2: api/json/reviewrequests/rid/reviews/ http://code.google.com/p/reviewboard/issues/detail?id=914 The fix for my issue was found. I needed to pass in id=$rid with the request. This is not documented in the API doc however. I request that this argument requirement be added to the doc. Unrelated, but also not documented, the API for updating the status for a review. This is supported (at least for 'reopen' and 'submitted' but it is not documented.) -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 967 in reviewboard: repository hostname lookups are not really canonical
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 967 by psc...@vmware.com: repository hostname lookups are not really canonical http://code.google.com/p/reviewboard/issues/detail?id=967 Currently, post-review relies on calls to various socket module functions in order to figure out the canonical FQDN of a Perforce or CVS repository. This is not a great solution as these can actually be different on different networks. For Perforce, at least, the host directly out of p4 info is a much much better thing to use as a canonical name for the server, because it will always be the same everywhere. (My team thinks that for older Perforce servers this is the p4port argument when you start the server and for newer servers this is whatever the FQDN is for the p4port argument when you start the server.) Looking back at the revision history for post-review in SVN, I think the change was made to use the socket functions for Perforce since p4 info might give you something other than the FQDN (like perforce instead of perforce.example.com), which won't match up with what is likely recorded as the repository path on the Review Board server. That actually points to a larger problem, which is that the Review Board server's network, the post-reviewer's network, and the repository itself may all have a different canonical name for the repository. It may be worth separating the canonical name used to figure out which repository a review is for from the path the Review Board server uses to connect back to that repository later. I would think it best to use something self-reported from the repository itself (like the results from p4 info) for the canonical name if at all possible. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
