---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47677/
---
(Updated May 25, 2016, 9:32 p.m.)
Review request for Ambari, Jaimin Jetly, Srimanth Gunturi, and Yusaku Sako.
Changes
---
Change place holder from numeric to variable name based.
Bugs: AMBARI-16804
https://issues.apache.org/jira/browse/AMBARI-16804
Repository: ambari
Description
---
Refactor Move Master wizard. Extract configurable texts and stack related
definitions into a separate JS file.
Diffs (updated)
-
ambari-web/app/controllers/main/service/reassign/step1_controller.js 9f30bb7
ambari-web/app/controllers/main/service/reassign/step4_controller.js d8f0394
ambari-web/app/controllers/main/service/reassign_controller.js 07d6e2c
ambari-web/app/data/wizards/move_master.js PRE-CREATION
ambari-web/app/routes/reassign_master_routes.js f079432
ambari-web/app/templates/main/service/reassign.hbs 2477229
ambari-web/app/templates/main/service/reassign/step1.hbs 9862cbe
ambari-web/app/templates/main/service/reassign/step3.hbs 1ffe989
ambari-web/app/utils/helper.js 7ab131c
ambari-web/app/views/main/service/reassign/step1_view.js ddabf14
ambari-web/app/views/main/service/reassign/step2_view.js 0eae84b
ambari-web/app/views/main/service/reassign/step4_view.js 4e1282a
ambari-web/app/views/main/service/reassign/step5_view.js 066b23b
ambari-web/app/views/main/service/reassign/step6_view.js 33f8851
ambari-web/app/views/main/service/reassign/step7_view.js 60b357a
ambari-web/test/controllers/main/service/reassign/step1_controller_test.js
a43d91f
ambari-web/test/controllers/main/service/reassign/step4_controller_test.js
d6ef9dc
Diff: https://reviews.apache.org/r/47677/diff/
Testing
---
Manually tested on live cluster.
All unit tests passed.
27828 tests complete (28 seconds)
154 tests pending
Thanks,
Richard Zang