Re: Review Request 64827: Debug about restart agent command sent by server

2017-12-26 Thread Andrew Onischuk

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64827/#review194509
---


Ship it!




Ship It!

- Andrew Onischuk


On Dec. 23, 2017, 12:43 p.m., Xianghao Lu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64827/
> ---
> 
> (Updated Dec. 23, 2017, 12:43 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Eugene Chekanskiy, and Jonathan 
> Hurley.
> 
> 
> Bugs: AMBARI-22689
> https://issues.apache.org/jira/browse/AMBARI-22689
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When ambari agent gets a heartbeat response from ambari server, agent will 
> convert the string data to JSON object, and response['restartAgent'] will be 
> a bool value not string.
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/Controller.py e4f148f 
>   ambari-agent/src/test/python/ambari_agent/TestController.py 20da81f 
>   ambari-agent/src/test/python/ambari_agent/examples/ControllerTester.py 
> bc46ac6 
> 
> 
> Diff: https://reviews.apache.org/r/64827/diff/1/
> 
> 
> Testing
> ---
> 
> unit tests
> manual test when ambari-server sends restart agent command, and it works well.
> 
> 
> Thanks,
> 
> Xianghao Lu
> 
>



Review Request 64827: Debug about restart agent command sent by server

2017-12-23 Thread Xianghao Lu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64827/
---

Review request for Ambari, Andrew Onischuk, Eugene Chekanskiy, and Jonathan 
Hurley.


Bugs: AMBARI-22689
https://issues.apache.org/jira/browse/AMBARI-22689


Repository: ambari


Description
---

When ambari agent gets a heartbeat response from ambari server, agent will 
convert the string data to JSON object, and response['restartAgent'] will be a 
bool value not string.


Diffs
-

  ambari-agent/src/main/python/ambari_agent/Controller.py e4f148f 
  ambari-agent/src/test/python/ambari_agent/TestController.py 20da81f 
  ambari-agent/src/test/python/ambari_agent/examples/ControllerTester.py 
bc46ac6 


Diff: https://reviews.apache.org/r/64827/diff/1/


Testing
---

unit tests
manual test when ambari-server sends restart agent command, and it works well.


Thanks,

Xianghao Lu