Re: Review Request 56076: AMBARI-19775. ActionQueue thread may exit due to IOError in statusCommandResultQueue.empty()

2017-01-30 Thread Sandor Magyari 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56076/#review163507
---


Ship it!




Ship It!

- Sandor Magyari


On Jan. 30, 2017, 1:04 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56076/
> ---
> 
> (Updated Jan. 30, 2017, 1:04 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Sandor Magyari, and Sebastian 
> Toader.
> 
> 
> Bugs: AMBARI-19775
> https://issues.apache.org/jira/browse/AMBARI-19775
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Handle IOError thrown from empty()
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/ActionQueue.py 
> 18d7c2afd20279fe6586b3235dcd668aabeeb7fb 
> 
> Diff: https://reviews.apache.org/r/56076/diff/
> 
> 
> Testing
> ---
> 
> Manual testing: simulated IOError, verified heartbeat continues to include 
> status command results.
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 56013: Ambari Server Unit Test failure on branch-2.5/trunk for testUpdateConfigForceSecurityEnabled

2017-01-30 Thread Dmitro Lisnichenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56013/#review163508
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On Jan. 30, 2017, 3:10 p.m., Eugene Chekanskiy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56013/
> ---
> 
> (Updated Jan. 30, 2017, 3:10 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Robert Levas.
> 
> 
> Bugs: AMBARI-19741
> https://issues.apache.org/jira/browse/AMBARI-19741
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> fixing filed tests
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/UpdateKerberosConfigsServerActionTest.java
>  e756491 
> 
> Diff: https://reviews.apache.org/r/56013/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Eugene Chekanskiy
> 
>

Review Request 56078: Hive View 2.0: Table manager - DDL tab should show query as readonly in query editor

2017-01-30 Thread Pallav Kulshreshtha 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56078/
---

Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and 
Rohit Choudhary.


Bugs: AMBARI-19523
https://issues.apache.org/jira/browse/AMBARI-19523


Repository: ambari


Description
---

Changed ivy-codemirror to custom component query-editor.


Diffs
-

  
contrib/views/hive20/src/main/resources/ui/app/templates/databases/database/tables/table/ddl.hbs
 cbbcdd0 

Diff: https://reviews.apache.org/r/56078/diff/


Testing
---

manually tested.


Thanks,

Pallav Kulshreshtha

Re: Review Request 56013: Ambari Server Unit Test failure on branch-2.5/trunk for testUpdateConfigForceSecurityEnabled

2017-01-30 Thread Robert Levas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56013/#review163520
---


Ship it!




Ship It!

- Robert Levas


On Jan. 30, 2017, 8:10 a.m., Eugene Chekanskiy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56013/
> ---
> 
> (Updated Jan. 30, 2017, 8:10 a.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Robert Levas.
> 
> 
> Bugs: AMBARI-19741
> https://issues.apache.org/jira/browse/AMBARI-19741
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> fixing filed tests
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/UpdateKerberosConfigsServerActionTest.java
>  e756491 
> 
> Diff: https://reviews.apache.org/r/56013/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Eugene Chekanskiy
> 
>

Review Request 56077: Update slider tarball before uploading to DFS

2017-01-30 Thread Andrew Onischuk 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56077/
---

Review request for Ambari and Dmitro Lisnichenko.


Bugs: AMBARI-19776
https://issues.apache.org/jira/browse/AMBARI-19776


Repository: ambari


Description
---


Diffs
-

  ambari-server/src/main/resources/scripts/Ambaripreupload.py 0e25a2a 

Diff: https://reviews.apache.org/r/56077/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 56076: AMBARI-19775. ActionQueue thread may exit due to IOError in statusCommandResultQueue.empty()

2017-01-30 Thread Sebastian Toader 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56076/#review163511
---


Ship it!




Ship It!

- Sebastian Toader


On Jan. 30, 2017, 2:04 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56076/
> ---
> 
> (Updated Jan. 30, 2017, 2:04 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Sandor Magyari, and Sebastian 
> Toader.
> 
> 
> Bugs: AMBARI-19775
> https://issues.apache.org/jira/browse/AMBARI-19775
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Handle IOError thrown from empty()
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/ActionQueue.py 
> 18d7c2afd20279fe6586b3235dcd668aabeeb7fb 
> 
> Diff: https://reviews.apache.org/r/56076/diff/
> 
> 
> Testing
> ---
> 
> Manual testing: simulated IOError, verified heartbeat continues to include 
> status command results.
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 56077: Update slider tarball before uploading to DFS

2017-01-30 Thread Dmitro Lisnichenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56077/#review163513
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On Jan. 30, 2017, 3:24 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56077/
> ---
> 
> (Updated Jan. 30, 2017, 3:24 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-19776
> https://issues.apache.org/jira/browse/AMBARI-19776
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/scripts/Ambaripreupload.py 0e25a2a 
> 
> Diff: https://reviews.apache.org/r/56077/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Review Request 56081: Normalize upgrade status label in Upgrade History

2017-01-30 Thread Andrii Tkach 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56081/
---

Review request for Ambari and Aleksandr Kovalenko.


Bugs: AMBARI-19779
https://issues.apache.org/jira/browse/AMBARI-19779


Repository: ambari


Description
---

Normalize upgrade status label in Upgrade History


Diffs
-

  ambari-web/app/models/host_stack_version.js b0c000e 
  ambari-web/app/models/stack_version/stack_upgrade_history.js 9e0439c 
  ambari-web/app/templates/main/admin/stack_upgrade/upgrade_history.hbs e023fbb 
  ambari-web/app/utils/string_utils.js f4e3674 
  ambari-web/test/utils/string_utils_test.js 3c7b077 

Diff: https://reviews.apache.org/r/56081/diff/


Testing
---

20330 passing (34s)
153 pending


Thanks,

Andrii Tkach

Re: Review Request 56059: Preview: Package Installation fails due to error in Berkeley DB library

2017-01-30 Thread Nate Cole 


> On Jan. 29, 2017, 5:09 p.m., Nate Cole wrote:
> > ambari-common/src/main/python/ambari_commons/shell.py, lines 141-142
> > 
> >
> > Seems awfully specific.  Would be more flexible if we could pass in the 
> > kill delay as an argument whose default is 5 (the graceful_kill_delay).
> 
> Dmitro Lisnichenko wrote:
> Do you mean having a single graceful_kill_delay parameter (the time 
> between SIGTERM and SIGKILL)? Or you mean exposing 
> yum_rpm_gracefull_kill_delay parameter for timeout between sending SIGTERM to 
> sensitive process like yum, and sending SIGKILL?

What I mean is that yumrpm.py is the one building the command to run.  I would 
prefer supplying the timeout there instead of using the yum_rpm_present as it's 
just something else we have to remember that we did 6 months from now.

We already know when we're calling yum.  We have a ton of arguments to control 
the timeout behavior, can we just be using them?  Can we use try_sleep, 
timeout, on_timeout, timeout_kill_strategy etc to our advantage (see 
shell.py/checked_call for complete list).


- Nate


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56059/#review163443
---


On Jan. 29, 2017, 7:27 a.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56059/
> ---
> 
> (Updated Jan. 29, 2017, 7:27 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmytro Grinenko, Jonathan 
> Hurley, and Nate Cole.
> 
> 
> Bugs: AMBARI-19768
> https://issues.apache.org/jira/browse/AMBARI-19768
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> *Steps*
> # Deploy HDP-2.5.0.0 with Ambari 2.4.1.0
> # Upgrade ambari to 2.5.0.0-481 (I did not register Falcon library, as the 
> jar was already present in /var/lib/ambari-server/resources/je-5.0.73.jar on 
> Ambari server node)
> # Register HDP-2.6.0.0-216
> # Start package installation
> 
> *Result:*
> Got below errors:
> {code}
> 2016-12-16 13:47:10,419|INFO|MainThread|machine.py:145 - 
> run()|CRITICAL:yum.main:
> 2016-12-16 13:47:10,419|INFO|MainThread|machine.py:145 - run()|
> 2016-12-16 13:47:10,419|INFO|MainThread|machine.py:145 - run()|Error: rpmdb 
> open failed
> 2016-12-16 13:47:10,420|INFO|MainThread|machine.py:145 - run()|Traceback 
> (most recent call last):
> 2016-12-16 13:47:10,420|INFO|MainThread|machine.py:145 - run()|File 
> "/var/lib/ambari-agent/cache/custom_actions/scripts/install_packages.py", 
> line 166, in actionexecute
> 2016-12-16 13:47:10,420|INFO|MainThread|machine.py:145 - run()|ret_code = 
> self.install_packages(package_list)
> 2016-12-16 13:47:10,420|INFO|MainThread|machine.py:145 - run()|File 
> "/var/lib/ambari-agent/cache/custom_actions/scripts/install_packages.py", 
> line 400, in install_packages
> 2016-12-16 13:47:10,420|INFO|MainThread|machine.py:145 - run()|if not 
> verifyDependencies():
> 2016-12-16 13:47:10,421|INFO|MainThread|machine.py:145 - run()|File 
> "/usr/lib/python2.6/site-packages/resource_management/libraries/functions/packages_analyzer.py",
>  line 311, in verifyDependencies
> 2016-12-16 13:47:10,421|INFO|MainThread|machine.py:145 - run()|code, out = 
> rmf_shell.checked_call(cmd, sudo=True)
> 2016-12-16 13:47:10,421|INFO|MainThread|machine.py:145 - run()|File 
> "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 
> 72, in inner
> 2016-12-16 13:47:10,421|INFO|MainThread|machine.py:145 - run()|result = 
> function(command, **kwargs)
> 2016-12-16 13:47:10,421|INFO|MainThread|machine.py:145 - run()|File 
> "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 
> 102, in checked_call
> 2016-12-16 13:47:10,422|INFO|MainThread|machine.py:145 - run()|tries=tries, 
> try_sleep=try_sleep, timeout_kill_strategy=timeout_kill_strategy)
> 2016-12-16 13:47:10,422|INFO|MainThread|machine.py:145 - run()|File 
> "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 
> 150, in _call_wrapper
> 2016-12-16 13:47:10,422|INFO|MainThread|machine.py:145 - run()|result = 
> _call(command, **kwargs_copy)
> 2016-12-16 13:47:10,422|INFO|MainThread|machine.py:145 - run()|File 
> "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 
> 303, in _call
> 2016-12-16 13:47:10,423|INFO|MainThread|machine.py:145 - run()|raise 
> ExecutionFailed(err_msg, code, out, err)
> 2016-12-16 13:47:10,423|INFO|MainThread|machine.py:145 - 
> run()|ExecutionFailed: Execution of '/usr/bin/yum -d 0 -e 0 check 
> dependencies' returned 1. error: rpmdb: BDB0113 Thread/process 
> 16016/139791567193920 failed: BDB1507 Thread died in Berkeley DB library
> 2016-12-16

Re: Review Request 56079: lzo broken for hive on tez

2017-01-30 Thread Dmitro Lisnichenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56079/#review163515
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On Jan. 30, 2017, 3:59 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56079/
> ---
> 
> (Updated Jan. 30, 2017, 3:59 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-19777
> https://issues.apache.org/jira/browse/AMBARI-19777
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> count * on lzo compressed hive table throws java.lang.RuntimeException:
> native-lzo library not available.
> 
> In our Sqoop suite(test_copyTableToHiveWithCompression[mysql-
> LZO]) first we import
> table to hive with lzo compression.
> 
> 
> 
> 
> /usr/hdp/current/sqoop-client/bin/sqoop import --connection-manager 
> org.apache.sqoop.manager.MySQLManager --connect 
> jdbc:mysql://ctr-e85-1482808692054-1557-01-02.hwx.site/employees 
> --username sqoop --password sqoop --query "select id,data from 
> mytable_compress where locale='en_US' AND\$CONDITIONS" --hive-import 
> --hive-overwrite --hive-partition-key locale --hive-partition-value "en_US" 
> --hive-table mytable_compress --target-dir /user/hrt_qa/test-sqoop/out -m 1 
> --compress --compression-codec lzo
> 
> 
> which went successfull for different partition values .
> 
> Post the we verify the number of records on the hive table which is failing.
> 
> 
> 
> 
> 2016-12-29 06:54:33,003|INFO|MainThread|machine.py:132 - run()|RUNNING: 
> /usr/hdp/current/hive-client/bin/hive -e "select count(*) from 
> mytable_compress;"
> 2016-12-29 06:54:37,391|INFO|MainThread|machine.py:145 - run()|
> 2016-12-29 06:54:37,391|INFO|MainThread|machine.py:145 - run()|Logging 
> initialized using configuration in 
> file:/etc/hive/2.6.0.0-275/0/hive-log4j.properties
> 2016-12-29 06:54:52,463|INFO|MainThread|machine.py:145 - run()|Query ID = 
> hrt_qa_20161229065450_36da5b59-89f5-4bcb-96a5-4ddab3745ea8
> 2016-12-29 06:54:52,463|INFO|MainThread|machine.py:145 - run()|Total jobs 
> = 1
> 2016-12-29 06:54:52,474|INFO|MainThread|machine.py:145 - run()|Launching 
> Job 1 out of 1
> 2016-12-29 06:54:53,628|INFO|MainThread|machine.py:145 - run()|
> 2016-12-29 06:54:53,629|INFO|MainThread|machine.py:145 - run()|
> 2016-12-29 06:54:53,877|INFO|MainThread|machine.py:145 - run()|Status: 
> Running (Executing on YARN cluster with App id application_1482982635541_0221)
> 2016-12-29 06:54:53,877|INFO|MainThread|machine.py:145 - run()|
> 2016-12-29 06:54:53,877|INFO|MainThread|machine.py:145 - run()|Map 1: -/- 
> Reducer 2: 0/1
> 2016-12-29 06:54:54,081|INFO|MainThread|machine.py:145 - run()|Map 1: 0/1 
> Reducer 2: 0/1
> 2016-12-29 06:54:57,140|INFO|MainThread|machine.py:145 - run()|Map 1: 0/1 
> Reducer 2: 0/1
> 2016-12-29 06:54:59,393|INFO|MainThread|machine.py:145 - run()|Map 1: 
> 0(+1)/1 Reducer 2: 0/1
> 2016-12-29 06:55:01,028|INFO|MainThread|machine.py:145 - run()|Map 1: 
> 0(+1,-1)/1  Reducer 2: 0/1
> 2016-12-29 06:55:04,089|INFO|MainThread|machine.py:145 - run()|Map 1: 
> 0(+1,-1)/1  Reducer 2: 0/1
> 2016-12-29 06:55:05,108|INFO|MainThread|machine.py:145 - run()|Map 1: 
> 0(+1,-2)/1  Reducer 2: 0/1
> 2016-12-29 06:55:08,178|INFO|MainThread|machine.py:145 - run()|Map 1: 
> 0(+1,-2)/1  Reducer 2: 0/1
> 2016-12-29 06:55:11,245|INFO|MainThread|machine.py:145 - run()|Map 1: 
> 0(+1,-2)/1  Reducer 2: 0/1
> 2016-12-29 06:55:12,267|INFO|MainThread|machine.py:145 - run()|Map 1: 
> 0(+1,-3)/1  Reducer 2: 0/1
> 2016-12-29 06:55:15,344|INFO|MainThread|machine.py:145 - run()|Map 1: 
> 0(+1,-3)/1  Reducer 2: 0/1
> 2016-12-29 06:55:15,965|INFO|MainThread|machine.py:145 - run()|Status: 
> Failed
> 2016-12-29 06:55:15,967|INFO|MainThread|machine.py:145 - run()|Vertex 
> failed, vertexName=Map 1, vertexId=vertex_1482982635541_0221_1_00, 
> diagnostics=[Task failed, taskId=task_1482982635541_0221_1_00_00, 
> diagnostics=[TaskAttempt 0 failed, info=[Error: Failure while running 
> task:java.lang.RuntimeException: java.lang.RuntimeException: 
> java.io.IOException: java.lang.RuntimeException: native-lzo library not 
> available
> 2016-12-29 06:55:15,967|INFO|MainThread|machine.py:145 - run()|at 
> org.apache.hadoop.hive.ql.exec.tez.TezProcessor.initializeAndRunProcessor(TezProcessor.java:173)
> 2016-12-29 06:55:15,967|INFO|MainThread|machine.py:145 - run()|at 
> org.apache.hadoop.hive.ql.exec.tez.TezProcessor.run(TezProcessor.java:139)
> 2016-12-29 06:55:15,967|INFO|MainThread|machine.py:145 - run()|at 
>

Re: Review Request 56013: Ambari Server Unit Test failure on branch-2.5/trunk for testUpdateConfigForceSecurityEnabled

2017-01-30 Thread Eugene Chekanskiy 


> On Jan. 30, 2017, 11:29 a.m., Attila Doroszlai wrote:
> > ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/UpdateKerberosConfigsServerActionTest.java,
> >  line 47
> > 
> >
> > Please make sure tests pass on `trunk`, too, not only on `branch-2.5`.
> > 
> > ```
> > [INFO] --- maven-checkstyle-plugin:2.17:check (checkstyle) @ 
> > ambari-server ---
> > [INFO] Starting audit...
> > [ERROR] 
> > ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/UpdateKerberosConfigsServerActionTest.java:47:
> >  'com.google.inject.AbstractModule' should be separated from previous 
> > imports. [ImportOrder]
> > Audit done.
> > ```

thanks, fixed


- Eugene


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56013/#review163493
---


On Jan. 30, 2017, 1:10 p.m., Eugene Chekanskiy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56013/
> ---
> 
> (Updated Jan. 30, 2017, 1:10 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Robert Levas.
> 
> 
> Bugs: AMBARI-19741
> https://issues.apache.org/jira/browse/AMBARI-19741
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> fixing filed tests
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/UpdateKerberosConfigsServerActionTest.java
>  e756491 
> 
> Diff: https://reviews.apache.org/r/56013/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Eugene Chekanskiy
> 
>

Re: Review Request 56076: AMBARI-19775. ActionQueue thread may exit due to IOError in statusCommandResultQueue.empty()

2017-01-30 Thread Andrew Onischuk 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56076/#review163512
---


Ship it!




Ship It!

- Andrew Onischuk


On Jan. 30, 2017, 1:04 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56076/
> ---
> 
> (Updated Jan. 30, 2017, 1:04 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Sandor Magyari, and Sebastian 
> Toader.
> 
> 
> Bugs: AMBARI-19775
> https://issues.apache.org/jira/browse/AMBARI-19775
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Handle IOError thrown from empty()
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/ActionQueue.py 
> 18d7c2afd20279fe6586b3235dcd668aabeeb7fb 
> 
> Diff: https://reviews.apache.org/r/56076/diff/
> 
> 
> Testing
> ---
> 
> Manual testing: simulated IOError, verified heartbeat continues to include 
> status command results.
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 56054: Inconsistent auth-to-local rules processing during Kerberos authentication

2017-01-30 Thread Balázs Bence Sári 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56054/#review163487
---


Ship it!




Ship It!

- Balázs Bence Sári


On Jan. 29, 2017, 12:50 a.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56054/
> ---
> 
> (Updated Jan. 29, 2017, 12:50 a.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene 
> Chekanskiy, Laszlo Puskas, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-19767
> https://issues.apache.org/jira/browse/AMBARI-19767
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Facing issue with local to auth rules. 
> ambari-qa-...@example.com is getting converted to ambari-qa-cl1 as well as 
> ambari-qa with same ambari configuration ie 
> authentication.kerberos.auth_to_local.rules=DEFAULT.
> 
> 1st translation : 
> ```
> 28 Jan 2017 11:44:45,529  INFO [ambari-client-thread-3298] 
> AmbariAuthToLocalUserDetailsService:102 - Translated 
> ambari-qa-...@example.com to ambari-qa-cl1 using auth-to-local rules during 
> Kerberos authentication.
> ```
> 
> 2nd translation :
> ```
> 28 Jan 2017 11:47:36,425  INFO [ambari-client-thread-3172] 
> AmbariAuthToLocalUserDetailsService:102 - Translated 
> ambari-qa-...@example.com to ambari-qa using auth-to-local rules during 
> Kerberos authentication.
> 28 Jan 2017 11:47:36,428  WARN [ambari-client-thread-3172] 
> AmbariAuthToLocalUserDetailsService:136 - Failed find user account for user 
> with username of ambari-qa during Kerberos authentication.
> 28
> ```
> 
> Since authentication.kerberos.auth_to_local.rules=DEFAULT ,  
> 'ambari-qa-...@example.com' should have been translated to 'ambari-qa-cl1'.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/kerberos/AmbariAuthToLocalUserDetailsService.java
>  c85503c 
> 
> Diff: https://reviews.apache.org/r/56054/diff/
> 
> 
> Testing
> ---
> 
> # Local test results: 
> 
> ```
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 35:42.972s
> [INFO] Finished at: Sat Jan 28 17:37:32 EST 2017
> [INFO] Final Memory: 66M/1180M
> [INFO] 
> 
> ```
> 
> # Jenkins test results: PENDING
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 56071: AMBARI-19766:Not able to set the sla for an action node

2017-01-30 Thread belliraj hb 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56071/#review163491
---


Ship it!




Ship It!

- belliraj hb


On Jan. 30, 2017, 9:15 a.m., Padma Priya N wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56071/
> ---
> 
> (Updated Jan. 30, 2017, 9:15 a.m.)
> 
> 
> Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and 
> Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-19766
> https://issues.apache.org/jira/browse/AMBARI-19766
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added an if condition for not deleting the sla object of an action if the 
> action is not a custom action.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/workflow-action-editor.js
>  f2d3ba8 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/sla-info.hbs
>  447bac2 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/sqoop-action.hbs
>  3f0ec61 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-actions.hbs
>  badf320 
> 
> Diff: https://reviews.apache.org/r/56071/diff/
> 
> 
> Testing
> ---
> 
> Manual
> 
> 
> Thanks,
> 
> Padma Priya N
> 
>

Re: Review Request 56074: AMBARI-19774:Undo Add Node feature needed for workflow designer similar to Undo Delete

2017-01-30 Thread belliraj hb 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56074/#review163495
---


Ship it!




Ship It!

- belliraj hb


On Jan. 30, 2017, 11:32 a.m., Padma Priya N wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56074/
> ---
> 
> (Updated Jan. 30, 2017, 11:32 a.m.)
> 
> 
> Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-19774
> https://issues.apache.org/jira/browse/AMBARI-19774
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added functionlity to undo add similiar to undo delete
> 
> 
> Diffs
> -
> 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 
> 1292832 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs
>  2b8844e 
> 
> Diff: https://reviews.apache.org/r/56074/diff/
> 
> 
> Testing
> ---
> 
> Manual Testing
> 
> 
> Thanks,
> 
> Padma Priya N
> 
>

Re: Review Request 56013: Ambari Server Unit Test failure on branch-2.5/trunk for testUpdateConfigForceSecurityEnabled

2017-01-30 Thread Eugene Chekanskiy 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56013/
---

(Updated Jan. 30, 2017, 1:10 p.m.)


Review request for Ambari, Dmitro Lisnichenko and Robert Levas.


Changes
---

fixed imports


Bugs: AMBARI-19741
https://issues.apache.org/jira/browse/AMBARI-19741


Repository: ambari


Description
---

fixing filed tests


Diffs (updated)
-

  
ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/UpdateKerberosConfigsServerActionTest.java
 e756491 

Diff: https://reviews.apache.org/r/56013/diff/


Testing
---

mvn clean test


Thanks,

Eugene Chekanskiy

Re: Review Request 56064: Format ZKFC commands failing while enabling NameNode HA

2017-01-30 Thread Robert Levas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56064/#review163517
---


Ship it!




Ship It!

- Robert Levas


On Jan. 29, 2017, 3:43 p.m., Sebastian Toader wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56064/
> ---
> 
> (Updated Jan. 29, 2017, 3:43 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Laszlo Puskas, and Robert Levas.
> 
> 
> Bugs: AMBARI-19736
> https://issues.apache.org/jira/browse/AMBARI-19736
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Format ZKFC commands failing while enabling NameNode HA at Initializa 
> Metadata step.
> 
> ```
> Caused by: org.apache.zookeeper.KeeperException$NoAuthException: 
> KeeperErrorCode = NoAuth for /hadoop-ha/nameservice
>   at org.apache.zookeeper.KeeperException.create(KeeperException.java:113)
>   at org.apache.zookeeper.KeeperException.create(KeeperException.java:51)
>   at org.apache.zookeeper.ZooKeeper.create(ZooKeeper.java:783)
>   at 
> org.apache.hadoop.ha.ActiveStandbyElector$3.run(ActiveStandbyElector.java:1000)
>   at 
> org.apache.hadoop.ha.ActiveStandbyElector$3.run(ActiveStandbyElector.java:997)
>   at 
> org.apache.hadoop.ha.ActiveStandbyElector.zkDoWithRetries(ActiveStandbyElector.java:1041)
>   at 
> org.apache.hadoop.ha.ActiveStandbyElector.createWithRetries(ActiveStandbyElector.java:997)
>   at 
> org.apache.hadoop.ha.ActiveStandbyElector.ensureParentZNode(ActiveStandbyElector.java:344)
>   ... 11 more
> ```
>  
> The reason for the failure is that the `hdfs_jaas.conf` file is generated 
> during ZKFC component configuration. When NN HA is enabled via UI the ZKFC is 
> not added yet to the cluster thus the `hdfs_jaas.conf` file is not generated 
> yet, this leading the format ZKFC commands to fail as this require the jaas 
> file.
> 
> The solution is to move the creation of `hdfs_jaas.conf` file into the NN 
> configuration.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py
>  a2edf38 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/utils.py
>  03aba7b 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/zkfc_slave.py
>  bfc9429 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/scripts/hdfs_namenode.py
>  7fae57f 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/scripts/utils.py
>  9eebe63 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/scripts/zkfc_slave.py
>  f2ea6ad 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-ANY/scripts/params.py
>  8e0e783 
>   
> ambari-server/src/main/resources/stacks/HDP/3.0/hooks/before-ANY/scripts/params.py
>  8e5d210 
> 
> Diff: https://reviews.apache.org/r/56064/diff/
> 
> 
> Testing
> ---
> 
> Manual testing using both wizzard and blueprints.
> 
> Unit tests:
> ```
> mvn test -DskipSurefireTests -am -pl ambari-server
> 
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Main ... SUCCESS [11.634s]
> [INFO] Apache Ambari Project POM . SUCCESS [0.045s]
> [INFO] Ambari Views .. SUCCESS [2.086s]
> [INFO] utility ... SUCCESS [1.175s]
> [INFO] ambari-metrics  SUCCESS [0.608s]
> [INFO] Ambari Metrics Common . SUCCESS [0.352s]
> [INFO] Ambari Server . SUCCESS [2:25.628s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> ```
> 
> 
> Thanks,
> 
> Sebastian Toader
> 
>

Re: Review Request 56081: Normalize upgrade status label in Upgrade History

2017-01-30 Thread Aleksandr Kovalenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56081/#review163521
---


Ship it!




Ship It!

- Aleksandr Kovalenko


On Янв. 30, 2017, 2:40 п.п., Andrii Tkach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56081/
> ---
> 
> (Updated Янв. 30, 2017, 2:40 п.п.)
> 
> 
> Review request for Ambari and Aleksandr Kovalenko.
> 
> 
> Bugs: AMBARI-19779
> https://issues.apache.org/jira/browse/AMBARI-19779
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Normalize upgrade status label in Upgrade History
> 
> 
> Diffs
> -
> 
>   ambari-web/app/models/host_stack_version.js b0c000e 
>   ambari-web/app/models/stack_version/stack_upgrade_history.js 9e0439c 
>   ambari-web/app/templates/main/admin/stack_upgrade/upgrade_history.hbs 
> e023fbb 
>   ambari-web/app/utils/string_utils.js f4e3674 
>   ambari-web/test/utils/string_utils_test.js 3c7b077 
> 
> Diff: https://reviews.apache.org/r/56081/diff/
> 
> 
> Testing
> ---
> 
> 20330 passing (34s)
> 153 pending
> 
> 
> Thanks,
> 
> Andrii Tkach
> 
>

Re: Review Request 56075: Hive2: LOGS tab is more prominently displayed than RESULTS

2017-01-30 Thread Pallav Kulshreshtha 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56075/
---

(Updated Jan. 30, 2017, 11:47 a.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and 
Rohit Choudhary.


Bugs: AMBARI-19765
https://issues.apache.org/jira/browse/AMBARI-19765


Repository: ambari


Description
---

UI changes


Diffs (updated)
-

  contrib/views/hive20/src/main/resources/ui/app/models/worksheet.js 6a77633 
  contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 
753b7f7 
  contrib/views/hive20/src/main/resources/ui/app/services/jobs.js 5db22d0 
  contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 17abb65 
  
contrib/views/hive20/src/main/resources/ui/app/templates/components/query-result-table.hbs
 4fe6f43 
  contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs 
5cdc9b3 

Diff: https://reviews.apache.org/r/56075/diff/


Testing
---

manually tested.


Thanks,

Pallav Kulshreshtha

Re: Review Request 56064: Format ZKFC commands failing while enabling NameNode HA

2017-01-30 Thread Laszlo Puskas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56064/#review163483
---


Ship it!




Ship It!

- Laszlo Puskas


On Jan. 29, 2017, 8:43 p.m., Sebastian Toader wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56064/
> ---
> 
> (Updated Jan. 29, 2017, 8:43 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Laszlo Puskas, and Robert Levas.
> 
> 
> Bugs: AMBARI-19736
> https://issues.apache.org/jira/browse/AMBARI-19736
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Format ZKFC commands failing while enabling NameNode HA at Initializa 
> Metadata step.
> 
> ```
> Caused by: org.apache.zookeeper.KeeperException$NoAuthException: 
> KeeperErrorCode = NoAuth for /hadoop-ha/nameservice
>   at org.apache.zookeeper.KeeperException.create(KeeperException.java:113)
>   at org.apache.zookeeper.KeeperException.create(KeeperException.java:51)
>   at org.apache.zookeeper.ZooKeeper.create(ZooKeeper.java:783)
>   at 
> org.apache.hadoop.ha.ActiveStandbyElector$3.run(ActiveStandbyElector.java:1000)
>   at 
> org.apache.hadoop.ha.ActiveStandbyElector$3.run(ActiveStandbyElector.java:997)
>   at 
> org.apache.hadoop.ha.ActiveStandbyElector.zkDoWithRetries(ActiveStandbyElector.java:1041)
>   at 
> org.apache.hadoop.ha.ActiveStandbyElector.createWithRetries(ActiveStandbyElector.java:997)
>   at 
> org.apache.hadoop.ha.ActiveStandbyElector.ensureParentZNode(ActiveStandbyElector.java:344)
>   ... 11 more
> ```
>  
> The reason for the failure is that the `hdfs_jaas.conf` file is generated 
> during ZKFC component configuration. When NN HA is enabled via UI the ZKFC is 
> not added yet to the cluster thus the `hdfs_jaas.conf` file is not generated 
> yet, this leading the format ZKFC commands to fail as this require the jaas 
> file.
> 
> The solution is to move the creation of `hdfs_jaas.conf` file into the NN 
> configuration.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py
>  a2edf38 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/utils.py
>  03aba7b 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/zkfc_slave.py
>  bfc9429 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/scripts/hdfs_namenode.py
>  7fae57f 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/scripts/utils.py
>  9eebe63 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/scripts/zkfc_slave.py
>  f2ea6ad 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-ANY/scripts/params.py
>  8e0e783 
>   
> ambari-server/src/main/resources/stacks/HDP/3.0/hooks/before-ANY/scripts/params.py
>  8e5d210 
> 
> Diff: https://reviews.apache.org/r/56064/diff/
> 
> 
> Testing
> ---
> 
> Manual testing using both wizzard and blueprints.
> 
> Unit tests:
> ```
> mvn test -DskipSurefireTests -am -pl ambari-server
> 
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Main ... SUCCESS [11.634s]
> [INFO] Apache Ambari Project POM . SUCCESS [0.045s]
> [INFO] Ambari Views .. SUCCESS [2.086s]
> [INFO] utility ... SUCCESS [1.175s]
> [INFO] ambari-metrics  SUCCESS [0.608s]
> [INFO] Ambari Metrics Common . SUCCESS [0.352s]
> [INFO] Ambari Server . SUCCESS [2:25.628s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> ```
> 
> 
> Thanks,
> 
> Sebastian Toader
> 
>

Re: Review Request 56068: AMBARI-19772. Job XML tag is not coming as part of FS action node

2017-01-30 Thread Gaurav Nagar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56068/#review163481
---


Ship it!




Ship It!

- Gaurav Nagar


On Jan. 30, 2017, 7:22 a.m., Madhan Reddy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56068/
> ---
> 
> (Updated Jan. 30, 2017, 7:22 a.m.)
> 
> 
> Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and 
> Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-19772
> https://issues.apache.org/jira/browse/AMBARI-19772
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added job-xml mapping to fs action node
> 
> 
> Diffs
> -
> 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/domain/actionjob_hanlder.js 
> c9d9887 
> 
> Diff: https://reviews.apache.org/r/56068/diff/
> 
> 
> Testing
> ---
> 
> Manual
> 
> 
> Thanks,
> 
> Madhan Reddy
> 
>

Re: Review Request 56013: Ambari Server Unit Test failure on branch-2.5/trunk for testUpdateConfigForceSecurityEnabled

2017-01-30 Thread Eugene Chekanskiy 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56013/
---

(Updated Jan. 30, 2017, 10:30 a.m.)


Review request for Ambari, Dmitro Lisnichenko and Robert Levas.


Changes
---

fixed java 7 capture issue.


Bugs: AMBARI-19741
https://issues.apache.org/jira/browse/AMBARI-19741


Repository: ambari


Description
---

fixing filed tests


Diffs (updated)
-

  
ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/UpdateKerberosConfigsServerActionTest.java
 e756491 

Diff: https://reviews.apache.org/r/56013/diff/


Testing
---

mvn clean test


Thanks,

Eugene Chekanskiy

Review Request 56071: AMBARI-19766:Not able to set the sla for an action node

2017-01-30 Thread Padma Priya N 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56071/
---

Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and 
Pallav Kulshreshtha.


Bugs: AMBARI-19766
https://issues.apache.org/jira/browse/AMBARI-19766


Repository: ambari


Description
---

Added an if condition for not deleting the sla object of an action if the 
action is not a custom action.


Diffs
-

  
contrib/views/wfmanager/src/main/resources/ui/app/components/workflow-action-editor.js
 f2d3ba8 
  
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/sla-info.hbs
 447bac2 
  
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/sqoop-action.hbs
 3f0ec61 

Diff: https://reviews.apache.org/r/56071/diff/


Testing
---

Manual


Thanks,

Padma Priya N

Re: Review Request 56071: AMBARI-19766:Not able to set the sla for an action node

2017-01-30 Thread Padma Priya N 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56071/
---

(Updated Jan. 30, 2017, 9:15 a.m.)


Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and 
Pallav Kulshreshtha.


Bugs: AMBARI-19766
https://issues.apache.org/jira/browse/AMBARI-19766


Repository: ambari


Description
---

Added an if condition for not deleting the sla object of an action if the 
action is not a custom action.


Diffs (updated)
-

  
contrib/views/wfmanager/src/main/resources/ui/app/components/workflow-action-editor.js
 f2d3ba8 
  
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/sla-info.hbs
 447bac2 
  
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/sqoop-action.hbs
 3f0ec61 
  
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-actions.hbs
 badf320 

Diff: https://reviews.apache.org/r/56071/diff/


Testing
---

Manual


Thanks,

Padma Priya N

Re: Review Request 56013: Ambari Server Unit Test failure on branch-2.5/trunk for testUpdateConfigForceSecurityEnabled

2017-01-30 Thread Attila Doroszlai 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56013/#review163493
---


Fix it, then Ship it!





ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/UpdateKerberosConfigsServerActionTest.java
 


Please make sure tests pass on `trunk`, too, not only on `branch-2.5`.

```
[INFO] --- maven-checkstyle-plugin:2.17:check (checkstyle) @ ambari-server 
---
[INFO] Starting audit...
[ERROR] 
ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/UpdateKerberosConfigsServerActionTest.java:47:
 'com.google.inject.AbstractModule' should be separated from previous imports. 
[ImportOrder]
Audit done.
```


- Attila Doroszlai


On Jan. 30, 2017, 11:30 a.m., Eugene Chekanskiy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56013/
> ---
> 
> (Updated Jan. 30, 2017, 11:30 a.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Robert Levas.
> 
> 
> Bugs: AMBARI-19741
> https://issues.apache.org/jira/browse/AMBARI-19741
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> fixing filed tests
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/UpdateKerberosConfigsServerActionTest.java
>  e756491 
> 
> Diff: https://reviews.apache.org/r/56013/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Eugene Chekanskiy
> 
>

Review Request 56072: AMBARI-19773 Enable incremental sync by default for fresh install for Ranger Usersync

2017-01-30 Thread Mugdha Varadkar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56072/
---

Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jonathan Hurley, 
and Velmurugan Periasamy.


Bugs: AMBARI-19773
https://issues.apache.org/jira/browse/AMBARI-19773


Repository: ambari


Description
---

ranger.usersync.ldap.deltasync property is introduced from stack 2.6.
For fresh installs need to keep this property enabled.
For upgrade scenario with sync source as AD/LDAP, need to disable 
ranger.usersync.ldap.deltasync


Diffs
-

  
ambari-server/src/main/resources/common-services/RANGER/0.7.0/configuration/ranger-ugsync-site.xml
 775b5ca 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 
1974acb 
  
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml
 dafe8e3 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml 
981947f 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml 
e6817f6 
  
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml
 065c265 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 
0a0c757 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 
ddffc79 
  
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml
 abb5428 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 
790e50c 

Diff: https://reviews.apache.org/r/56072/diff/


Testing
---

Tested Ranger fresh installation and EU with sync source LDAP/AD enabled.


Thanks,

Mugdha Varadkar

Re: Review Request 56064: Format ZKFC commands failing while enabling NameNode HA

2017-01-30 Thread Attila Magyar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56064/#review163482
---


Ship it!




Ship It!

- Attila Magyar


On Jan. 29, 2017, 8:43 p.m., Sebastian Toader wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56064/
> ---
> 
> (Updated Jan. 29, 2017, 8:43 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Laszlo Puskas, and Robert Levas.
> 
> 
> Bugs: AMBARI-19736
> https://issues.apache.org/jira/browse/AMBARI-19736
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Format ZKFC commands failing while enabling NameNode HA at Initializa 
> Metadata step.
> 
> ```
> Caused by: org.apache.zookeeper.KeeperException$NoAuthException: 
> KeeperErrorCode = NoAuth for /hadoop-ha/nameservice
>   at org.apache.zookeeper.KeeperException.create(KeeperException.java:113)
>   at org.apache.zookeeper.KeeperException.create(KeeperException.java:51)
>   at org.apache.zookeeper.ZooKeeper.create(ZooKeeper.java:783)
>   at 
> org.apache.hadoop.ha.ActiveStandbyElector$3.run(ActiveStandbyElector.java:1000)
>   at 
> org.apache.hadoop.ha.ActiveStandbyElector$3.run(ActiveStandbyElector.java:997)
>   at 
> org.apache.hadoop.ha.ActiveStandbyElector.zkDoWithRetries(ActiveStandbyElector.java:1041)
>   at 
> org.apache.hadoop.ha.ActiveStandbyElector.createWithRetries(ActiveStandbyElector.java:997)
>   at 
> org.apache.hadoop.ha.ActiveStandbyElector.ensureParentZNode(ActiveStandbyElector.java:344)
>   ... 11 more
> ```
>  
> The reason for the failure is that the `hdfs_jaas.conf` file is generated 
> during ZKFC component configuration. When NN HA is enabled via UI the ZKFC is 
> not added yet to the cluster thus the `hdfs_jaas.conf` file is not generated 
> yet, this leading the format ZKFC commands to fail as this require the jaas 
> file.
> 
> The solution is to move the creation of `hdfs_jaas.conf` file into the NN 
> configuration.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py
>  a2edf38 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/utils.py
>  03aba7b 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/zkfc_slave.py
>  bfc9429 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/scripts/hdfs_namenode.py
>  7fae57f 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/scripts/utils.py
>  9eebe63 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/scripts/zkfc_slave.py
>  f2ea6ad 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-ANY/scripts/params.py
>  8e0e783 
>   
> ambari-server/src/main/resources/stacks/HDP/3.0/hooks/before-ANY/scripts/params.py
>  8e5d210 
> 
> Diff: https://reviews.apache.org/r/56064/diff/
> 
> 
> Testing
> ---
> 
> Manual testing using both wizzard and blueprints.
> 
> Unit tests:
> ```
> mvn test -DskipSurefireTests -am -pl ambari-server
> 
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Main ... SUCCESS [11.634s]
> [INFO] Apache Ambari Project POM . SUCCESS [0.045s]
> [INFO] Ambari Views .. SUCCESS [2.086s]
> [INFO] utility ... SUCCESS [1.175s]
> [INFO] ambari-metrics  SUCCESS [0.608s]
> [INFO] Ambari Metrics Common . SUCCESS [0.352s]
> [INFO] Ambari Server . SUCCESS [2:25.628s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> ```
> 
> 
> Thanks,
> 
> Sebastian Toader
> 
>

Review Request 56074: AMBARI-19774:Undo Add Node feature needed for workflow designer similar to Undo Delete

2017-01-30 Thread Padma Priya N 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56074/
---

Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha.


Bugs: AMBARI-19774
https://issues.apache.org/jira/browse/AMBARI-19774


Repository: ambari


Description
---

Added functionlity to undo add similiar to undo delete


Diffs
-

  contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 
1292832 
  
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs
 2b8844e 

Diff: https://reviews.apache.org/r/56074/diff/


Testing
---

Manual Testing


Thanks,

Padma Priya N

Re: Review Request 56078: Hive View 2.0: Table manager - DDL tab should show query as readonly in query editor

2017-01-30 Thread Gaurav Nagar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56078/#review163527
---


Ship it!




Ship It!

- Gaurav Nagar


On Jan. 30, 2017, 4:12 p.m., Pallav Kulshreshtha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56078/
> ---
> 
> (Updated Jan. 30, 2017, 4:12 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
> and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-19523
> https://issues.apache.org/jira/browse/AMBARI-19523
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Changed ivy-codemirror to custom component query-editor.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive20/src/main/resources/ui/app/templates/components/query-result-table.hbs
>  4fe6f43 
>   contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs 
> 5cdc9b3 
> 
> Diff: https://reviews.apache.org/r/56078/diff/
> 
> 
> Testing
> ---
> 
> manually tested.
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>

Re: Review Request 56077: Update slider tarball before uploading to DFS

2017-01-30 Thread Sumit Mohanty 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56077/#review163526
---


Ship it!




Ship It!

- Sumit Mohanty


On Jan. 30, 2017, 1:24 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56077/
> ---
> 
> (Updated Jan. 30, 2017, 1:24 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-19776
> https://issues.apache.org/jira/browse/AMBARI-19776
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/scripts/Ambaripreupload.py 0e25a2a 
> 
> Diff: https://reviews.apache.org/r/56077/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 56078: Hive View 2.0: Table manager - DDL tab should show query as readonly in query editor

2017-01-30 Thread Pallav Kulshreshtha 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56078/
---

(Updated Jan. 30, 2017, 4:12 p.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and 
Rohit Choudhary.


Bugs: AMBARI-19523
https://issues.apache.org/jira/browse/AMBARI-19523


Repository: ambari


Description
---

Changed ivy-codemirror to custom component query-editor.


Diffs (updated)
-

  
contrib/views/hive20/src/main/resources/ui/app/templates/components/query-result-table.hbs
 4fe6f43 
  contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs 
5cdc9b3 

Diff: https://reviews.apache.org/r/56078/diff/


Testing
---

manually tested.


Thanks,

Pallav Kulshreshtha

Re: Review Request 56083: Reassign wizard erases config properties attributes

2017-01-30 Thread Aleksandr Kovalenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56083/#review163525
---


Ship it!




Ship It!

- Aleksandr Kovalenko


On Янв. 30, 2017, 3:41 п.п., Andriy Babiichuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56083/
> ---
> 
> (Updated Янв. 30, 2017, 3:41 п.п.)
> 
> 
> Review request for Ambari and Aleksandr Kovalenko.
> 
> 
> Bugs: AMBARI-19781
> https://issues.apache.org/jira/browse/AMBARI-19781
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In process of reconfiguring moved component, Reassign wizard doesn't save 
> attributes of affected properties.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/main/service/reassign/step3_controller.js 
> f13cf0b 
>   ambari-web/app/controllers/main/service/reassign/step4_controller.js 
> 2e9d431 
>   ambari-web/app/controllers/main/service/reassign_controller.js e512835 
>   ambari-web/app/routes/reassign_master_routes.js a2a9743 
>   ambari-web/test/controllers/main/service/reassign/step4_controller_test.js 
> 6bf381a 
> 
> Diff: https://reviews.apache.org/r/56083/diff/
> 
> 
> Testing
> ---
> 
> 20325 passing (18s)
>   153 pending
> 
> 
> Thanks,
> 
> Andriy Babiichuk
> 
>

Re: Review Request 56078: Hive View 2.0: Table manager - DDL tab should show query as readonly in query editor

2017-01-30 Thread Gaurav Nagar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56078/#review163529
---


Ship it!




Ship It!

- Gaurav Nagar


On Jan. 30, 2017, 4:56 p.m., Pallav Kulshreshtha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56078/
> ---
> 
> (Updated Jan. 30, 2017, 4:56 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
> and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-19523
> https://issues.apache.org/jira/browse/AMBARI-19523
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Changed ivy-codemirror to custom component query-editor.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive20/src/main/resources/ui/app/templates/databases/database/tables/table/ddl.hbs
>  cbbcdd0 
> 
> Diff: https://reviews.apache.org/r/56078/diff/
> 
> 
> Testing
> ---
> 
> manually tested.
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>

Re: Review Request 56084: Hive2: Results are not cleared on "execute"

2017-01-30 Thread Gaurav Nagar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56084/#review163530
---


Ship it!




Ship It!

- Gaurav Nagar


On Jan. 30, 2017, 4:06 p.m., Pallav Kulshreshtha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56084/
> ---
> 
> (Updated Jan. 30, 2017, 4:06 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
> and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-19782
> https://issues.apache.org/jira/browse/AMBARI-19782
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> UI changes.
> 
> 
> Diffs
> -
> 
>   contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 
> 753b7f7 
>   
> contrib/views/hive20/src/main/resources/ui/app/templates/components/query-result-table.hbs
>  4fe6f43 
>   contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs 
> 5cdc9b3 
> 
> Diff: https://reviews.apache.org/r/56084/diff/
> 
> 
> Testing
> ---
> 
> manually tested.
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>

Review Request 56082: Hive View : Logs are not complete for hive view

2017-01-30 Thread Gaurav Nagar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56082/
---

Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav 
Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.


Bugs: AMBARI-19780
https://issues.apache.org/jira/browse/AMBARI-19780


Repository: ambari


Description
---

Changes for saving full query logs with multiple statement to file.


Diffs
-

  
contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/actor/LogAggregator.java
 9412f81 
  
contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/actor/StatementExecutor.java
 d7b4f54 
  
contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/actor/message/StartLogAggregation.java
 b56da08 
  
contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/LogAggregator.java
 f9c21b4 
  
contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/StatementExecutor.java
 03332d9 
  
contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/message/StartLogAggregation.java
 922ad1d 

Diff: https://reviews.apache.org/r/56082/diff/


Testing
---

Manuall tested.


Thanks,

Gaurav Nagar

Review Request 56083: Reassign wizard erases config properties attributes

2017-01-30 Thread Andriy Babiichuk 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56083/
---

Review request for Ambari and Aleksandr Kovalenko.


Bugs: AMBARI-19781
https://issues.apache.org/jira/browse/AMBARI-19781


Repository: ambari


Description
---

In process of reconfiguring moved component, Reassign wizard doesn't save 
attributes of affected properties.


Diffs
-

  ambari-web/app/controllers/main/service/reassign/step3_controller.js f13cf0b 
  ambari-web/app/controllers/main/service/reassign/step4_controller.js 2e9d431 
  ambari-web/app/controllers/main/service/reassign_controller.js e512835 
  ambari-web/app/routes/reassign_master_routes.js a2a9743 
  ambari-web/test/controllers/main/service/reassign/step4_controller_test.js 
6bf381a 

Diff: https://reviews.apache.org/r/56083/diff/


Testing
---

20325 passing (18s)
  153 pending


Thanks,

Andriy Babiichuk

Review Request 56084: Hive2: Results are not cleared on "execute"

2017-01-30 Thread Pallav Kulshreshtha 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56084/
---

Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and 
Rohit Choudhary.


Bugs: AMBARI-19782
https://issues.apache.org/jira/browse/AMBARI-19782


Repository: ambari


Description
---

UI changes.


Diffs
-

  contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 
753b7f7 
  
contrib/views/hive20/src/main/resources/ui/app/templates/components/query-result-table.hbs
 4fe6f43 
  contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs 
5cdc9b3 

Diff: https://reviews.apache.org/r/56084/diff/


Testing
---

manually tested.


Thanks,

Pallav Kulshreshtha

Re: Review Request 56078: Hive View 2.0: Table manager - DDL tab should show query as readonly in query editor

2017-01-30 Thread Pallav Kulshreshtha 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56078/
---

(Updated Jan. 30, 2017, 4:56 p.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and 
Rohit Choudhary.


Bugs: AMBARI-19523
https://issues.apache.org/jira/browse/AMBARI-19523


Repository: ambari


Description
---

Changed ivy-codemirror to custom component query-editor.


Diffs (updated)
-

  
contrib/views/hive20/src/main/resources/ui/app/templates/databases/database/tables/table/ddl.hbs
 cbbcdd0 

Diff: https://reviews.apache.org/r/56078/diff/


Testing
---

manually tested.


Thanks,

Pallav Kulshreshtha

Re: Review Request 55953: CS queue refresh happens before the user clicks on the restart button

2017-01-30 Thread Jaimin Jetly 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55953/#review163535
---


Ship it!




Ship It!

- Jaimin Jetly


On Jan. 29, 2017, 5:11 p.m., Vivek Ratnavel Subramanian wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55953/
> ---
> 
> (Updated Jan. 29, 2017, 5:11 p.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly and Yusaku Sako.
> 
> 
> Bugs: AMBARI-19716
> https://issues.apache.org/jira/browse/AMBARI-19716
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Build 2.6.0.0-644.
> 
> When the llap sliders are moved, and configuration is saved - a queue refresh 
> happens immediately if the CS config was affected.
> 
> It does not wait for the user to click the Restart Services button.
> This can cause problems when the num nodes is being reduced, since the app is 
> still running - and the queue size is too small for it.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/messages.js bf3de62 
>   ambari-web/app/mixins/main/service/configs/component_actions_by_configs.js 
> ebfc2c7 
> 
> Diff: https://reviews.apache.org/r/55953/diff/
> 
> 
> Testing
> ---
> 
> Verified Manually.
> Ambari-web unit tests pass
> 
> 30309 passing (19s)
> 157 pending
> 
> 
> Thanks,
> 
> Vivek Ratnavel Subramanian
> 
>

Re: Review Request 55505: AMBARI-19524 : Use stack-level Atlas conf directory instead of hard-coded /etc/atlas/conf path

2017-01-30 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55505/#review163539
---


Ship it!




Ship It!

- Alejandro Fernandez


On Jan. 27, 2017, 3:05 p.m., Vishal Suvagia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55505/
> ---
> 
> (Updated Jan. 27, 2017, 3:05 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Madhan 
> Neethiraj, Mugdha Varadkar, Oliver Szabo, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-19524
> https://issues.apache.org/jira/browse/AMBARI-19524
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Hardcoding Atlas conf_dir path does lead to Upgrade Downgrade scenarios, need 
> to update Atlac Conf path as per stack structures
> 
> 
> Diffs
> -
> 
>   ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py 
> 8ae6469 
> 
> Diff: https://reviews.apache.org/r/55505/diff/
> 
> 
> Testing
> ---
> 
> Verified fresh installation on centos-6.
> 
> 
> Thanks,
> 
> Vishal Suvagia
> 
>

Re: Review Request 56077: Update slider tarball before uploading to DFS

2017-01-30 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56077/#review163538
---




ambari-server/src/main/resources/scripts/Ambaripreupload.py (line 141)


Remove the hardcoding of "/usr/hdp".
Use stack_root instead.


- Alejandro Fernandez


On Jan. 30, 2017, 1:24 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56077/
> ---
> 
> (Updated Jan. 30, 2017, 1:24 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-19776
> https://issues.apache.org/jira/browse/AMBARI-19776
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/scripts/Ambaripreupload.py 0e25a2a 
> 
> Diff: https://reviews.apache.org/r/56077/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 56059: Preview: Package Installation fails due to error in Berkeley DB library

2017-01-30 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56059/#review163543
---




ambari-common/src/main/python/ambari_commons/shell.py (lines 130 - 131)


What about the installers for other OSes?
Can we have a dictionary/config with the installer for the current OS?


- Alejandro Fernandez


On Jan. 29, 2017, 12:27 p.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56059/
> ---
> 
> (Updated Jan. 29, 2017, 12:27 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmytro Grinenko, Jonathan 
> Hurley, and Nate Cole.
> 
> 
> Bugs: AMBARI-19768
> https://issues.apache.org/jira/browse/AMBARI-19768
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> *Steps*
> # Deploy HDP-2.5.0.0 with Ambari 2.4.1.0
> # Upgrade ambari to 2.5.0.0-481 (I did not register Falcon library, as the 
> jar was already present in /var/lib/ambari-server/resources/je-5.0.73.jar on 
> Ambari server node)
> # Register HDP-2.6.0.0-216
> # Start package installation
> 
> *Result:*
> Got below errors:
> {code}
> 2016-12-16 13:47:10,419|INFO|MainThread|machine.py:145 - 
> run()|CRITICAL:yum.main:
> 2016-12-16 13:47:10,419|INFO|MainThread|machine.py:145 - run()|
> 2016-12-16 13:47:10,419|INFO|MainThread|machine.py:145 - run()|Error: rpmdb 
> open failed
> 2016-12-16 13:47:10,420|INFO|MainThread|machine.py:145 - run()|Traceback 
> (most recent call last):
> 2016-12-16 13:47:10,420|INFO|MainThread|machine.py:145 - run()|File 
> "/var/lib/ambari-agent/cache/custom_actions/scripts/install_packages.py", 
> line 166, in actionexecute
> 2016-12-16 13:47:10,420|INFO|MainThread|machine.py:145 - run()|ret_code = 
> self.install_packages(package_list)
> 2016-12-16 13:47:10,420|INFO|MainThread|machine.py:145 - run()|File 
> "/var/lib/ambari-agent/cache/custom_actions/scripts/install_packages.py", 
> line 400, in install_packages
> 2016-12-16 13:47:10,420|INFO|MainThread|machine.py:145 - run()|if not 
> verifyDependencies():
> 2016-12-16 13:47:10,421|INFO|MainThread|machine.py:145 - run()|File 
> "/usr/lib/python2.6/site-packages/resource_management/libraries/functions/packages_analyzer.py",
>  line 311, in verifyDependencies
> 2016-12-16 13:47:10,421|INFO|MainThread|machine.py:145 - run()|code, out = 
> rmf_shell.checked_call(cmd, sudo=True)
> 2016-12-16 13:47:10,421|INFO|MainThread|machine.py:145 - run()|File 
> "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 
> 72, in inner
> 2016-12-16 13:47:10,421|INFO|MainThread|machine.py:145 - run()|result = 
> function(command, **kwargs)
> 2016-12-16 13:47:10,421|INFO|MainThread|machine.py:145 - run()|File 
> "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 
> 102, in checked_call
> 2016-12-16 13:47:10,422|INFO|MainThread|machine.py:145 - run()|tries=tries, 
> try_sleep=try_sleep, timeout_kill_strategy=timeout_kill_strategy)
> 2016-12-16 13:47:10,422|INFO|MainThread|machine.py:145 - run()|File 
> "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 
> 150, in _call_wrapper
> 2016-12-16 13:47:10,422|INFO|MainThread|machine.py:145 - run()|result = 
> _call(command, **kwargs_copy)
> 2016-12-16 13:47:10,422|INFO|MainThread|machine.py:145 - run()|File 
> "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 
> 303, in _call
> 2016-12-16 13:47:10,423|INFO|MainThread|machine.py:145 - run()|raise 
> ExecutionFailed(err_msg, code, out, err)
> 2016-12-16 13:47:10,423|INFO|MainThread|machine.py:145 - 
> run()|ExecutionFailed: Execution of '/usr/bin/yum -d 0 -e 0 check 
> dependencies' returned 1. error: rpmdb: BDB0113 Thread/process 
> 16016/139791567193920 failed: BDB1507 Thread died in Berkeley DB library
> 2016-12-16 13:47:10,424|INFO|MainThread|machine.py:145 - run()|error: db5 
> error(-30973) from dbenv->failchk: BDB0087 DB_RUNRECOVERY: Fatal error, run 
> database recovery
> 2016-12-16 13:47:10,424|INFO|MainThread|machine.py:145 - run()|error: cannot 
> open Packages index using db5 -  (-30973)
> 2016-12-16 13:47:10,424|INFO|MainThread|machine.py:145 - run()|error: cannot 
> open Packages database in /var/lib/rpm
> 2016-12-16 13:47:10,424|INFO|MainThread|machine.py:145 - 
> run()|CRITICAL:yum.main:
> 2016-12-16 13:47:10,424|INFO|MainThread|machine.py:145 - run()|
> 2016-12-16 13:47:10,425|INFO|MainThread|machine.py:145 - run()|Error: rpmdb 
> open failed
> 2016-12-16 13:47:10,425|INFO|MainThread|machine.py:145 - run()|Traceback 
> (most recent call last):
> 2016-12-16 13:47:10,425|INFO|MainThread|machine.py:145 - run()|File 
> "/var/lib/ambari-agent/cache/custom_actions/scripts/install_packages.py", 
>

Review Request 56097: Need to have a flag from UI to show/hide ranger plugin configs

2017-01-30 Thread Jaimin Jetly 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56097/
---

Review request for Ambari, Richard Zang, Xi Wang, and Yusaku Sako.


Bugs: AMBARI-19785
https://issues.apache.org/jira/browse/AMBARI-19785


Repository: ambari


Description
---

UI changes are required to show/hide ranger plugin configs under component 
config tab.

If Ranger is not installed on same cluster but is setup on external cluster 
then cluster-env/enable_external_ranger can be set to true to expose ranger 
plugin related properties for all services

This Flag *cluster-env/enable_external_range* should show ranger plugin 
config-types for all services:
ranger--plugin-properties.xml
ranger--audit.xml
ranger--security.xml
ranger--policymgr-ssl.xml


Diffs
-

  
ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml 
93680bf 
  ambari-web/app/controllers/main/service/info/configs.js d946ea0 
  ambari-web/app/controllers/wizard/step7_controller.js 7dcc2ad 

Diff: https://reviews.apache.org/r/56097/diff/


Testing
---

Verified on manual cluster
verified that all ambari-web unit tests passes:

20325 passing (24s)
153 pending


Thanks,

Jaimin Jetly

Re: Review Request 56072: AMBARI-19773 Enable incremental sync by default for fresh install for Ranger Usersync

2017-01-30 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56072/#review163552
---


Ship it!




Ship It!

- Alejandro Fernandez


On Jan. 30, 2017, 9:13 a.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56072/
> ---
> 
> (Updated Jan. 30, 2017, 9:13 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jonathan 
> Hurley, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-19773
> https://issues.apache.org/jira/browse/AMBARI-19773
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> ranger.usersync.ldap.deltasync property is introduced from stack 2.6.
> For fresh installs need to keep this property enabled.
> For upgrade scenario with sync source as AD/LDAP, need to disable 
> ranger.usersync.ldap.deltasync
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.7.0/configuration/ranger-ugsync-site.xml
>  775b5ca 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 
> 1974acb 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml
>  dafe8e3 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml 
> 981947f 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml 
> e6817f6 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml
>  065c265 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 
> 0a0c757 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 
> ddffc79 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml
>  abb5428 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 
> 790e50c 
> 
> Diff: https://reviews.apache.org/r/56072/diff/
> 
> 
> Testing
> ---
> 
> Tested Ranger fresh installation and EU with sync source LDAP/AD enabled.
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Re: Review Request 55989: Perf: start/stop all actions works much slower after few days of testing

2017-01-30 Thread Vitalyi Brodetskyi 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55989/
---

(Updated Січ. 30, 2017, 11:12 після полудня)


Review request for Ambari, Alejandro Fernandez, Myroslav Papirkovskyy, and Sid 
Wagle.


Repository: ambari


Description
---

I've deployed cluster with 3000 agents and started my little test script on it. 
Script is doing only three actions in loop: 1) Stop All services 2) Start All 
services 3) Update zk config.
After few days of work these actions need much more time to be executed. For 
example before stop/start all actions took near 7-8 minutes.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java
 c53a73d 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
 93f4a8f 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 0fce72b 
  ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
d304bb3 
  ambari-server/src/main/java/org/apache/ambari/server/state/Host.java 04b2104 
  
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
 0381e38 
  ambari-server/src/main/java/org/apache/ambari/server/state/host/HostImpl.java 
3c7b040 
  
ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java
 1bcffe4 

Diff: https://reviews.apache.org/r/55989/diff/


Testing
---


Thanks,

Vitalyi Brodetskyi

Re: Review Request 56050: Kerberizing PERF cluster fails since cannot find principal name config in dummy.py

2017-01-30 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56050/#review163588
---


Ship it!




Ship It!

- Alejandro Fernandez


On Jan. 28, 2017, 2:12 a.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56050/
> ---
> 
> (Updated Jan. 28, 2017, 2:12 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, Sumit Mohanty, 
> and Sid Wagle.
> 
> 
> Bugs: AMBARI-19762
> https://issues.apache.org/jira/browse/AMBARI-19762
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Kerberizing PERF cluster fails since cannot find principal name config in 
> dummy.py
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/FAKEHDFS/package/scripts/zkfc_slave.py
>  66e36ad 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/FAKEYARN/metainfo.xml
>  0f926dd 
> 
> Diff: https://reviews.apache.org/r/56050/diff/
> 
> 
> Testing
> ---
> 
> Manual testing
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 56078: Hive View 2.0: Table manager - DDL tab should show query as readonly in query editor

2017-01-30 Thread DIPAYAN BHOWMICK 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56078/#review163629
---


Ship it!




Ship It!

- DIPAYAN BHOWMICK


On Jan. 30, 2017, 4:56 p.m., Pallav Kulshreshtha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56078/
> ---
> 
> (Updated Jan. 30, 2017, 4:56 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
> and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-19523
> https://issues.apache.org/jira/browse/AMBARI-19523
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Changed ivy-codemirror to custom component query-editor.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive20/src/main/resources/ui/app/templates/databases/database/tables/table/ddl.hbs
>  cbbcdd0 
> 
> Diff: https://reviews.apache.org/r/56078/diff/
> 
> 
> Testing
> ---
> 
> manually tested.
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>

Re: Review Request 56084: Hive2: Results are not cleared on "execute"

2017-01-30 Thread DIPAYAN BHOWMICK 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56084/#review163628
---


Ship it!




Ship It!

- DIPAYAN BHOWMICK


On Jan. 30, 2017, 4:06 p.m., Pallav Kulshreshtha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56084/
> ---
> 
> (Updated Jan. 30, 2017, 4:06 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
> and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-19782
> https://issues.apache.org/jira/browse/AMBARI-19782
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> UI changes.
> 
> 
> Diffs
> -
> 
>   contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 
> 753b7f7 
>   
> contrib/views/hive20/src/main/resources/ui/app/templates/components/query-result-table.hbs
>  4fe6f43 
>   contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs 
> 5cdc9b3 
> 
> Diff: https://reviews.apache.org/r/56084/diff/
> 
> 
> Testing
> ---
> 
> manually tested.
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>

Re: Review Request 56075: Hive2: LOGS tab is more prominently displayed than RESULTS

2017-01-30 Thread DIPAYAN BHOWMICK 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56075/#review163630
---


Ship it!




Ship It!

- DIPAYAN BHOWMICK


On Jan. 30, 2017, 11:47 a.m., Pallav Kulshreshtha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56075/
> ---
> 
> (Updated Jan. 30, 2017, 11:47 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
> and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-19765
> https://issues.apache.org/jira/browse/AMBARI-19765
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> UI changes
> 
> 
> Diffs
> -
> 
>   contrib/views/hive20/src/main/resources/ui/app/models/worksheet.js 6a77633 
>   contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 
> 753b7f7 
>   contrib/views/hive20/src/main/resources/ui/app/services/jobs.js 5db22d0 
>   contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 17abb65 
>   
> contrib/views/hive20/src/main/resources/ui/app/templates/components/query-result-table.hbs
>  4fe6f43 
>   contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs 
> 5cdc9b3 
> 
> Diff: https://reviews.apache.org/r/56075/diff/
> 
> 
> Testing
> ---
> 
> manually tested.
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>

Re: Review Request 56068: AMBARI-19772. Job XML tag is not coming as part of FS action node

2017-01-30 Thread belliraj hb 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56068/#review163476
---


Ship it!




Ship It!

- belliraj hb


On Jan. 30, 2017, 7:22 a.m., Madhan Reddy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56068/
> ---
> 
> (Updated Jan. 30, 2017, 7:22 a.m.)
> 
> 
> Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and 
> Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-19772
> https://issues.apache.org/jira/browse/AMBARI-19772
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added job-xml mapping to fs action node
> 
> 
> Diffs
> -
> 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/domain/actionjob_hanlder.js 
> c9d9887 
> 
> Diff: https://reviews.apache.org/r/56068/diff/
> 
> 
> Testing
> ---
> 
> Manual
> 
> 
> Thanks,
> 
> Madhan Reddy
> 
>

Re: Review Request 56015: Ambari upgrade to Ambari 2.5 causes start DB check failure on Zeppelin configs

2017-01-30 Thread Renjith Kamath 


> On Jan. 27, 2017, 6:41 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java,
> >  line 304
> > 
> >
> > Is this for all stack versions as long as zeppelin-env is present?

Yes, log4j and shiro configs were always in zeppelin-env for all stack version


- Renjith


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56015/#review163306
---


On Jan. 27, 2017, 12:43 p.m., Renjith Kamath wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56015/
> ---
> 
> (Updated Jan. 27, 2017, 12:43 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Jayush 
> Luniya, Prabhjyot Singh, Rohit Choudhary, Robert Levas, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-19740
> https://issues.apache.org/jira/browse/AMBARI-19740
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ambari upgrade to Ambari 2.5 causes start DB check failure on Zeppelin configs
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java
>  624e5a2 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java
>  bbda783 
> 
> Diff: https://reviews.apache.org/r/56015/diff/
> 
> 
> Testing
> ---
> 
> tested on centos
> 
> 
> Thanks,
> 
> Renjith Kamath
> 
>