[Impala-ASF-CR] [IMPALA-8435] Prohibit operations on full transactional table.
Csaba Ringhofer has posted comments on this change. (
http://gerrit.cloudera.org:8080/13253 )
Change subject: [IMPALA-8435] Prohibit operations on full transactional table.
..
Patch Set 3:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/13253/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/13253/2//COMMIT_MSG@7
PS2, Line 7: [IMPALA-8435]
> Impala commits use the following format most of the time:
ping :)
http://gerrit.cloudera.org:8080/#/c/13253/3/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java
File fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java:
http://gerrit.cloudera.org:8080/#/c/13253/3/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java@167
PS3, Line 167:
> I am having trouble finding out how to reply better to a comment here. But
I am ok with the current solution. Maybe we will find a nice way to abstract
requirements about a table in the future.
http://gerrit.cloudera.org:8080/#/c/13253/2/fe/src/test/java/org/apache/impala/analysis/AnalyzerTest.java
File fe/src/test/java/org/apache/impala/analysis/AnalyzerTest.java:
http://gerrit.cloudera.org:8080/#/c/13253/2/fe/src/test/java/org/apache/impala/analysis/AnalyzerTest.java@563
PS2, Line 563: AnalyzesOk("select * from
functional.insert_only_transactional_table");
:
> Done
The old duplicate statement are still here.
--
To view, visit http://gerrit.cloudera.org:8080/13253
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I542570e30afdd8351250236d1be0077a170dd4ab
Gerrit-Change-Number: 13253
Gerrit-PatchSet: 3
Gerrit-Owner: Sudhanshu Arora
Gerrit-Reviewer: Csaba Ringhofer
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Sudhanshu Arora
Gerrit-Reviewer: Todd Lipcon
Gerrit-Reviewer: Vihang Karajgaonkar
Gerrit-Reviewer: Yongzhi Chen
Gerrit-Comment-Date: Sat, 11 May 2019 15:38:57 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7665: Fix unwarranted query cancellation on statestore restart
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13061 ) Change subject: IMPALA-7665: Fix unwarranted query cancellation on statestore restart .. Patch Set 9: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/13061 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I30b68bd8bde4bf589d58d42d6f683afb166de959 Gerrit-Change-Number: 13061 Gerrit-PatchSet: 9 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Sat, 11 May 2019 06:20:31 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7665: Fix unwarranted query cancellation on statestore restart
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13061 ) Change subject: IMPALA-7665: Fix unwarranted query cancellation on statestore restart .. IMPALA-7665: Fix unwarranted query cancellation on statestore restart Currently, if the statestore restarts and disseminates an inconsistent view of cluster membership to the coordinators, then they might believe that the backends no longer in the membership update are down and would start canceling queries that are running or scheduled to run on those allegedly failed backends. This patch adds a grace period after statestore recovery/successful registration that give it enough time to gather a consistent state of the cluster. Testing: - Added an e2e test. - Did manual stress testing using concurrent_select.py with statestore_subscriber_timeout_seconds set to 2 secs and failed_backends_query_cancellation_grace_period_ms set to 5 seconds, and the statestore being restarted every 15 seconds. To avoid other effects of statestore restarts cropping up, I used a local catalog (catalog v2) and ignored query errors caused due to scheduler having an incomplete view of the cluster(no backends). Change-Id: I30b68bd8bde4bf589d58d42d6f683afb166de959 Reviewed-on: http://gerrit.cloudera.org:8080/13061 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M be/src/service/impala-server.cc M be/src/statestore/statestore-subscriber.cc M be/src/statestore/statestore-subscriber.h M tests/custom_cluster/test_restart_services.py 4 files changed, 91 insertions(+), 2 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/13061 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I30b68bd8bde4bf589d58d42d6f683afb166de959 Gerrit-Change-Number: 13061 Gerrit-PatchSet: 10 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Tim Armstrong
