[Impala-ASF-CR] IMPALA-8907: TestResultSpooling.test slow query is flaky
Sahil Takiar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14170 Change subject: IMPALA-8907: TestResultSpooling.test_slow_query is flaky .. IMPALA-8907: TestResultSpooling.test_slow_query is flaky De-flake test_result_spooling.py::TestResultsSpooling::test_slow_query by increasing the delay in RowBatch production. This patch makes two fixes to ensure that RowBatchGetWaitTime is a non-zero value: * Add the DELAY DEBUG_ACTION to the SCAN_NODE rather than the EXCHANGE_NODE. Since the EXCHANGE_NODE only processes a few rows, adding the delay to the SCAN_NODE decreases the rate at which results are produced. * Wait for all rows to be fetched before checking if RowBatchGetWaitTime is in the profile. This fixes a possible race condition where the fetch thread was not able to issue the fetch RPC before the test checked if RowBatchGetWaitTime was in the runtime profile. Testing: * Looped test_slow_query for several hours with 0 failures Change-Id: Idcb4a6b38f85a9497f80e2674e1c1fa512be5940 --- M tests/query_test/test_result_spooling.py 1 file changed, 4 insertions(+), 3 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/70/14170/1 -- To view, visit http://gerrit.cloudera.org:8080/14170 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Idcb4a6b38f85a9497f80e2674e1c1fa512be5940 Gerrit-Change-Number: 14170 Gerrit-PatchSet: 1 Gerrit-Owner: Sahil Takiar
[Impala-ASF-CR] IMPALA-8907: TestResultSpooling.test slow query is flaky
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14170 ) Change subject: IMPALA-8907: TestResultSpooling.test_slow_query is flaky .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/4450/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/14170 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idcb4a6b38f85a9497f80e2674e1c1fa512be5940 Gerrit-Change-Number: 14170 Gerrit-PatchSet: 1 Gerrit-Owner: Sahil Takiar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Comment-Date: Mon, 02 Sep 2019 23:59:44 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8907: TestResultSpooling.test slow query is flaky
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14170 ) Change subject: IMPALA-8907: TestResultSpooling.test_slow_query is flaky .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/14170 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idcb4a6b38f85a9497f80e2674e1c1fa512be5940 Gerrit-Change-Number: 14170 Gerrit-PatchSet: 1 Gerrit-Owner: Sahil Takiar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Comment-Date: Wed, 04 Sep 2019 19:23:00 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8907: TestResultSpooling.test slow query is flaky
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14170 ) Change subject: IMPALA-8907: TestResultSpooling.test_slow_query is flaky .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/14170 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idcb4a6b38f85a9497f80e2674e1c1fa512be5940 Gerrit-Change-Number: 14170 Gerrit-PatchSet: 2 Gerrit-Owner: Sahil Takiar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Comment-Date: Wed, 04 Sep 2019 22:21:47 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8907: TestResultSpooling.test slow query is flaky
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14170 ) Change subject: IMPALA-8907: TestResultSpooling.test_slow_query is flaky .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4880/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/14170 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idcb4a6b38f85a9497f80e2674e1c1fa512be5940 Gerrit-Change-Number: 14170 Gerrit-PatchSet: 2 Gerrit-Owner: Sahil Takiar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Comment-Date: Wed, 04 Sep 2019 22:21:48 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8907: TestResultSpooling.test slow query is flaky
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14170 ) Change subject: IMPALA-8907: TestResultSpooling.test_slow_query is flaky .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/14170 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idcb4a6b38f85a9497f80e2674e1c1fa512be5940 Gerrit-Change-Number: 14170 Gerrit-PatchSet: 2 Gerrit-Owner: Sahil Takiar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Comment-Date: Thu, 05 Sep 2019 02:27:51 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8907: TestResultSpooling.test slow query is flaky
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14170 ) Change subject: IMPALA-8907: TestResultSpooling.test_slow_query is flaky .. IMPALA-8907: TestResultSpooling.test_slow_query is flaky De-flake test_result_spooling.py::TestResultsSpooling::test_slow_query by increasing the delay in RowBatch production. This patch makes two fixes to ensure that RowBatchGetWaitTime is a non-zero value: * Add the DELAY DEBUG_ACTION to the SCAN_NODE rather than the EXCHANGE_NODE. Since the EXCHANGE_NODE only processes a few rows, adding the delay to the SCAN_NODE decreases the rate at which results are produced. * Wait for all rows to be fetched before checking if RowBatchGetWaitTime is in the profile. This fixes a possible race condition where the fetch thread was not able to issue the fetch RPC before the test checked if RowBatchGetWaitTime was in the runtime profile. Testing: * Looped test_slow_query for several hours with 0 failures Change-Id: Idcb4a6b38f85a9497f80e2674e1c1fa512be5940 Reviewed-on: http://gerrit.cloudera.org:8080/14170 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M tests/query_test/test_result_spooling.py 1 file changed, 4 insertions(+), 3 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/14170 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Idcb4a6b38f85a9497f80e2674e1c1fa512be5940 Gerrit-Change-Number: 14170 Gerrit-PatchSet: 3 Gerrit-Owner: Sahil Takiar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho