[Impala-ASF-CR] IMPALA-11862: [DOCS] Document the default value of --ssl cipher list.

2023-01-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/19447 )

Change subject: IMPALA-11862: [DOCS] Document the default value of 
--ssl_cipher_list.
..

IMPALA-11862: [DOCS] Document the default value of --ssl_cipher_list.

Since IMPALA-11240 the default value of ssl_cipher_list is not empty.
Update the docs to cover this change.

TESTING:
- Built docs locally.

Change-Id: I000fbb5bd37f52b85afe3855852875360b55ccfa
Reviewed-on: http://gerrit.cloudera.org:8080/19447
Reviewed-by: Impala Public Jenkins 
Tested-by: Impala Public Jenkins 
---
M docs/topics/impala_ssl.xml
1 file changed, 6 insertions(+), 2 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

--
To view, visit http://gerrit.cloudera.org:8080/19447
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I000fbb5bd37f52b85afe3855852875360b55ccfa
Gerrit-Change-Number: 19447
Gerrit-PatchSet: 4
Gerrit-Owner: Andrew Sherman 
Gerrit-Reviewer: Andrew Sherman 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Michael Smith 


[Impala-ASF-CR] IMPALA-11862: [DOCS] Document the default value of --ssl cipher list.

2023-01-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19447 )

Change subject: IMPALA-11862: [DOCS] Document the default value of 
--ssl_cipher_list.
..


Patch Set 3: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/19447
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I000fbb5bd37f52b85afe3855852875360b55ccfa
Gerrit-Change-Number: 19447
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Sherman 
Gerrit-Reviewer: Andrew Sherman 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Michael Smith 
Gerrit-Comment-Date: Tue, 31 Jan 2023 00:32:54 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-11862: [DOCS] Document the default value of --ssl cipher list.

2023-01-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19447 )

Change subject: IMPALA-11862: [DOCS] Document the default value of 
--ssl_cipher_list.
..


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-docs-submit/380/ 
DRY_RUN=false


--
To view, visit http://gerrit.cloudera.org:8080/19447
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I000fbb5bd37f52b85afe3855852875360b55ccfa
Gerrit-Change-Number: 19447
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Sherman 
Gerrit-Reviewer: Andrew Sherman 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Michael Smith 
Gerrit-Comment-Date: Tue, 31 Jan 2023 00:24:19 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-11862: [DOCS] Document the default value of --ssl cipher list.

2023-01-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19447 )

Change subject: IMPALA-11862: [DOCS] Document the default value of 
--ssl_cipher_list.
..


Patch Set 3: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/19447
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I000fbb5bd37f52b85afe3855852875360b55ccfa
Gerrit-Change-Number: 19447
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Sherman 
Gerrit-Reviewer: Andrew Sherman 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Michael Smith 
Gerrit-Comment-Date: Tue, 31 Jan 2023 00:24:18 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-11862: [DOCS] Document the default value of --ssl cipher list.

2023-01-30 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19447 )

Change subject: IMPALA-11862: [DOCS] Document the default value of 
--ssl_cipher_list.
..


Patch Set 2: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/19447
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I000fbb5bd37f52b85afe3855852875360b55ccfa
Gerrit-Change-Number: 19447
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Sherman 
Gerrit-Reviewer: Andrew Sherman 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Michael Smith 
Gerrit-Comment-Date: Tue, 31 Jan 2023 00:13:07 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-11862: [DOCS] Document the default value of --ssl cipher list.

2023-01-30 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19447 )

Change subject: IMPALA-11862: [DOCS] Document the default value of 
--ssl_cipher_list.
..


Patch Set 2: Code-Review+1


--
To view, visit http://gerrit.cloudera.org:8080/19447
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I000fbb5bd37f52b85afe3855852875360b55ccfa
Gerrit-Change-Number: 19447
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Sherman 
Gerrit-Reviewer: Andrew Sherman 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Michael Smith 
Gerrit-Comment-Date: Mon, 30 Jan 2023 22:32:08 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-11862: [DOCS] Document the default value of --ssl cipher list.

2023-01-30 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19447 )

Change subject: IMPALA-11862: [DOCS] Document the default value of 
--ssl_cipher_list.
..


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/19447/2/docs/topics/impala_ssl.xml
File docs/topics/impala_ssl.xml:

http://gerrit.cloudera.org:8080/#/c/19447/2/docs/topics/impala_ssl.xml@206
PS2, Line 206: from https://wiki.mozilla.org/Security/Server_Side_TLS.
> These seem like they could change over time. Do we have a way to track that
Yes it's a moving target.
I did think of saying "look in the source code to see the current list" but 
that's a bit... presumptive?
Mostly I wanted to get the docs closer to reality.



--
To view, visit http://gerrit.cloudera.org:8080/19447
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I000fbb5bd37f52b85afe3855852875360b55ccfa
Gerrit-Change-Number: 19447
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Sherman 
Gerrit-Reviewer: Andrew Sherman 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Michael Smith 
Gerrit-Comment-Date: Mon, 30 Jan 2023 22:31:27 +
Gerrit-HasComments: Yes


[Impala-ASF-CR] IMPALA-11862: [DOCS] Document the default value of --ssl cipher list.

2023-01-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19447 )

Change subject: IMPALA-11862: [DOCS] Document the default value of 
--ssl_cipher_list.
..


Patch Set 2: Verified+1

Build Successful 

https://jenkins.impala.io/job/gerrit-docs-auto-test/695/ : Doc tests passed.


--
To view, visit http://gerrit.cloudera.org:8080/19447
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I000fbb5bd37f52b85afe3855852875360b55ccfa
Gerrit-Change-Number: 19447
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Sherman 
Gerrit-Reviewer: Andrew Sherman 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Michael Smith 
Gerrit-Comment-Date: Mon, 30 Jan 2023 22:26:16 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-11862: [DOCS] Document the default value of --ssl cipher list.

2023-01-30 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19447 )

Change subject: IMPALA-11862: [DOCS] Document the default value of 
--ssl_cipher_list.
..


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/19447/2/docs/topics/impala_ssl.xml
File docs/topics/impala_ssl.xml:

http://gerrit.cloudera.org:8080/#/c/19447/2/docs/topics/impala_ssl.xml@206
PS2, Line 206: from https://wiki.mozilla.org/Security/Server_Side_TLS.
These seem like they could change over time. Do we have a way to track that?



--
To view, visit http://gerrit.cloudera.org:8080/19447
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I000fbb5bd37f52b85afe3855852875360b55ccfa
Gerrit-Change-Number: 19447
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Sherman 
Gerrit-Reviewer: Andrew Sherman 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Michael Smith 
Gerrit-Comment-Date: Mon, 30 Jan 2023 22:20:29 +
Gerrit-HasComments: Yes


[Impala-ASF-CR] IMPALA-11862: [DOCS] Document the default value of --ssl cipher list.

2023-01-30 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19447 )

Change subject: IMPALA-11862: [DOCS] Document the default value of 
--ssl_cipher_list.
..


Patch Set 2:

(2 comments)

Thanks for comments

http://gerrit.cloudera.org:8080/#/c/19447/1/docs/topics/impala_ssl.xml
File docs/topics/impala_ssl.xml:

http://gerrit.cloudera.org:8080/#/c/19447/1/docs/topics/impala_ssl.xml@204
PS1, Line 204: 
> https://gerrit.cloudera.org/c/19448/2/docs/impala_keydefs.ditamap is also d
Thanks


http://gerrit.cloudera.org:8080/#/c/19447/1/docs/topics/impala_ssl.xml@204
PS1, Line 204: 
> Can we create a new key for impala 4.2 in impala_keydefs.ditamap and use th
Done



--
To view, visit http://gerrit.cloudera.org:8080/19447
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I000fbb5bd37f52b85afe3855852875360b55ccfa
Gerrit-Change-Number: 19447
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Sherman 
Gerrit-Reviewer: Andrew Sherman 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Michael Smith 
Gerrit-Comment-Date: Mon, 30 Jan 2023 22:17:44 +
Gerrit-HasComments: Yes


[Impala-ASF-CR] IMPALA-11862: [DOCS] Document the default value of --ssl cipher list.

2023-01-30 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#2). ( 
http://gerrit.cloudera.org:8080/19447 )

Change subject: IMPALA-11862: [DOCS] Document the default value of 
--ssl_cipher_list.
..

IMPALA-11862: [DOCS] Document the default value of --ssl_cipher_list.

Since IMPALA-11240 the default value of ssl_cipher_list is not empty.
Update the docs to cover this change.

TESTING:
- Built docs locally.

Change-Id: I000fbb5bd37f52b85afe3855852875360b55ccfa
---
M docs/topics/impala_ssl.xml
1 file changed, 6 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/47/19447/2
--
To view, visit http://gerrit.cloudera.org:8080/19447
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I000fbb5bd37f52b85afe3855852875360b55ccfa
Gerrit-Change-Number: 19447
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Sherman 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Michael Smith 


[Impala-ASF-CR] IMPALA-11862: [DOCS] Document the default value of --ssl cipher list.

2023-01-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19447 )

Change subject: IMPALA-11862: [DOCS] Document the default value of 
--ssl_cipher_list.
..


Patch Set 2:

Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/695/

Testing docs change - this change appears to modify docs/ and no code. This is 
experimental - please report any issues to tarmstr...@cloudera.com or on this 
JIRA: IMPALA-7317


--
To view, visit http://gerrit.cloudera.org:8080/19447
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I000fbb5bd37f52b85afe3855852875360b55ccfa
Gerrit-Change-Number: 19447
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Sherman 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Michael Smith 
Gerrit-Comment-Date: Mon, 30 Jan 2023 22:17:44 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-11862: [DOCS] Document the default value of --ssl cipher list.

2023-01-30 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19447 )

Change subject: IMPALA-11862: [DOCS] Document the default value of 
--ssl_cipher_list.
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/19447/1/docs/topics/impala_ssl.xml
File docs/topics/impala_ssl.xml:

http://gerrit.cloudera.org:8080/#/c/19447/1/docs/topics/impala_ssl.xml@204
PS1, Line 204: 
> Can we create a new key for impala 4.2 in impala_keydefs.ditamap and use th
https://gerrit.cloudera.org/c/19448/2/docs/impala_keydefs.ditamap is also doing 
this if you want to copy it.



--
To view, visit http://gerrit.cloudera.org:8080/19447
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I000fbb5bd37f52b85afe3855852875360b55ccfa
Gerrit-Change-Number: 19447
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Sherman 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Michael Smith 
Gerrit-Comment-Date: Mon, 30 Jan 2023 21:21:28 +
Gerrit-HasComments: Yes


[Impala-ASF-CR] IMPALA-11862: [DOCS] Document the default value of --ssl cipher list.

2023-01-30 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19447 )

Change subject: IMPALA-11862: [DOCS] Document the default value of 
--ssl_cipher_list.
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/19447/1/docs/topics/impala_ssl.xml
File docs/topics/impala_ssl.xml:

http://gerrit.cloudera.org:8080/#/c/19447/1/docs/topics/impala_ssl.xml@204
PS1, Line 204: 
Can we create a new key for impala 4.2 in impala_keydefs.ditamap and use that?



--
To view, visit http://gerrit.cloudera.org:8080/19447
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I000fbb5bd37f52b85afe3855852875360b55ccfa
Gerrit-Change-Number: 19447
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Sherman 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Comment-Date: Mon, 30 Jan 2023 20:37:51 +
Gerrit-HasComments: Yes


[Impala-ASF-CR] IMPALA-11862: [DOCS] Document the default value of --ssl cipher list.

2023-01-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19447 )

Change subject: IMPALA-11862: [DOCS] Document the default value of 
--ssl_cipher_list.
..


Patch Set 1: Verified+1

Build Successful 

https://jenkins.impala.io/job/gerrit-docs-auto-test/692/ : Doc tests passed.


--
To view, visit http://gerrit.cloudera.org:8080/19447
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I000fbb5bd37f52b85afe3855852875360b55ccfa
Gerrit-Change-Number: 19447
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Sherman 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Comment-Date: Fri, 27 Jan 2023 20:01:36 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-11862: [DOCS] Document the default value of --ssl cipher list.

2023-01-27 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/19447


Change subject: IMPALA-11862: [DOCS] Document the default value of 
--ssl_cipher_list.
..

IMPALA-11862: [DOCS] Document the default value of --ssl_cipher_list.

Since IMPALA-11240 the default value of ssl_cipher_list is not empty.
Update the docs to cover this change.

TESTING:
- Built docs locally.

Change-Id: I000fbb5bd37f52b85afe3855852875360b55ccfa
---
M docs/topics/impala_ssl.xml
1 file changed, 6 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/47/19447/1
--
To view, visit http://gerrit.cloudera.org:8080/19447
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I000fbb5bd37f52b85afe3855852875360b55ccfa
Gerrit-Change-Number: 19447
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Sherman 


[Impala-ASF-CR] IMPALA-11862: [DOCS] Document the default value of --ssl cipher list.

2023-01-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19447 )

Change subject: IMPALA-11862: [DOCS] Document the default value of 
--ssl_cipher_list.
..


Patch Set 1:

Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/692/

Testing docs change - this change appears to modify docs/ and no code. This is 
experimental - please report any issues to tarmstr...@cloudera.com or on this 
JIRA: IMPALA-7317


--
To view, visit http://gerrit.cloudera.org:8080/19447
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I000fbb5bd37f52b85afe3855852875360b55ccfa
Gerrit-Change-Number: 19447
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Sherman 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Fri, 27 Jan 2023 19:53:06 +
Gerrit-HasComments: No