[Impala-ASF-CR] IMPALA-8369 (part 3): Hive 3: fix test permanent udfs.py for Hive 3 support

2019-05-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13236 )

Change subject: IMPALA-8369 (part 3): Hive 3: fix test_permanent_udfs.py for 
Hive 3 support
..


Patch Set 7: Code-Review+2

Forwarding +2 after rebases


--
To view, visit http://gerrit.cloudera.org:8080/13236
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f50845c7d4769d8843cad87988498e165902169
Gerrit-Change-Number: 13236
Gerrit-PatchSet: 7
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Sudhanshu Arora 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Reviewer: Yongzhi Chen 
Gerrit-Comment-Date: Wed, 15 May 2019 02:11:17 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8369 (part 3): Hive 3: fix test permanent udfs.py for Hive 3 support

2019-05-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/13236 )

Change subject: IMPALA-8369 (part 3): Hive 3: fix test_permanent_udfs.py for 
Hive 3 support
..

IMPALA-8369 (part 3): Hive 3: fix test_permanent_udfs.py for Hive 3 support

This fixes two issues in test_permanent_udfs.py:

- two of Hive's built-ins were ported to the new GenericUDF interface
  which Impala can't execute. These UDFs are now excluded from the test
  when running with Hive 3.

- The 'hive' commandline is deprecated nowadays, so the test now uses
  the standard HS2 approach to run Hive queries. Hive 2+ caches UDFs, so
  now that we are connecting to an already-running HS2 rather than
  starting a new standalone 'hive' command, we need to explicitly
  invalidate that cache by using 'RELOAD FUNCTION' after making changes
  to UDFs in Impala.

Change-Id: I7f50845c7d4769d8843cad87988498e165902169
Reviewed-on: http://gerrit.cloudera.org:8080/13236
Tested-by: Impala Public Jenkins 
Reviewed-by: Todd Lipcon 
---
M tests/common/impala_test_suite.py
M tests/custom_cluster/test_permanent_udfs.py
2 files changed, 27 insertions(+), 34 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Todd Lipcon: Looks good to me, approved

--
To view, visit http://gerrit.cloudera.org:8080/13236
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I7f50845c7d4769d8843cad87988498e165902169
Gerrit-Change-Number: 13236
Gerrit-PatchSet: 8
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Sudhanshu Arora 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Reviewer: Yongzhi Chen 


[Impala-ASF-CR] IMPALA-8369 (part 3): Hive 3: fix test permanent udfs.py for Hive 3 support

2019-05-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13236 )

Change subject: IMPALA-8369 (part 3): Hive 3: fix test_permanent_udfs.py for 
Hive 3 support
..


Patch Set 7: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/13236
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f50845c7d4769d8843cad87988498e165902169
Gerrit-Change-Number: 13236
Gerrit-PatchSet: 7
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Sudhanshu Arora 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Reviewer: Yongzhi Chen 
Gerrit-Comment-Date: Tue, 14 May 2019 02:58:25 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8369 (part 3): Hive 3: fix test permanent udfs.py for Hive 3 support

2019-05-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13236 )

Change subject: IMPALA-8369 (part 3): Hive 3: fix test_permanent_udfs.py for 
Hive 3 support
..


Patch Set 7:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4243/ 
DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/13236
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f50845c7d4769d8843cad87988498e165902169
Gerrit-Change-Number: 13236
Gerrit-PatchSet: 7
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Sudhanshu Arora 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Reviewer: Yongzhi Chen 
Gerrit-Comment-Date: Mon, 13 May 2019 21:52:33 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8369 (part 3): Hive 3: fix test permanent udfs.py for Hive 3 support

2019-05-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13236 )

Change subject: IMPALA-8369 (part 3): Hive 3: fix test_permanent_udfs.py for 
Hive 3 support
..


Patch Set 6: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/4218/


--
To view, visit http://gerrit.cloudera.org:8080/13236
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f50845c7d4769d8843cad87988498e165902169
Gerrit-Change-Number: 13236
Gerrit-PatchSet: 6
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Sudhanshu Arora 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Reviewer: Yongzhi Chen 
Gerrit-Comment-Date: Fri, 10 May 2019 02:28:50 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8369 (part 3): Hive 3: fix test permanent udfs.py for Hive 3 support

2019-05-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13236 )

Change subject: IMPALA-8369 (part 3): Hive 3: fix test_permanent_udfs.py for 
Hive 3 support
..


Patch Set 6:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4218/ 
DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/13236
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f50845c7d4769d8843cad87988498e165902169
Gerrit-Change-Number: 13236
Gerrit-PatchSet: 6
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Sudhanshu Arora 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Reviewer: Yongzhi Chen 
Gerrit-Comment-Date: Thu, 09 May 2019 23:15:08 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8369 (part 3): Hive 3: fix test permanent udfs.py for Hive 3 support

2019-05-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13236 )

Change subject: IMPALA-8369 (part 3): Hive 3: fix test_permanent_udfs.py for 
Hive 3 support
..


Patch Set 5:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/3109/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/13236
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f50845c7d4769d8843cad87988498e165902169
Gerrit-Change-Number: 13236
Gerrit-PatchSet: 5
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Sudhanshu Arora 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Reviewer: Yongzhi Chen 
Gerrit-Comment-Date: Tue, 07 May 2019 20:24:05 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8369 (part 3): Hive 3: fix test permanent udfs.py for Hive 3 support

2019-05-07 Thread Todd Lipcon (Code Review)
Hello Yongzhi Chen, Vihang Karajgaonkar, Sudhanshu Arora, Csaba Ringhofer, 
Impala Public Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/13236

to look at the new patch set (#5).

Change subject: IMPALA-8369 (part 3): Hive 3: fix test_permanent_udfs.py for 
Hive 3 support
..

IMPALA-8369 (part 3): Hive 3: fix test_permanent_udfs.py for Hive 3 support

This fixes two issues in test_permanent_udfs.py:

- two of Hive's built-ins were ported to the new GenericUDF interface
  which Impala can't execute. These UDFs are now excluded from the test
  when running with Hive 3.

- The 'hive' commandline is deprecated nowadays, so the test now uses
  the standard HS2 approach to run Hive queries. Hive 2+ caches UDFs, so
  now that we are connecting to an already-running HS2 rather than
  starting a new standalone 'hive' command, we need to explicitly
  invalidate that cache by using 'RELOAD FUNCTION' after making changes
  to UDFs in Impala.

Change-Id: I7f50845c7d4769d8843cad87988498e165902169
---
M tests/common/impala_test_suite.py
M tests/custom_cluster/test_permanent_udfs.py
2 files changed, 27 insertions(+), 34 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/36/13236/5
--
To view, visit http://gerrit.cloudera.org:8080/13236
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7f50845c7d4769d8843cad87988498e165902169
Gerrit-Change-Number: 13236
Gerrit-PatchSet: 5
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Sudhanshu Arora 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Reviewer: Yongzhi Chen 


[Impala-ASF-CR] IMPALA-8369 (part 3): Hive 3: fix test permanent udfs.py for Hive 3 support

2019-05-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13236 )

Change subject: IMPALA-8369 (part 3): Hive 3: fix test_permanent_udfs.py for 
Hive 3 support
..


Patch Set 4: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/4165/


--
To view, visit http://gerrit.cloudera.org:8080/13236
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f50845c7d4769d8843cad87988498e165902169
Gerrit-Change-Number: 13236
Gerrit-PatchSet: 4
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Sudhanshu Arora 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Reviewer: Yongzhi Chen 
Gerrit-Comment-Date: Tue, 07 May 2019 17:50:22 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8369 (part 3): Hive 3: fix test permanent udfs.py for Hive 3 support

2019-05-07 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13236 )

Change subject: IMPALA-8369 (part 3): Hive 3: fix test_permanent_udfs.py for 
Hive 3 support
..


Patch Set 4: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/13236
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f50845c7d4769d8843cad87988498e165902169
Gerrit-Change-Number: 13236
Gerrit-PatchSet: 4
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Sudhanshu Arora 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Reviewer: Yongzhi Chen 
Gerrit-Comment-Date: Tue, 07 May 2019 10:02:38 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8369 (part 3): Hive 3: fix test permanent udfs.py for Hive 3 support

2019-05-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13236 )

Change subject: IMPALA-8369 (part 3): Hive 3: fix test_permanent_udfs.py for 
Hive 3 support
..


Patch Set 4:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/3098/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/13236
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f50845c7d4769d8843cad87988498e165902169
Gerrit-Change-Number: 13236
Gerrit-PatchSet: 4
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Sudhanshu Arora 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Reviewer: Yongzhi Chen 
Gerrit-Comment-Date: Tue, 07 May 2019 08:33:44 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8369 (part 3): Hive 3: fix test permanent udfs.py for Hive 3 support

2019-05-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13236 )

Change subject: IMPALA-8369 (part 3): Hive 3: fix test_permanent_udfs.py for 
Hive 3 support
..


Patch Set 4:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4165/ 
DRY_RUN=true


--
To view, visit http://gerrit.cloudera.org:8080/13236
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f50845c7d4769d8843cad87988498e165902169
Gerrit-Change-Number: 13236
Gerrit-PatchSet: 4
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Sudhanshu Arora 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Reviewer: Yongzhi Chen 
Gerrit-Comment-Date: Tue, 07 May 2019 07:50:20 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8369 (part 3): Hive 3: fix test permanent udfs.py for Hive 3 support

2019-05-07 Thread Todd Lipcon (Code Review)
Hello Yongzhi Chen, Vihang Karajgaonkar, Sudhanshu Arora, Csaba Ringhofer, 
Impala Public Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/13236

to look at the new patch set (#4).

Change subject: IMPALA-8369 (part 3): Hive 3: fix test_permanent_udfs.py for 
Hive 3 support
..

IMPALA-8369 (part 3): Hive 3: fix test_permanent_udfs.py for Hive 3 support

This fixes two issues in test_permanent_udfs.py:

- two of Hive's built-ins were ported to the new GenericUDF interface
  which Impala can't execute. These UDFs are now excluded from the test
  when running with Hive 3.

- Hive 3 now caches UDFs more aggressively, so we have to run 'RELOAD
  FUNCTION' in Hive after changing UDFs in Impala.

Change-Id: I7f50845c7d4769d8843cad87988498e165902169
---
M tests/common/impala_test_suite.py
M tests/custom_cluster/test_permanent_udfs.py
2 files changed, 30 insertions(+), 34 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/36/13236/4
--
To view, visit http://gerrit.cloudera.org:8080/13236
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7f50845c7d4769d8843cad87988498e165902169
Gerrit-Change-Number: 13236
Gerrit-PatchSet: 4
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Sudhanshu Arora 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Reviewer: Yongzhi Chen 


[Impala-ASF-CR] IMPALA-8369 (part 3): Hive 3: fix test permanent udfs.py for Hive 3 support

2019-05-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13236 )

Change subject: IMPALA-8369 (part 3): Hive 3: fix test_permanent_udfs.py for 
Hive 3 support
..


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/13236/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/13236/2//COMMIT_MSG@16
PS2, Line 16:  This function also
:   exists in Hive 2, so while it isn't necessary, I didn't bother 
to make
:   it conditional on version
> The comment should be also updated.
Done



--
To view, visit http://gerrit.cloudera.org:8080/13236
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f50845c7d4769d8843cad87988498e165902169
Gerrit-Change-Number: 13236
Gerrit-PatchSet: 3
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Sudhanshu Arora 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Reviewer: Yongzhi Chen 
Gerrit-Comment-Date: Tue, 07 May 2019 07:47:30 +
Gerrit-HasComments: Yes


[Impala-ASF-CR] IMPALA-8369 (part 3): Hive 3: fix test permanent udfs.py for Hive 3 support

2019-05-06 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13236 )

Change subject: IMPALA-8369 (part 3): Hive 3: fix test_permanent_udfs.py for 
Hive 3 support
..


Patch Set 3: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/13236/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/13236/2//COMMIT_MSG@16
PS2, Line 16:  This function also
:   exists in Hive 2, so while it isn't necessary, I didn't bother 
to make
:   it conditional on version
> Done
The comment should be also updated.



--
To view, visit http://gerrit.cloudera.org:8080/13236
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f50845c7d4769d8843cad87988498e165902169
Gerrit-Change-Number: 13236
Gerrit-PatchSet: 3
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Sudhanshu Arora 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Reviewer: Yongzhi Chen 
Gerrit-Comment-Date: Tue, 07 May 2019 00:01:01 +
Gerrit-HasComments: Yes


[Impala-ASF-CR] IMPALA-8369 (part 3): Hive 3: fix test permanent udfs.py for Hive 3 support

2019-05-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13236 )

Change subject: IMPALA-8369 (part 3): Hive 3: fix test_permanent_udfs.py for 
Hive 3 support
..


Patch Set 3:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/3091/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/13236
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f50845c7d4769d8843cad87988498e165902169
Gerrit-Change-Number: 13236
Gerrit-PatchSet: 3
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Sudhanshu Arora 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Reviewer: Yongzhi Chen 
Gerrit-Comment-Date: Mon, 06 May 2019 23:52:32 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8369 (part 3): Hive 3: fix test permanent udfs.py for Hive 3 support

2019-05-06 Thread Todd Lipcon (Code Review)
Hello Yongzhi Chen, Vihang Karajgaonkar, Sudhanshu Arora, Csaba Ringhofer, 
Impala Public Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/13236

to look at the new patch set (#3).

Change subject: IMPALA-8369 (part 3): Hive 3: fix test_permanent_udfs.py for 
Hive 3 support
..

IMPALA-8369 (part 3): Hive 3: fix test_permanent_udfs.py for Hive 3 support

This fixes two issues in test_permanent_udfs.py:

- two of Hive's built-ins were ported to the new GenericUDF interface
  which Impala can't execute. These UDFs are now excluded from the test
  when running with Hive 3.

- Hive 3 now caches UDFs more aggressively, so we have to run 'RELOAD
  FUNCTION' in Hive after changing UDFs in Impala. This function also
  exists in Hive 2, so while it isn't necessary, I didn't bother to make
  it conditional on version.

Change-Id: I7f50845c7d4769d8843cad87988498e165902169
---
M tests/common/impala_test_suite.py
M tests/custom_cluster/test_permanent_udfs.py
2 files changed, 30 insertions(+), 34 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/36/13236/3
--
To view, visit http://gerrit.cloudera.org:8080/13236
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7f50845c7d4769d8843cad87988498e165902169
Gerrit-Change-Number: 13236
Gerrit-PatchSet: 3
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Sudhanshu Arora 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Reviewer: Yongzhi Chen