[kudu-CR] [kudu-jepsen] added more info on troubleshooting

[Alexey Serbin (Code Review)]

Alexey Serbin has submitted this change and it was merged.

Change subject: [kudu-jepsen] added more info on troubleshooting
..


[kudu-jepsen] added more info on troubleshooting

Added more information on distinguishing 'errors' from 'failures' in the
kudu-jepsen test output.

Change-Id: I9b97b744d969b73ede2fcb7a3509915b130c655b
Reviewed-on: http://gerrit.cloudera.org:8080/6774
Tested-by: Kudu Jenkins
Reviewed-by: David Ribeiro Alves 
---
M java/kudu-jepsen/README.adoc
1 file changed, 30 insertions(+), 7 deletions(-)

Approvals:
  David Ribeiro Alves: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/6774
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9b97b744d969b73ede2fcb7a3509915b130c655b
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] [kudu-jepsen] added more info on troubleshooting

[David Ribeiro Alves (Code Review)]

David Ribeiro Alves has posted comments on this change.

Change subject: [kudu-jepsen] added more info on troubleshooting
..


Patch Set 5: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/6774
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9b97b744d969b73ede2fcb7a3509915b130c655b
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] [kudu-jepsen] added more info on troubleshooting

[Alexey Serbin (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/6774

to look at the new patch set (#5).

Change subject: [kudu-jepsen] added more info on troubleshooting
..

[kudu-jepsen] added more info on troubleshooting

Added more information on distinguishing 'errors' from 'failures' in the
kudu-jepsen test output.

Change-Id: I9b97b744d969b73ede2fcb7a3509915b130c655b
---
M java/kudu-jepsen/README.adoc
1 file changed, 30 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/74/6774/5
-- 
To view, visit http://gerrit.cloudera.org:8080/6774
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9b97b744d969b73ede2fcb7a3509915b130c655b
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] [kudu-jepsen] added more info on troubleshooting

[Alexey Serbin (Code Review)]

Alexey Serbin has posted comments on this change.

Change subject: [kudu-jepsen] added more info on troubleshooting
..


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/6774/4/java/kudu-jepsen/README.adoc
File java/kudu-jepsen/README.adoc:

PS4, Line 124: ,
> or
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/6774
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9b97b744d969b73ede2fcb7a3509915b130c655b
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

[kudu-CR] [kudu-jepsen] added more info on troubleshooting

[David Ribeiro Alves (Code Review)]

David Ribeiro Alves has posted comments on this change.

Change subject: [kudu-jepsen] added more info on troubleshooting
..


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/6774/4/java/kudu-jepsen/README.adoc
File java/kudu-jepsen/README.adoc:

PS4, Line 124: ,
or


-- 
To view, visit http://gerrit.cloudera.org:8080/6774
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9b97b744d969b73ede2fcb7a3509915b130c655b
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

[kudu-CR] [kudu-jepsen] added more info on troubleshooting

[Alexey Serbin (Code Review)]

Alexey Serbin has posted comments on this change.

Change subject: [kudu-jepsen] added more info on troubleshooting
..


Patch Set 3:

(9 comments)

http://gerrit.cloudera.org:8080/#/c/6774/3/java/kudu-jepsen/README.adoc
File java/kudu-jepsen/README.adoc:

PS3, Line 105: The happiness is when Jepsen's analysis finds the history of 
operations
 : consistent for each test. If that happens, the following is 
output in the end
 : of a test:
> this reads weird. how about:
Done


PS3, Line 113: why Jepsen
 : was not happy about the run.
> replace with: why the test failed.
Done


PS3, Line 120: other
 :   errors reported by
> replace with: or in any of the
Done


PS3, Line 125:  or
> nit: replace this "or" with a comma
Done


PS3, Line 129: issues like that
> replace with: "errors in 10 tests ran"
Done


PS3, Line 139: manifestations
> "a manifestation"
Done


PS3, Line 140: These are
> This is...
Done


PS3, Line 141: on 
> remove
Done


PS3, Line 149: it outputs something like the following
 : into the log:
> nit: it would be good to keep the first sentence consistent with this one.
I replaced the whole sentence with:

If Jepsen's analysis finds non-linearizable history of operations, it outputs 
the following in the end of a test:


-- 
To view, visit http://gerrit.cloudera.org:8080/6774
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9b97b744d969b73ede2fcb7a3509915b130c655b
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

[kudu-CR] [kudu-jepsen] added more info on troubleshooting

[Alexey Serbin (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/6774

to look at the new patch set (#4).

Change subject: [kudu-jepsen] added more info on troubleshooting
..

[kudu-jepsen] added more info on troubleshooting

Added more information on distinguishing 'errors' from 'failures' in the
kudu-jepsen test output.

Change-Id: I9b97b744d969b73ede2fcb7a3509915b130c655b
---
M java/kudu-jepsen/README.adoc
1 file changed, 30 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/74/6774/4
-- 
To view, visit http://gerrit.cloudera.org:8080/6774
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9b97b744d969b73ede2fcb7a3509915b130c655b
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] [kudu-jepsen] added more info on troubleshooting

[David Ribeiro Alves (Code Review)]

David Ribeiro Alves has posted comments on this change.

Change subject: [kudu-jepsen] added more info on troubleshooting
..


Patch Set 3:

(9 comments)

http://gerrit.cloudera.org:8080/#/c/6774/3/java/kudu-jepsen/README.adoc
File java/kudu-jepsen/README.adoc:

PS3, Line 105: The happiness is when Jepsen's analysis finds the history of 
operations
 : consistent for each test. If that happens, the following is 
output in the end
 : of a test:
this reads weird. how about:
When Jepsen's analysis doesn't find inconsistencies in the history of 
operations it outputs the following in the end of a test:


PS3, Line 113: why Jepsen
 : was not happy about the run.
replace with: why the test failed.


PS3, Line 120: other
 :   errors reported by
replace with: or in any of the


PS3, Line 125:  or
nit: replace this "or" with a comma


PS3, Line 129: issues like that
replace with: "errors in 10 tests ran"


PS3, Line 139: manifestations
"a manifestation"


PS3, Line 140: These are
This is...


PS3, Line 141: on 
remove


PS3, Line 149: it outputs something like the following
 : into the log:
nit: it would be good to keep the first sentence consistent with this one.


-- 
To view, visit http://gerrit.cloudera.org:8080/6774
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9b97b744d969b73ede2fcb7a3509915b130c655b
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

[kudu-CR] [kudu-jepsen] added more info on troubleshooting

[Alexey Serbin (Code Review)]

Alexey Serbin has posted comments on this change.

Change subject: [kudu-jepsen] added more info on troubleshooting
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/6774/1/java/kudu-jepsen/README.adoc
File java/kudu-jepsen/README.adoc:

PS1, Line 142: Analysis invalid! (ﾉಥ益ಥ）ﾉ ┻━┻
> maybe also include what it outputs when the analysis was successful (like i
Usually an error means some further actions are not taking place, and 
especially the analysis (which is the latest phase of the run).  So, that would 
not be the case, exactly like it was in the last breakage: out of 11 tests run, 
there were just 10 instances of analysis run, each with successful message like 
'Everything looks good! ?(‘?`)?'

OK, I'll add that successful run output.


-- 
To view, visit http://gerrit.cloudera.org:8080/6774
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9b97b744d969b73ede2fcb7a3509915b130c655b
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

[kudu-CR] [kudu-jepsen] added more info on troubleshooting

[David Ribeiro Alves (Code Review)]

David Ribeiro Alves has posted comments on this change.

Change subject: [kudu-jepsen] added more info on troubleshooting
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/6774/1/java/kudu-jepsen/README.adoc
File java/kudu-jepsen/README.adoc:

PS1, Line 142: Analysis invalid! (ﾉಥ益ಥ）ﾉ ┻━┻
maybe also include what it outputs when the analysis was successful (like in 
this case, there were no errors to report) but some error happened


-- 
To view, visit http://gerrit.cloudera.org:8080/6774
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9b97b744d969b73ede2fcb7a3509915b130c655b
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

[kudu-CR] [kudu-jepsen] added more info on troubleshooting

[Alexey Serbin (Code Review)]

Alexey Serbin has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/6774

Change subject: [kudu-jepsen] added more info on troubleshooting
..

[kudu-jepsen] added more info on troubleshooting

Added more information on distinguishing 'errors' from 'failures' in the
kudu-jepsen test output.

Change-Id: I9b97b744d969b73ede2fcb7a3509915b130c655b
---
M java/kudu-jepsen/README.adoc
1 file changed, 20 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/74/6774/1
-- 
To view, visit http://gerrit.cloudera.org:8080/6774
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9b97b744d969b73ede2fcb7a3509915b130c655b
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin