[kudu-CR] KUDU-236 (part 3). Enable tablet history GC by default

2016-09-10 Thread Todd Lipcon (Code Review) 
Todd Lipcon has submitted this change and it was merged.

Change subject: KUDU-236 (part 3). Enable tablet history GC by default
..


KUDU-236 (part 3). Enable tablet history GC by default

Change-Id: Id81d9bf0d1b33d7d2384e101d10cfc299491f43a
Reviewed-on: http://gerrit.cloudera.org:8080/3983
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon 
---
M src/kudu/tablet/tablet.cc
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Todd Lipcon: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/3983
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id81d9bf0d1b33d7d2384e101d10cfc299491f43a
Gerrit-PatchSet: 7
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon

[kudu-CR] KUDU-236 (part 3). Enable tablet history GC by default

2016-09-10 Thread Todd Lipcon (Code Review) 
Todd Lipcon has posted comments on this change.

Change subject: KUDU-236 (part 3). Enable tablet history GC by default
..


Patch Set 6: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/3983
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id81d9bf0d1b33d7d2384e101d10cfc299491f43a
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] KUDU-236 (part 3). Enable tablet history GC by default

2016-09-10 Thread Kudu Jenkins (Code Review) 
Kudu Jenkins has posted comments on this change.

Change subject: KUDU-236 (part 3). Enable tablet history GC by default
..


Patch Set 6:

Build Started http://104.196.14.100/job/kudu-gerrit/3334/

-- 
To view, visit http://gerrit.cloudera.org:8080/3983
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id81d9bf0d1b33d7d2384e101d10cfc299491f43a
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] KUDU-236 (part 3). Enable tablet history GC by default

2016-09-10 Thread Mike Percy (Code Review) 
Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/3983

to look at the new patch set (#6).

Change subject: KUDU-236 (part 3). Enable tablet history GC by default
..

KUDU-236 (part 3). Enable tablet history GC by default

Change-Id: Id81d9bf0d1b33d7d2384e101d10cfc299491f43a
---
M src/kudu/tablet/tablet.cc
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/83/3983/6
-- 
To view, visit http://gerrit.cloudera.org:8080/3983
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id81d9bf0d1b33d7d2384e101d10cfc299491f43a
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon

[kudu-CR] KUDU-236 (part 3). Enable tablet history GC by default

2016-09-09 Thread Mike Percy (Code Review) 
Mike Percy has posted comments on this change.

Change subject: KUDU-236 (part 3). Enable tablet history GC by default
..


Patch Set 5:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3983/5/src/kudu/tablet/tablet.cc
File src/kudu/tablet/tablet.cc:

Line 111: DEFINE_int32(tablet_history_max_age_sec, 24 * 60 * 60,
> hrm, I was thinking a shorter default makes sense -- we can always make thi
Sounds good to me.


-- 
To view, visit http://gerrit.cloudera.org:8080/3983
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id81d9bf0d1b33d7d2384e101d10cfc299491f43a
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR] KUDU-236 (part 3). Enable tablet history GC by default

2016-09-09 Thread Todd Lipcon (Code Review) 
Todd Lipcon has posted comments on this change.

Change subject: KUDU-236 (part 3). Enable tablet history GC by default
..


Patch Set 5:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3983/5/src/kudu/tablet/tablet.cc
File src/kudu/tablet/tablet.cc:

Line 111: DEFINE_int32(tablet_history_max_age_sec, 24 * 60 * 60,
hrm, I was thinking a shorter default makes sense -- we can always make this 
default larger later, compatibly, but once it's large we could never make it 
smaller without potentially breaking apps. So, I think we should start with an 
aggressively small value like 15 minutes and if we see a majority of users 
hitting issues with snapshot scans, we can bump it up?


-- 
To view, visit http://gerrit.cloudera.org:8080/3983
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id81d9bf0d1b33d7d2384e101d10cfc299491f43a
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR] KUDU-236 (part 3). Enable tablet history GC by default

2016-09-09 Thread Kudu Jenkins (Code Review) 
Kudu Jenkins has posted comments on this change.

Change subject: KUDU-236 (part 3). Enable tablet history GC by default
..


Patch Set 5:

Build Started http://104.196.14.100/job/kudu-gerrit/3322/

-- 
To view, visit http://gerrit.cloudera.org:8080/3983
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id81d9bf0d1b33d7d2384e101d10cfc299491f43a
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] KUDU-236 (part 3). Enable tablet history GC by default

2016-09-09 Thread Kudu Jenkins (Code Review) 
Kudu Jenkins has posted comments on this change.

Change subject: KUDU-236 (part 3). Enable tablet history GC by default
..


Patch Set 4:

Build Started http://104.196.14.100/job/kudu-gerrit/3315/

-- 
To view, visit http://gerrit.cloudera.org:8080/3983
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id81d9bf0d1b33d7d2384e101d10cfc299491f43a
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] KUDU-236 (part 3). Enable tablet history GC by default

2016-09-02 Thread Kudu Jenkins (Code Review) 
Kudu Jenkins has posted comments on this change.

Change subject: KUDU-236 (part 3). Enable tablet history GC by default
..


Patch Set 3:

Build Started http://104.196.14.100/job/kudu-gerrit/3217/

-- 
To view, visit http://gerrit.cloudera.org:8080/3983
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id81d9bf0d1b33d7d2384e101d10cfc299491f43a
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] KUDU-236 (part 3). Enable tablet history GC by default

2016-09-01 Thread Kudu Jenkins (Code Review) 
Kudu Jenkins has posted comments on this change.

Change subject: KUDU-236 (part 3). Enable tablet history GC by default
..


Patch Set 2:

Build Started http://104.196.14.100/job/kudu-gerrit/3209/

-- 
To view, visit http://gerrit.cloudera.org:8080/3983
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id81d9bf0d1b33d7d2384e101d10cfc299491f43a
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] KUDU-236 (part 3). Enable tablet history GC by default

2016-08-15 Thread Mike Percy (Code Review) 
Hello Todd Lipcon,

I'd like you to do a code review.  Please visit

http://gerrit.cloudera.org:8080/3983

to review the following change.

Change subject: KUDU-236 (part 3). Enable tablet history GC by default
..

KUDU-236 (part 3). Enable tablet history GC by default

Change-Id: Id81d9bf0d1b33d7d2384e101d10cfc299491f43a
---
M src/kudu/tablet/tablet.cc
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/83/3983/1
-- 
To view, visit http://gerrit.cloudera.org:8080/3983
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id81d9bf0d1b33d7d2384e101d10cfc299491f43a
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: Todd Lipcon

[kudu-CR] KUDU-236 (part 3). Enable tablet history GC by default

2016-08-15 Thread Kudu Jenkins (Code Review) 
Kudu Jenkins has posted comments on this change.

Change subject: KUDU-236 (part 3). Enable tablet history GC by default
..


Patch Set 1:

Build Started http://104.196.14.100/job/kudu-gerrit/2910/

-- 
To view, visit http://gerrit.cloudera.org:8080/3983
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id81d9bf0d1b33d7d2384e101d10cfc299491f43a
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No