[kudu-CR] tablet: make time-based flushing configurable
Adar Dembo has posted comments on this change. Change subject: tablet: make time-based flushing configurable .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5690 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic9a546b82e5b5db76473455df1eab2769c443c87 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] tablet: make time-based flushing configurable
Adar Dembo has submitted this change and it was merged. Change subject: tablet: make time-based flushing configurable .. tablet: make time-based flushing configurable We currently prioritize flushes for any in-memory data which has been sitting longer than 2 minutes. This patch changes the time threshold to be a new experimental flag rather than a hard-coded constant. I found this useful to tweak when I wanted to run some experiments regarding the on-disk size of data. With this flag, I was able to set the threshold low to ensure that all of my inserted data was quickly flushed to disk rather than sitting around in MRS where I couldn't measure it. Change-Id: Ic9a546b82e5b5db76473455df1eab2769c443c87 Reviewed-on: http://gerrit.cloudera.org:8080/5690 Tested-by: Kudu Jenkins Reviewed-by: Adar Dembo --- M src/kudu/tablet/tablet_peer_mm_ops.cc 1 file changed, 7 insertions(+), 3 deletions(-) Approvals: Adar Dembo: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/5690 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic9a546b82e5b5db76473455df1eab2769c443c87 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR] tablet: make time-based flushing configurable
Todd Lipcon has uploaded a new patch set (#2). Change subject: tablet: make time-based flushing configurable .. tablet: make time-based flushing configurable We currently prioritize flushes for any in-memory data which has been sitting longer than 2 minutes. This patch changes the time threshold to be a new experimental flag rather than a hard-coded constant. I found this useful to tweak when I wanted to run some experiments regarding the on-disk size of data. With this flag, I was able to set the threshold low to ensure that all of my inserted data was quickly flushed to disk rather than sitting around in MRS where I couldn't measure it. Change-Id: Ic9a546b82e5b5db76473455df1eab2769c443c87 --- M src/kudu/tablet/tablet_peer_mm_ops.cc 1 file changed, 7 insertions(+), 3 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/90/5690/2 -- To view, visit http://gerrit.cloudera.org:8080/5690 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic9a546b82e5b5db76473455df1eab2769c443c87 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR] tablet: make time-based flushing configurable
Todd Lipcon has posted comments on this change. Change subject: tablet: make time-based flushing configurable .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5690/1/src/kudu/tablet/tablet_peer_mm_ops.cc File src/kudu/tablet/tablet_peer_mm_ops.cc: Line 38: DEFINE_int32(flush_mrs_time_threshold_secs, 2 * 60, > Would be nice if the name was more consistent with flush_threshold_mb. So m Done -- To view, visit http://gerrit.cloudera.org:8080/5690 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic9a546b82e5b5db76473455df1eab2769c443c87 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: Yes
[kudu-CR] tablet: make time-based flushing configurable
Adar Dembo has posted comments on this change. Change subject: tablet: make time-based flushing configurable .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5690/1/src/kudu/tablet/tablet_peer_mm_ops.cc File src/kudu/tablet/tablet_peer_mm_ops.cc: Line 38: DEFINE_int32(flush_mrs_time_threshold_secs, 2 * 60, Would be nice if the name was more consistent with flush_threshold_mb. So maybe make this flush_threshold_secs? Or maybe make the other one flush_mrs_threshold_mb and this one flush_mrs_threshold_secs? -- To view, visit http://gerrit.cloudera.org:8080/5690 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic9a546b82e5b5db76473455df1eab2769c443c87 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
[kudu-CR] tablet: make time-based flushing configurable
Hello Jean-Daniel Cryans, Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5690 to review the following change. Change subject: tablet: make time-based flushing configurable .. tablet: make time-based flushing configurable We currently prioritize flushes for any in-memory data which has been sitting longer than 2 minutes. This patch changes the time threshold to be a new experimental flag rather than a hard-coded constant. I found this useful to tweak when I wanted to run some experiments regarding the on-disk size of data. With this flag, I was able to set the threshold low to ensure that all of my inserted data was quickly flushed to disk rather than sitting around in MRS where I couldn't measure it. Change-Id: Ic9a546b82e5b5db76473455df1eab2769c443c87 --- M src/kudu/tablet/tablet_peer_mm_ops.cc 1 file changed, 7 insertions(+), 3 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/90/5690/1 -- To view, visit http://gerrit.cloudera.org:8080/5690 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic9a546b82e5b5db76473455df1eab2769c443c87 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Jean-Daniel Cryans