Re: Review Request 38825: CMake: Plumb `ENABLE_LIBEVENT` through libprocess config scripts.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38825/ --- (Updated Oct. 3, 2015, 11:45 p.m.) Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu. Bugs: MESOS-3543 https://issues.apache.org/jira/browse/MESOS-3543 Repository: mesos Description --- CMake: Plumb `ENABLE_LIBEVENT` through libprocess config scripts. Diffs (updated) - 3rdparty/libprocess/3rdparty/CMakeLists.txt 31d77d5629dba7ee0d1a4ceb7b60899f6047165f 3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake 9c369e2c94abcd2dfa463f98fb3b6527033064ab 3rdparty/libprocess/cmake/ProcessConfigure.cmake 076c8836d9d53b8bc69330a46a7e1d3039aa476b Diff: https://reviews.apache.org/r/38825/diff/ Testing --- # On OS X 10.10, Ubuntu 14.04, Ubuntu 15.04 cmake .. -DENABLE_LIBEVENT=1 && make -j 8 cmake .. && make -j 8 Thanks, Alex Clemmer
Re: Review Request 38825: CMake: Plumb `ENABLE_LIBEVENT` through libprocess config scripts.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38825/#review101413 --- Ship it! Ship It! - Joris Van Remoortere On Sept. 29, 2015, 8:21 p.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38825/ > --- > > (Updated Sept. 29, 2015, 8:21 p.m.) > > > Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph > Wu. > > > Bugs: MESOS-3543 > https://issues.apache.org/jira/browse/MESOS-3543 > > > Repository: mesos > > > Description > --- > > CMake: Plumb `ENABLE_LIBEVENT` through libprocess config scripts. > > > Diffs > - > > 3rdparty/libprocess/3rdparty/CMakeLists.txt > 31d77d5629dba7ee0d1a4ceb7b60899f6047165f > 3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake > 9c369e2c94abcd2dfa463f98fb3b6527033064ab > 3rdparty/libprocess/cmake/ProcessConfigure.cmake > 076c8836d9d53b8bc69330a46a7e1d3039aa476b > > Diff: https://reviews.apache.org/r/38825/diff/ > > > Testing > --- > > # On OS X 10.10, Ubuntu 14.04, Ubuntu 15.04 > > cmake .. -DENABLE_LIBEVENT=1 && make -j 8 > cmake .. && make -j 8 > > > Thanks, > > Alex Clemmer > >
Re: Review Request 38825: CMake: Plumb `ENABLE_LIBEVENT` through libprocess config scripts.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38825/ --- (Updated Sept. 29, 2015, 8:21 p.m.) Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu. Bugs: MESOS-3543 https://issues.apache.org/jira/browse/MESOS-3543 Repository: mesos Description --- CMake: Plumb `ENABLE_LIBEVENT` through libprocess config scripts. Diffs (updated) - 3rdparty/libprocess/3rdparty/CMakeLists.txt 31d77d5629dba7ee0d1a4ceb7b60899f6047165f 3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake 9c369e2c94abcd2dfa463f98fb3b6527033064ab 3rdparty/libprocess/cmake/ProcessConfigure.cmake 076c8836d9d53b8bc69330a46a7e1d3039aa476b Diff: https://reviews.apache.org/r/38825/diff/ Testing --- # On OS X 10.10, Ubuntu 14.04, Ubuntu 15.04 cmake .. -DENABLE_LIBEVENT=1 && make -j 8 cmake .. && make -j 8 Thanks, Alex Clemmer
Re: Review Request 38825: CMake: Plumb `ENABLE_LIBEVENT` through libprocess config scripts.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38825/ --- (Updated Sept. 29, 2015, 5:16 p.m.) Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu. Bugs: MESOS-3543 https://issues.apache.org/jira/browse/MESOS-3543 Repository: mesos Description --- CMake: Plumb `ENABLE_LIBEVENT` through libprocess config scripts. Diffs - 3rdparty/libprocess/3rdparty/CMakeLists.txt 31d77d5629dba7ee0d1a4ceb7b60899f6047165f 3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake 9c369e2c94abcd2dfa463f98fb3b6527033064ab 3rdparty/libprocess/cmake/ProcessConfigure.cmake 076c8836d9d53b8bc69330a46a7e1d3039aa476b Diff: https://reviews.apache.org/r/38825/diff/ Testing (updated) --- # On OS X 10.10, Ubuntu 14.04, Ubuntu 15.04 cmake .. -DENABLE_LIBEVENT=1 && make -j 8 cmake .. && make -j 8 Thanks, Alex Clemmer
Re: Review Request 38825: CMake: Plumb `ENABLE_LIBEVENT` through libprocess config scripts.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38825/#review100970 --- LGTM. Did you do any testing (like the previous chain)? - Joseph Wu On Sept. 28, 2015, 3:58 p.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38825/ > --- > > (Updated Sept. 28, 2015, 3:58 p.m.) > > > Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph > Wu. > > > Bugs: MESOS-3543 > https://issues.apache.org/jira/browse/MESOS-3543 > > > Repository: mesos > > > Description > --- > > CMake: Plumb `ENABLE_LIBEVENT` through libprocess config scripts. > > > Diffs > - > > 3rdparty/libprocess/3rdparty/CMakeLists.txt > 31d77d5629dba7ee0d1a4ceb7b60899f6047165f > 3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake > 9c369e2c94abcd2dfa463f98fb3b6527033064ab > 3rdparty/libprocess/cmake/ProcessConfigure.cmake > 076c8836d9d53b8bc69330a46a7e1d3039aa476b > > Diff: https://reviews.apache.org/r/38825/diff/ > > > Testing > --- > > > Thanks, > > Alex Clemmer > >
Re: Review Request 38825: CMake: Plumb `ENABLE_LIBEVENT` through libprocess config scripts.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38825/ --- (Updated Sept. 28, 2015, 10:58 p.m.) Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu. Bugs: MESOS-3543 https://issues.apache.org/jira/browse/MESOS-3543 Repository: mesos Description --- CMake: Plumb `ENABLE_LIBEVENT` through libprocess config scripts. Diffs - 3rdparty/libprocess/3rdparty/CMakeLists.txt 31d77d5629dba7ee0d1a4ceb7b60899f6047165f 3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake 9c369e2c94abcd2dfa463f98fb3b6527033064ab 3rdparty/libprocess/cmake/ProcessConfigure.cmake 076c8836d9d53b8bc69330a46a7e1d3039aa476b Diff: https://reviews.apache.org/r/38825/diff/ Testing --- Thanks, Alex Clemmer
Review Request 38825: CMake: Plumb `ENABLE_LIBEVENT` through libprocess config scripts.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38825/ --- Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu. Repository: mesos Description --- CMake: Plumb `ENABLE_LIBEVENT` through libprocess config scripts. Diffs - 3rdparty/libprocess/3rdparty/CMakeLists.txt 31d77d5629dba7ee0d1a4ceb7b60899f6047165f 3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake 9c369e2c94abcd2dfa463f98fb3b6527033064ab 3rdparty/libprocess/cmake/ProcessConfigure.cmake 076c8836d9d53b8bc69330a46a7e1d3039aa476b Diff: https://reviews.apache.org/r/38825/diff/ Testing --- Thanks, Alex Clemmer
