Re: Review Request 47088: Dropped http status check in HealthCheckTest.HealthStatusChange.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47088/ --- (Updated Nov. 25, 2016, 3:08 p.m.) Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Greg Mann, Artem Harutyunyan, Neil Conway, and Timothy Chen. Changes --- Rebase. Bugs: MESOS-1802 https://issues.apache.org/jira/browse/MESOS-1802 Repository: mesos Description --- Dropped http status check because so far we could not guarantee the http queries order match the `statusUpdate` order. Diffs (updated) - src/tests/health_check_tests.cpp a4436bdb70ca988106742dadb0762c99a4ebe369 Diff: https://reviews.apache.org/r/47088/diff/ Testing --- Using ``` GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="HealthCheckTest.HealthStatusChange" --verbose --gtest_break_on_failure --gtest_repeat=-1 ``` More than 1000 interactions in my slow vm. Thanks, haosdent huang
Re: Review Request 47088: Dropped http status check in HealthCheckTest.HealthStatusChange.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47088/#review156874 --- Ship it! Ship It! - Alexander Rukletsov On May 7, 2016, 9:07 a.m., haosdent huang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47088/ > --- > > (Updated May 7, 2016, 9:07 a.m.) > > > Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Greg Mann, > Artem Harutyunyan, Neil Conway, and Timothy Chen. > > > Bugs: MESOS-1802 > https://issues.apache.org/jira/browse/MESOS-1802 > > > Repository: mesos > > > Description > --- > > Dropped http status check because so far we could not guarantee the > http queries order match the `statusUpdate` order. > > > Diffs > - > > src/tests/health_check_tests.cpp 1c4a554ab07731963a4a38e3ae40b0323bf317bb > > Diff: https://reviews.apache.org/r/47088/diff/ > > > Testing > --- > > Using > > ``` > GLOG_v=1 ./bin/mesos-tests.sh > --gtest_filter="HealthCheckTest.HealthStatusChange" --verbose > --gtest_break_on_failure --gtest_repeat=-1 > ``` > > More than 1000 interactions in my slow vm. > > > Thanks, > > haosdent huang > >
Re: Review Request 47088: Dropped http status check in HealthCheckTest.HealthStatusChange.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47088/#review132137 --- Patch looks great! Reviews applied: [46307, 47088] Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On May 7, 2016, 9:07 a.m., haosdent huang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47088/ > --- > > (Updated May 7, 2016, 9:07 a.m.) > > > Review request for mesos, Alexander Rukletsov, Ben Mahler, Greg Mann, Artem > Harutyunyan, Neil Conway, and Timothy Chen. > > > Bugs: MESOS-1802 > https://issues.apache.org/jira/browse/MESOS-1802 > > > Repository: mesos > > > Description > --- > > Dropped http status check because so far we could not guarantee the > http queries order match the `statusUpdate` order. > > > Diffs > - > > src/tests/health_check_tests.cpp 1c4a554ab07731963a4a38e3ae40b0323bf317bb > > Diff: https://reviews.apache.org/r/47088/diff/ > > > Testing > --- > > Using > > ``` > GLOG_v=1 ./bin/mesos-tests.sh > --gtest_filter="HealthCheckTest.HealthStatusChange" --verbose > --gtest_break_on_failure --gtest_repeat=-1 > ``` > > More than 1000 interactions in my slow vm. > > > Thanks, > > haosdent huang > >
Re: Review Request 47088: Dropped http status check in HealthCheckTest.HealthStatusChange.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47088/ --- (Updated May 7, 2016, 9:07 a.m.) Review request for mesos, Alexander Rukletsov, Ben Mahler, Greg Mann, Artem Harutyunyan, Neil Conway, and Timothy Chen. Changes --- Add @hartem in reviewers and update `Testing Done`. Bugs: MESOS-1802 https://issues.apache.org/jira/browse/MESOS-1802 Repository: mesos Description --- Dropped http status check because so far we could not guarantee the http queries order match the `statusUpdate` order. Diffs - src/tests/health_check_tests.cpp 1c4a554ab07731963a4a38e3ae40b0323bf317bb Diff: https://reviews.apache.org/r/47088/diff/ Testing (updated) --- Using ``` GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="HealthCheckTest.HealthStatusChange" --verbose --gtest_break_on_failure --gtest_repeat=-1 ``` More than 1000 interactions in my slow vm. Thanks, haosdent huang
Review Request 47088: Dropped http status check in HealthCheckTest.HealthStatusChange.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47088/ --- Review request for mesos, Alexander Rukletsov, Ben Mahler, Greg Mann, Neil Conway, and Timothy Chen. Bugs: MESOS-1802 https://issues.apache.org/jira/browse/MESOS-1802 Repository: mesos Description --- Dropped http status check because so far we could not guarantee the http queries order match the `statusUpdate` order. Diffs - src/tests/health_check_tests.cpp 1c4a554ab07731963a4a38e3ae40b0323bf317bb Diff: https://reviews.apache.org/r/47088/diff/ Testing --- Thanks, haosdent huang
