Re: Review Request 50280: Simplificed removing whitspace by strings::replace().
> On July 21, 2016, 7:05 p.m., Benjamin Mahler wrote: > > Ship It! Note that you have some typos in the commit summary. - Benjamin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50280/#review143127 --- On July 21, 2016, 4:13 a.m., Klaus Ma wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50280/ > --- > > (Updated July 21, 2016, 4:13 a.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > --- > > Simplificed removing whitspace by strings::replace(). > > > Diffs > - > > src/common/values.cpp 7b8a8ea00bd4bd1a82c33be4438c26b2731b1dd8 > src/v1/values.cpp ff1926f9ab26c3ac3ab62b6df3ce305f5d12f12e > > Diff: https://reviews.apache.org/r/50280/diff/ > > > Testing > --- > > make && make test > > > Thanks, > > Klaus Ma > >
Re: Review Request 50280: Simplificed removing whitspace by strings::replace().
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50280/#review143127 --- Ship it! Ship It! - Benjamin Mahler On July 21, 2016, 4:13 a.m., Klaus Ma wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50280/ > --- > > (Updated July 21, 2016, 4:13 a.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > --- > > Simplificed removing whitspace by strings::replace(). > > > Diffs > - > > src/common/values.cpp 7b8a8ea00bd4bd1a82c33be4438c26b2731b1dd8 > src/v1/values.cpp ff1926f9ab26c3ac3ab62b6df3ce305f5d12f12e > > Diff: https://reviews.apache.org/r/50280/diff/ > > > Testing > --- > > make && make test > > > Thanks, > > Klaus Ma > >
Review Request 50280: Simplificed removing whitspace by strings::replace().
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50280/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description --- Simplificed removing whitspace by strings::replace(). Diffs - src/common/values.cpp 7b8a8ea00bd4bd1a82c33be4438c26b2731b1dd8 src/v1/values.cpp ff1926f9ab26c3ac3ab62b6df3ce305f5d12f12e Diff: https://reviews.apache.org/r/50280/diff/ Testing --- make && make test Thanks, Klaus Ma