Re: Review Request 59014: Implemented resolving an image secret in registry puller.

2017-05-10 Thread Chun-Hung Hsiao

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59014/#review174513
---


Ship it!




Ship It!

- Chun-Hung Hsiao


On May 5, 2017, 8:30 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59014/
> ---
> 
> (Updated May 5, 2017, 8:30 p.m.)
> 
> 
> Review request for mesos, Adam B, Chun-Hung Hsiao, Jie Yu, Kapil Arya, Till 
> Toenshoff, and Vinod Kone.
> 
> 
> Bugs: MESOS-7088
> https://issues.apache.org/jira/browse/MESOS-7088
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented resolving an image secret in registry puller.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
> 6db788dd0c582deadf3e91c4d21bb9c20cf94e6b 
> 
> 
> Diff: https://reviews.apache.org/r/59014/diff/2/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>



Re: Review Request 59014: Implemented resolving an image secret in registry puller.

2017-05-08 Thread Vinod Kone

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59014/#review174255
---


Ship it!




Ship It!

- Vinod Kone


On May 5, 2017, 8:30 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59014/
> ---
> 
> (Updated May 5, 2017, 8:30 p.m.)
> 
> 
> Review request for mesos, Adam B, Chun-Hung Hsiao, Jie Yu, Kapil Arya, Till 
> Toenshoff, and Vinod Kone.
> 
> 
> Bugs: MESOS-7088
> https://issues.apache.org/jira/browse/MESOS-7088
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented resolving an image secret in registry puller.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
> 6db788dd0c582deadf3e91c4d21bb9c20cf94e6b 
> 
> 
> Diff: https://reviews.apache.org/r/59014/diff/2/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>



Re: Review Request 59014: Implemented resolving an image secret in registry puller.

2017-05-05 Thread Gilbert Song

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59014/
---

(Updated May 5, 2017, 1:30 p.m.)


Review request for mesos, Adam B, Chun-Hung Hsiao, Jie Yu, Kapil Arya, Till 
Toenshoff, and Vinod Kone.


Bugs: MESOS-7088
https://issues.apache.org/jira/browse/MESOS-7088


Repository: mesos


Description
---

Implemented resolving an image secret in registry puller.


Diffs (updated)
-

  src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
6db788dd0c582deadf3e91c4d21bb9c20cf94e6b 


Diff: https://reviews.apache.org/r/59014/diff/2/

Changes: https://reviews.apache.org/r/59014/diff/1-2/


Testing
---

make check


Thanks,

Gilbert Song



Review Request 59014: Implemented resolving an image secret in registry puller.

2017-05-04 Thread Gilbert Song

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59014/
---

Review request for mesos, Adam B, Chun-Hung Hsiao, Jie Yu, Kapil Arya, Till 
Toenshoff, and Vinod Kone.


Bugs: MESOS-7088
https://issues.apache.org/jira/browse/MESOS-7088


Repository: mesos


Description
---

Implemented resolving an image secret in registry puller.


Diffs
-

  src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
6db788dd0c582deadf3e91c4d21bb9c20cf94e6b 


Diff: https://reviews.apache.org/r/59014/diff/1/


Testing
---

make check


Thanks,

Gilbert Song