Re: Review Request 65045: Tested correct operation handling during master failover.

2018-02-19 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65045/#review197751
---



Patch looks great!

Reviews applied: [65671, 65672, 65044, 65045]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Feb. 19, 2018, 11:09 a.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65045/
> ---
> 
> (Updated Feb. 19, 2018, 11:09 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Bugs: MESOS-8424
> https://issues.apache.org/jira/browse/MESOS-8424
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Tested correct operation handling during master failover.
> 
> 
> Diffs
> -
> 
>   src/tests/master_tests.cpp 28663c7a77096943949350abb3d13f9c04505f5b 
> 
> 
> Diff: https://reviews.apache.org/r/65045/diff/9/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 65045: Tested correct operation handling during master failover.

2018-02-19 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65045/#review197747
---



PASS: Mesos patch 65045 was successfully built and tested.

Reviews applied: `['65671', '65672', '65044', '65045']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65045

- Mesos Reviewbot Windows


On Feb. 19, 2018, 11:09 a.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65045/
> ---
> 
> (Updated Feb. 19, 2018, 11:09 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Bugs: MESOS-8424
> https://issues.apache.org/jira/browse/MESOS-8424
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Tested correct operation handling during master failover.
> 
> 
> Diffs
> -
> 
>   src/tests/master_tests.cpp 28663c7a77096943949350abb3d13f9c04505f5b 
> 
> 
> Diff: https://reviews.apache.org/r/65045/diff/9/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 65045: Tested correct operation handling during master failover.

2018-02-19 Thread Jan Schlicht 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65045/
---

(Updated Feb. 19, 2018, 12:09 p.m.)


Review request for mesos, Benjamin Bannier and Jie Yu.


Changes
---

Addressed issues.


Bugs: MESOS-8424
https://issues.apache.org/jira/browse/MESOS-8424


Repository: mesos


Description
---

Tested correct operation handling during master failover.


Diffs (updated)
-

  src/tests/master_tests.cpp 28663c7a77096943949350abb3d13f9c04505f5b 


Diff: https://reviews.apache.org/r/65045/diff/9/

Changes: https://reviews.apache.org/r/65045/diff/8-9/


Testing
---

make check


Thanks,

Jan Schlicht

Re: Review Request 65045: Tested correct operation handling during master failover.

2018-02-16 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65045/#review197680
---



Patch looks great!

Reviews applied: [65671, 65672, 65044, 65045]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Feb. 7, 2018, 10:57 a.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65045/
> ---
> 
> (Updated Feb. 7, 2018, 10:57 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Bugs: MESOS-8424
> https://issues.apache.org/jira/browse/MESOS-8424
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Tested correct operation handling during master failover.
> 
> 
> Diffs
> -
> 
>   src/tests/master_tests.cpp 7112bb4efcc312dc4f68bdc44fb685c7624002b1 
> 
> 
> Diff: https://reviews.apache.org/r/65045/diff/8/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 65045: Tested correct operation handling during master failover.

2018-02-16 Thread Benjamin Bannier 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65045/#review197674
---


Fix it, then Ship it!





src/tests/master_tests.cpp
Lines 8803 (patched)


nit: Let's wrap this like other multi-line function calls you added above.



src/tests/master_tests.cpp
Lines 8812 (patched)


Let's add a comment here why we expect to registrations; readers don't have 
that context, yet.



src/tests/master_tests.cpp
Lines 8823 (patched)


Make this a `const` ref.



src/tests/master_tests.cpp
Lines 8869 (patched)


`const` ref.



src/tests/master_tests.cpp
Lines 8930 (patched)


`const` ref



src/tests/master_tests.cpp
Lines 8934-8936 (patched)


We could also check here that this is the same operation (identical ID) 
which was pending above.


- Benjamin Bannier


On Feb. 7, 2018, 11:57 a.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65045/
> ---
> 
> (Updated Feb. 7, 2018, 11:57 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Bugs: MESOS-8424
> https://issues.apache.org/jira/browse/MESOS-8424
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Tested correct operation handling during master failover.
> 
> 
> Diffs
> -
> 
>   src/tests/master_tests.cpp 7112bb4efcc312dc4f68bdc44fb685c7624002b1 
> 
> 
> Diff: https://reviews.apache.org/r/65045/diff/8/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 65045: Tested correct operation handling during master failover.

2018-02-07 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65045/#review196983
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['65044', '65045']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65045

Relevant logs:

- 
[libprocess-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65045/logs/libprocess-tests-stdout.log):

```
[   OK ] Scheme/HTTPTest.WWWAuthenticateHeader/0 (444 ms)
[ RUN  ] Scheme/HTTPTest.WWWAuthenticateHeader/1
[   OK ] Scheme/HTTPTest.WWWAuthenticateHeader/1 (24 ms)
[ RUN  ] Scheme/HTTPTest.Accepts/0
[   OK ] Scheme/HTTPTest.Accepts/0 (216 ms)
[ RUN  ] Scheme/HTTPTest.Accepts/1
[   OK ] Scheme/HTTPTest.Accepts/1 (30 ms)
[--] 36 tests from Scheme/HTTPTest (6630 ms total)

[--] 4 tests from SSLVerifyIPAdd/SSLTest
[ RUN  ] SSLVerifyIPAdd/SSLTest.BasicSameProcess/0
[   OK ] SSLVerifyIPAdd/SSLTest.BasicSameProcess/0 (244 ms)
[ RUN  ] SSLVerifyIPAdd/SSLTest.BasicSameProcess/1
[   OK ] SSLVerifyIPAdd/SSLTest.BasicSameProcess/1 (167 ms)
[ RUN  ] SSLVerifyIPAdd/SSLTest.RequireCertificate/0
[   OK ] SSLVerifyIPAdd/SSLTest.RequireCertificate/0 (994 ms)
[ RUN  ] SSLVerifyIPAdd/SSLTest.RequireCertificate/1
[   OK ] SSLVerifyIPAdd/SSLTest.RequireCertificate/1 (872 ms)
[--] 4 tests from SSLVerifyIPAdd/SSLTest (2282 ms total)

[--] Global test environment tear-down
[==] 225 tests from 35 test cases ran. (35727 ms total)
[  PASSED  ] 224 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] SSLTest.SSLSocket

 1 FAILED TEST
  YOU HAVE 19 DISABLED TESTS

```

- 
[libprocess-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65045/logs/libprocess-tests-stderr.log):

```
I0207 11:12:37.152746  4268 process.cpp:929] Stopped the socket accept loop
I0207 11:12:37.182744  5612 process.cpp:929] Stopped the socket accept loop
I0207 11:12:37.425719  4268 openssl.cpp:514] Will not verify peer certificate!
NOTE: Set LIBPROCESS_SSL_VERIFY_CERT=1 to enable peer certificate verification
I0207 11:12:37.425719  4268 openssl.cpp:534] LIBPROCESS_SSL_REQUIRE_CERT 
implies peer certificate verification.
LIBPROCESS_SSL_VERIFY_CERT set to true
I0207 11:12:37.425719  4268 openssl.cpp:563] Using CA file: 
C:\Users\mesos\AppData\Local\Temp\A721FC\cert.pem
I0207 11:12:37.425719  4268 openssl.cpp:566] Using CA dir: 
C:\Users\mesos\AppData\Local\Temp\A721FC
I0207 11:12:37.594732  4268 openssl.cpp:514] Will not verify peer certificate!
NOTE: Set LIBPROCESS_SSL_VERIFY_CERT=1 to enable peer certificate verification
I0207 11:12:37.594732  4268 openssl.cpp:526] Will use IP address verification 
in subject alternative name certificate extension.
I0207 11:12:37.594732  4268 openssl.cpp:534] LIBPROCESS_SSL_REQUIRE_CERT 
implies peer certificate verification.
LIBPROCESS_SSL_VERIFY_CERT set to true
I0207 11:12:37.595752  4268 openssl.cpp:563] Using CA file: 
C:\Users\mesos\AppData\Local\Temp\LraHMA\cert.pem
I0207 11:12:37.595752  4268 openssl.cpp:566] Using CA dir: 
C:\Users\mesos\AppData\Local\Temp\LraHMA
I0207 11:12:37.902751  4268 openssl.cpp:509] CA directory path unspecified! 
NOTE: Set CA directory path with LIBPROCESS_SSL_CA_DIR=
I0207 11:12:37.902751  4268 openssl.cpp:514] Will not verify peer certificate!
NOTE: Set LIBPROCESS_SSL_VERIFY_CERT=1 to enable peer certificate verification
I0207 11:12:37.902751  4268 openssl.cpp:534] LIBPROCESS_SSL_REQUIRE_CERT 
implies peer certificate verification.
LIBPROCESS_SSL_VERIFY_CERT set to true
I0207 11:12:37.903755  4268 openssl.cpp:563] Using CA file: 
C:\Users\mesos\AppData\Local\Temp\GK27KA\cert.pem
I0207 11:12:38.860795  4268 openssl.cpp:509] CA directory path unspecified! 
NOTE: Set CA directory path with LIBPROCESS_SSL_CA_DIR=
I0207 11:12:38.860795  4268 openssl.cpp:514] Will not verify peer certificate!
NOTE: Set LIBPROCESS_SSL_VERIFY_CERT=1 to enable peer certificate verification
I0207 11:12:38.860795  4268 openssl.cpp:526] Will use IP address verification 
in subject alternative name certificate extension.
I0207 11:12:38.860795  4268 openssl.cpp:534] LIBPROCESS_SSL_REQUIRE_CERT 
implies peer certificate verification.
LIBPROCESS_SSL_VERIFY_CERT set to true
I0207 11:12:38.861449  4268 openssl.cpp:563] Using CA file: 
C:\Users\mesos\AppData\Local\Temp\vB2Taa\cert.pem
I0207 11:12:39.497680  3996 process.cpp:929] Stopped the socket accept loop
```

- Mesos Reviewbot Windows


On Feb. 7, 2018, 10:57 a.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65045/
> ---
> 
>

Re: Review Request 65045: Tested correct operation handling during master failover.

2018-02-07 Thread Jan Schlicht 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65045/
---

(Updated Feb. 7, 2018, 11:57 a.m.)


Review request for mesos, Benjamin Bannier and Jie Yu.


Changes
---

Removed post-failover offer handling to not run into MESOS-8524.


Bugs: MESOS-8424
https://issues.apache.org/jira/browse/MESOS-8424


Repository: mesos


Description
---

Tested correct operation handling during master failover.


Diffs (updated)
-

  src/tests/master_tests.cpp 7112bb4efcc312dc4f68bdc44fb685c7624002b1 


Diff: https://reviews.apache.org/r/65045/diff/8/

Changes: https://reviews.apache.org/r/65045/diff/7-8/


Testing (updated)
---

make check


Thanks,

Jan Schlicht

Re: Review Request 65045: Tested correct operation handling during master failover.

2018-02-06 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65045/#review196885
---



PASS: Mesos patch 65045 was successfully built and tested.

Reviews applied: `['65044', '65045']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65045

- Mesos Reviewbot Windows


On Feb. 6, 2018, 11:11 a.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65045/
> ---
> 
> (Updated Feb. 6, 2018, 11:11 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Bugs: MESOS-8424
> https://issues.apache.org/jira/browse/MESOS-8424
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Tested correct operation handling during master failover.
> 
> 
> Diffs
> -
> 
>   src/tests/master_tests.cpp 7112bb4efcc312dc4f68bdc44fb685c7624002b1 
> 
> 
> Diff: https://reviews.apache.org/r/65045/diff/7/
> 
> 
> Testing
> ---
> 
> make check
> 
> This test may trigger MESOS-8524, we might want to commit this as a disabled 
> test.
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 65045: Tested correct operation handling during master failover.

2018-02-06 Thread Jan Schlicht 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65045/
---

(Updated Feb. 6, 2018, 11:11 a.m.)


Review request for mesos, Benjamin Bannier and Jie Yu.


Changes
---

Re-added authentication flags (which is important for builds with enabled SSL)


Bugs: MESOS-8424
https://issues.apache.org/jira/browse/MESOS-8424


Repository: mesos


Description
---

Tested correct operation handling during master failover.


Diffs (updated)
-

  src/tests/master_tests.cpp 7112bb4efcc312dc4f68bdc44fb685c7624002b1 


Diff: https://reviews.apache.org/r/65045/diff/7/

Changes: https://reviews.apache.org/r/65045/diff/6-7/


Testing
---

make check

This test may trigger MESOS-8524, we might want to commit this as a disabled 
test.


Thanks,

Jan Schlicht

Re: Review Request 65045: Tested correct operation handling during master failover.

2018-02-02 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65045/#review196745
---



FAIL: Failed to apply the dependent review: 65043.

Failed command: `python.exe .\support\apply-reviews.py -n -r 65043`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65045

Relevant logs:

- 
[apply-review-65043-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65045/logs/apply-review-65043-stdout.log):

```
error: patch failed: src/common/protobuf_utils.cpp:1275
error: src/common/protobuf_utils.cpp: patch does not apply
error: patch failed: src/master/http.cpp:2593
error: src/master/http.cpp: patch does not apply
```

- Mesos Reviewbot Windows


On Feb. 2, 2018, 5:30 a.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65045/
> ---
> 
> (Updated Feb. 2, 2018, 5:30 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Bugs: MESOS-8424
> https://issues.apache.org/jira/browse/MESOS-8424
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Tested correct operation handling during master failover.
> 
> 
> Diffs
> -
> 
>   src/tests/master_tests.cpp 7112bb4efcc312dc4f68bdc44fb685c7624002b1 
> 
> 
> Diff: https://reviews.apache.org/r/65045/diff/6/
> 
> 
> Testing
> ---
> 
> make check
> 
> This test may trigger MESOS-8524, we might want to commit this as a disabled 
> test.
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 65045: Tested correct operation handling during master failover.

2018-02-02 Thread Jan Schlicht 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65045/
---

(Updated Feb. 2, 2018, 2:30 p.m.)


Review request for mesos, Benjamin Bannier and Jie Yu.


Changes
---

Addressed issues, removed flakyness.


Bugs: MESOS-8424
https://issues.apache.org/jira/browse/MESOS-8424


Repository: mesos


Description
---

Tested correct operation handling during master failover.


Diffs (updated)
-

  src/tests/master_tests.cpp 7112bb4efcc312dc4f68bdc44fb685c7624002b1 


Diff: https://reviews.apache.org/r/65045/diff/6/

Changes: https://reviews.apache.org/r/65045/diff/5-6/


Testing
---

make check


Thanks,

Jan Schlicht

Re: Review Request 65045: Tested correct operation handling during master failover.

2018-02-01 Thread Jan Schlicht 


> On Feb. 1, 2018, 7:56 a.m., Greg Mann wrote:
> > src/tests/master_tests.cpp
> > Lines 8899 (patched)
> > 
> >
> > Is this necessary?

Yes, the operation update will result in a `UPDATE_STATE` that will trigger 
another offer -- which isn't of interest for our test case, hence needs to be 
ignored.


- Jan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65045/#review196621
---


On Jan. 25, 2018, 2:10 p.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65045/
> ---
> 
> (Updated Jan. 25, 2018, 2:10 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Bugs: MESOS-8424
> https://issues.apache.org/jira/browse/MESOS-8424
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Tested correct operation handling during master failover.
> 
> 
> Diffs
> -
> 
>   src/tests/master_tests.cpp d01f3fbdd688ddd31fb0c777f973928f5b5fa5e7 
> 
> 
> Diff: https://reviews.apache.org/r/65045/diff/5/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 65045: Tested correct operation handling during master failover.

2018-02-01 Thread Jan Schlicht 


> On Feb. 1, 2018, 7:56 a.m., Greg Mann wrote:
> > src/tests/master_tests.cpp
> > Lines 8903 (patched)
> > 
> >
> > Do we need this, or does framework registration after master failover 
> > prompt an offer?

You're right that framework registration prompts an offer, but I've seen rare 
cases where it didn't, resulting in a flaky test, e.g. as reported in 
MESOS-8490.


- Jan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65045/#review196621
---


On Jan. 25, 2018, 2:10 p.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65045/
> ---
> 
> (Updated Jan. 25, 2018, 2:10 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Bugs: MESOS-8424
> https://issues.apache.org/jira/browse/MESOS-8424
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Tested correct operation handling during master failover.
> 
> 
> Diffs
> -
> 
>   src/tests/master_tests.cpp d01f3fbdd688ddd31fb0c777f973928f5b5fa5e7 
> 
> 
> Diff: https://reviews.apache.org/r/65045/diff/5/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 65045: Tested correct operation handling during master failover.

2018-01-31 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65045/#review196621
---




src/tests/master_tests.cpp
Lines 8772 (patched)


Is this necessary?



src/tests/master_tests.cpp
Lines 8812 (patched)


Is this necessary?



src/tests/master_tests.cpp
Lines 8893 (patched)


Is this necessary?



src/tests/master_tests.cpp
Lines 8899 (patched)


Is this necessary?



src/tests/master_tests.cpp
Lines 8903 (patched)


Do we need this, or does framework registration after master failover 
prompt an offer?



src/tests/master_tests.cpp
Lines 8912-8914 (patched)


Please put each condition on a separate line:
```
if (resource.has_provider_id() &&
resource.has_disk() &&
resource.disk().has_source() &&
resource.disk().source().type() == 
Resource::DiskInfo::Source::MOUNT) {
```


- Greg Mann


On Jan. 25, 2018, 1:10 p.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65045/
> ---
> 
> (Updated Jan. 25, 2018, 1:10 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Bugs: MESOS-8424
> https://issues.apache.org/jira/browse/MESOS-8424
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Tested correct operation handling during master failover.
> 
> 
> Diffs
> -
> 
>   src/tests/master_tests.cpp d01f3fbdd688ddd31fb0c777f973928f5b5fa5e7 
> 
> 
> Diff: https://reviews.apache.org/r/65045/diff/5/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 65045: Tested correct operation handling during master failover.

2018-01-25 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65045/#review196252
---



PASS: Mesos patch 65045 was successfully built and tested.

Reviews applied: `['65044', '65045']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65045

- Mesos Reviewbot Windows


On Jan. 25, 2018, 1:10 p.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65045/
> ---
> 
> (Updated Jan. 25, 2018, 1:10 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Bugs: MESOS-8424
> https://issues.apache.org/jira/browse/MESOS-8424
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Tested correct operation handling during master failover.
> 
> 
> Diffs
> -
> 
>   src/tests/master_tests.cpp d01f3fbdd688ddd31fb0c777f973928f5b5fa5e7 
> 
> 
> Diff: https://reviews.apache.org/r/65045/diff/5/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 65045: Tested correct operation handling during master failover.

2018-01-25 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65045/#review196244
---



PASS: Mesos patch 65045 was successfully built and tested.

Reviews applied: `['65044', '65045']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65045

- Mesos Reviewbot Windows


On Jan. 25, 2018, 2:10 p.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65045/
> ---
> 
> (Updated Jan. 25, 2018, 2:10 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Bugs: MESOS-8424
> https://issues.apache.org/jira/browse/MESOS-8424
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Tested correct operation handling during master failover.
> 
> 
> Diffs
> -
> 
>   src/tests/master_tests.cpp d01f3fbdd688ddd31fb0c777f973928f5b5fa5e7 
> 
> 
> Diff: https://reviews.apache.org/r/65045/diff/5/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 65045: Tested correct operation handling during master failover.

2018-01-25 Thread Jan Schlicht 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65045/
---

(Updated Jan. 25, 2018, 2:10 p.m.)


Review request for mesos, Benjamin Bannier and Jie Yu.


Changes
---

Fixed a race that would result in missing offers. We need to make sure that the 
old offer is rescinded before waiting for the new one.


Bugs: MESOS-8424
https://issues.apache.org/jira/browse/MESOS-8424


Repository: mesos


Description
---

Tested correct operation handling during master failover.


Diffs (updated)
-

  src/tests/master_tests.cpp d01f3fbdd688ddd31fb0c777f973928f5b5fa5e7 


Diff: https://reviews.apache.org/r/65045/diff/5/

Changes: https://reviews.apache.org/r/65045/diff/4-5/


Testing
---

make check


Thanks,

Jan Schlicht

Re: Review Request 65045: Tested correct operation handling during master failover.

2018-01-25 Thread Jan Schlicht 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65045/
---

(Updated Jan. 25, 2018, 1:24 p.m.)


Review request for mesos, Benjamin Bannier and Jie Yu.


Changes
---

Addressed issues, made expectations clearer.


Bugs: MESOS-8424
https://issues.apache.org/jira/browse/MESOS-8424


Repository: mesos


Description
---

Tested correct operation handling during master failover.


Diffs (updated)
-

  src/tests/master_tests.cpp d01f3fbdd688ddd31fb0c777f973928f5b5fa5e7 


Diff: https://reviews.apache.org/r/65045/diff/4/

Changes: https://reviews.apache.org/r/65045/diff/3-4/


Testing
---

make check


Thanks,

Jan Schlicht

Re: Review Request 65045: Tested correct operation handling during master failover.

2018-01-22 Thread Benjamin Bannier 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65045/#review195918
---



This test emitted some gmock warnings for me. Could you get rid of these?

GMOCK WARNING:
Uninteresting mock function call - returning directly.
Function call: registered(0x7fff12024248, @0x7fe5e0006de0 
622fd6fc-f57a-4657-8d79-d30efb8f8e66-, @0x7fe5e0006940 id: 
"622fd6fc-f57a-4657-8d79-d30efb8f8e66"
Ip: 3492307904
Port: 37105
Pid: "master@192.99.40.208:37105"
Hostname: "gru1.hw.ca1.mesosphere.com"
Version: "1.6.0"
Address {
  hostname: "gru1.hw.ca1.mesosphere.com"
  ip: "192.99.40.208"
  port: 37105
}
Capabilities {
  type: AGENT_UPDATE
}
)
NOTE: You can safely ignore the above warning unless this call should not 
happen.  Do not suppress it by blindly adding an EXPECT_CALL() if you don't 
mean to enforce the call.  See 
https://github.com/google/googletest/blob/master/googlemock/docs/CookBook.md#knowing-when-to-expect
 for details.

GMOCK WARNING:
Uninteresting mock function call - returning directly.
Function call: disconnected(0x7fff12024248)
NOTE: You can safely ignore the above warning unless this call should not 
happen.  Do not suppress it by blindly adding an EXPECT_CALL() if you don't 
mean to enforce the call.  See 
https://github.com/google/googletest/blob/master/googlemock/docs/CookBook.md#knowing-when-to-expect
 for details.

GMOCK WARNING:
Uninteresting mock function call - returning directly.
Function call: registered(0x7fff12024248, @0x7fe5ec001740 
622fd6fc-f57a-4657-8d79-d30efb8f8e66-, @0x7fe5ec002130 id: 
"f935fe81-68e3-4dbd-b258-6c216e9bb4c7"
Ip: 3492307904
Port: 37105
Pid: "master@192.99.40.208:37105"
Hostname: "gru1.hw.ca1.mesosphere.com"
Version: "1.6.0"
Address {
  hostname: "gru1.hw.ca1.mesosphere.com"
  ip: "192.99.40.208"
  port: 37105
}
Capabilities {
  type: AGENT_UPDATE
}
)
NOTE: You can safely ignore the above warning unless this call should not 
happen.  Do not suppress it by blindly adding an EXPECT_CALL() if you don't 
mean to enforce the call.  See 
https://github.com/google/googletest/blob/master/googlemock/docs/CookBook.md#knowing-when-to-expect
 for details.

GMOCK WARNING:
Uninteresting mock function call - returning directly.
Function call: offerRescinded(0x7fff12024248, @0x7fe5ec0015a8 
f935fe81-68e3-4dbd-b258-6c216e9bb4c7-O0)
NOTE: You can safely ignore the above warning unless this call should not 
happen.  Do not suppress it by blindly adding an EXPECT_CALL() if you don't 
mean to enforce the call.  See 
https://github.com/google/googletest/blob/master/googlemock/docs/CookBook.md#knowing-when-to-expect
 for details.
../src/tests/master_tests.cpp:8916: Failure


src/tests/master_tests.cpp
Lines 8804 (patched)


nit: get rid of this line.



src/tests/master_tests.cpp
Lines 8872 (patched)


Since with only assertions it becomes hard to recognize what is being 
tested, let's expect here.



src/tests/master_tests.cpp
Lines 8942 (patched)


We could expect here for self-documentation.


- Benjamin Bannier


On Jan. 18, 2018, 3:11 p.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65045/
> ---
> 
> (Updated Jan. 18, 2018, 3:11 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Bugs: MESOS-8424
> https://issues.apache.org/jira/browse/MESOS-8424
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Tested correct operation handling during master failover.
> 
> 
> Diffs
> -
> 
>   src/tests/master_tests.cpp d01f3fbdd688ddd31fb0c777f973928f5b5fa5e7 
> 
> 
> Diff: https://reviews.apache.org/r/65045/diff/3/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 65045: Tested correct operation handling during master failover.

2018-01-18 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65045/#review195727
---



PASS: Mesos patch 65045 was successfully built and tested.

Reviews applied: `['65044', '65045']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65045

- Mesos Reviewbot Windows


On Jan. 18, 2018, 2:11 p.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65045/
> ---
> 
> (Updated Jan. 18, 2018, 2:11 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Bugs: MESOS-8424
> https://issues.apache.org/jira/browse/MESOS-8424
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Tested correct operation handling during master failover.
> 
> 
> Diffs
> -
> 
>   src/tests/master_tests.cpp d01f3fbdd688ddd31fb0c777f973928f5b5fa5e7 
> 
> 
> Diff: https://reviews.apache.org/r/65045/diff/3/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 65045: Tested correct operation handling during master failover.

2018-01-18 Thread Jan Schlicht 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65045/
---

(Updated Jan. 18, 2018, 3:11 p.m.)


Review request for mesos, Benjamin Bannier and Jie Yu.


Changes
---

Use `GET_OPERATIONS` instead of `GET_AGENTS`.


Bugs: MESOS-8424
https://issues.apache.org/jira/browse/MESOS-8424


Repository: mesos


Description
---

Tested correct operation handling during master failover.


Diffs (updated)
-

  src/tests/master_tests.cpp d01f3fbdd688ddd31fb0c777f973928f5b5fa5e7 


Diff: https://reviews.apache.org/r/65045/diff/3/

Changes: https://reviews.apache.org/r/65045/diff/2-3/


Testing
---

make check


Thanks,

Jan Schlicht

Re: Review Request 65045: Tested correct operation handling during master failover.

2018-01-17 Thread Benjamin Bannier 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65045/#review195550
---


Ship it!




Ship It!

- Benjamin Bannier


On Jan. 16, 2018, 2:45 p.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65045/
> ---
> 
> (Updated Jan. 16, 2018, 2:45 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Bugs: MESOS-8424
> https://issues.apache.org/jira/browse/MESOS-8424
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Tested correct operation handling during master failover.
> 
> 
> Diffs
> -
> 
>   src/tests/master_tests.cpp 0edf22431aad85945aeb808a05f11e0bd832bccf 
> 
> 
> Diff: https://reviews.apache.org/r/65045/diff/2/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 65045: Tested correct operation handling during master failover.

2018-01-16 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65045/#review195456
---



PASS: Mesos patch 65045 was successfully built and tested.

Reviews applied: `['65125', '65043', '65044', '65045']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65045

- Mesos Reviewbot Windows


On Jan. 16, 2018, 5:45 a.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65045/
> ---
> 
> (Updated Jan. 16, 2018, 5:45 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Bugs: MESOS-8424
> https://issues.apache.org/jira/browse/MESOS-8424
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Tested correct operation handling during master failover.
> 
> 
> Diffs
> -
> 
>   src/tests/master_tests.cpp 0edf22431aad85945aeb808a05f11e0bd832bccf 
> 
> 
> Diff: https://reviews.apache.org/r/65045/diff/2/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 65045: Tested correct operation handling during master failover.

2018-01-16 Thread Jan Schlicht 


> On Jan. 15, 2018, 11:34 a.m., Benjamin Bannier wrote:
> > src/tests/master_tests.cpp
> > Lines 8667 (patched)
> > 
> >
> > This requires `process/ssl/flags.hpp` to compile with SSL enabled.

As the code is now rebased on top of #65125, the 
`resource_provider::createEndpointDetector` helper is used and this is no 
longer needed.


- Jan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65045/#review195415
---


On Jan. 16, 2018, 2:45 p.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65045/
> ---
> 
> (Updated Jan. 16, 2018, 2:45 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Bugs: MESOS-8424
> https://issues.apache.org/jira/browse/MESOS-8424
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Tested correct operation handling during master failover.
> 
> 
> Diffs
> -
> 
>   src/tests/master_tests.cpp 0edf22431aad85945aeb808a05f11e0bd832bccf 
> 
> 
> Diff: https://reviews.apache.org/r/65045/diff/2/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 65045: Tested correct operation handling during master failover.

2018-01-16 Thread Jan Schlicht 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65045/
---

(Updated Jan. 16, 2018, 2:45 p.m.)


Review request for mesos, Benjamin Bannier and Jie Yu.


Changes
---

Addressed issues.


Bugs: MESOS-8424
https://issues.apache.org/jira/browse/MESOS-8424


Repository: mesos


Description
---

Tested correct operation handling during master failover.


Diffs (updated)
-

  src/tests/master_tests.cpp 0edf22431aad85945aeb808a05f11e0bd832bccf 


Diff: https://reviews.apache.org/r/65045/diff/2/

Changes: https://reviews.apache.org/r/65045/diff/1-2/


Testing
---

make check


Thanks,

Jan Schlicht

Re: Review Request 65045: Tested correct operation handling during master failover.

2018-01-15 Thread Benjamin Bannier 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65045/#review195416
---




src/tests/master_tests.cpp
Lines 8617 (patched)


`s/auto/master::Flags`



src/tests/master_tests.cpp
Lines 8695 (patched)


Trim spaces before EOL comment.



src/tests/master_tests.cpp
Lines 8702 (patched)


Can we add a check that we are offered all resources here?



src/tests/master_tests.cpp
Lines 8750 (patched)


Let's capture the deserialized response in a variable and check that it is 
valid so we don't abort,

Try response_ =
  deserialize(ContentType::PROTOBUF, 
response->body);
  
ASSERT_SOME(response_);
v1::master::Response::GetAgents agents = response_->get_agents();



src/tests/master_tests.cpp
Lines 8766 (patched)


Since this is related to the agent reregistration, could we move this below 
the comment below just before we start the new master?



src/tests/master_tests.cpp
Lines 8780 (patched)


Trim spaces before EOL comment.



src/tests/master_tests.cpp
Lines 8787 (patched)


Can we add a check that we are offered all resources here?



src/tests/master_tests.cpp
Lines 8817-8819 (patched)


Let's check the deserialization result, see above.



src/tests/master_tests.cpp
Lines 8827 (patched)


Can we add an additional check that we are offered all resources after the 
operation went through?


- Benjamin Bannier


On Jan. 9, 2018, 2:28 p.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65045/
> ---
> 
> (Updated Jan. 9, 2018, 2:28 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Bugs: MESOS-8424
> https://issues.apache.org/jira/browse/MESOS-8424
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Tested correct operation handling during master failover.
> 
> 
> Diffs
> -
> 
>   src/tests/master_tests.cpp 5546fd937d078c1f757964d5163449ffd993388e 
> 
> 
> Diff: https://reviews.apache.org/r/65045/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 65045: Tested correct operation handling during master failover.

2018-01-15 Thread Benjamin Bannier 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65045/#review195415
---




src/tests/master_tests.cpp
Lines 8667 (patched)


This requires `process/ssl/flags.hpp` to compile with SSL enabled.


- Benjamin Bannier


On Jan. 9, 2018, 2:28 p.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65045/
> ---
> 
> (Updated Jan. 9, 2018, 2:28 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Bugs: MESOS-8424
> https://issues.apache.org/jira/browse/MESOS-8424
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Tested correct operation handling during master failover.
> 
> 
> Diffs
> -
> 
>   src/tests/master_tests.cpp 5546fd937d078c1f757964d5163449ffd993388e 
> 
> 
> Diff: https://reviews.apache.org/r/65045/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 65045: Tested correct operation handling during master failover.

2018-01-09 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65045/#review195032
---



PASS: Mesos patch 65045 was successfully built and tested.

Reviews applied: `['65043', '65044', '65045']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65045

- Mesos Reviewbot Windows


On Jan. 9, 2018, 1:28 p.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65045/
> ---
> 
> (Updated Jan. 9, 2018, 1:28 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Tested correct operation handling during master failover.
> 
> 
> Diffs
> -
> 
>   src/tests/master_tests.cpp 5546fd937d078c1f757964d5163449ffd993388e 
> 
> 
> Diff: https://reviews.apache.org/r/65045/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Review Request 65045: Tested correct operation handling during master failover.

2018-01-09 Thread Jan Schlicht 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65045/
---

Review request for mesos, Benjamin Bannier and Jie Yu.


Repository: mesos


Description
---

Tested correct operation handling during master failover.


Diffs
-

  src/tests/master_tests.cpp 5546fd937d078c1f757964d5163449ffd993388e 


Diff: https://reviews.apache.org/r/65045/diff/1/


Testing
---

make check


Thanks,

Jan Schlicht