Re: Review Request 67743: Made `gpu/nvidia` isolator works with `cgroups/all` isolation option.

2018-06-27 Thread Gilbert Song

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67743/#review205415
---


Ship it!




Ship It!

- Gilbert Song


On June 26, 2018, 6:58 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67743/
> ---
> 
> (Updated June 26, 2018, 6:58 a.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Bugs: MESOS-9027
> https://issues.apache.org/jira/browse/MESOS-9027
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Made `gpu/nvidia` isolator works with `cgroups/all` isolation option.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/gpu/isolator.cpp 
> d79c940498fe3cfeeaddad5f5e5e21fcdf4e04da 
> 
> 
> Diff: https://reviews.apache.org/r/67743/diff/1/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>



Re: Review Request 67743: Made `gpu/nvidia` isolator works with `cgroups/all` isolation option.

2018-06-26 Thread Mesos Reviewbot Windows

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67743/#review205378
---



PASS: Mesos patch 67743 was successfully built and tested.

Reviews applied: `['67743']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67743

- Mesos Reviewbot Windows


On June 26, 2018, 1:58 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67743/
> ---
> 
> (Updated June 26, 2018, 1:58 p.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Bugs: MESOS-9027
> https://issues.apache.org/jira/browse/MESOS-9027
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Made `gpu/nvidia` isolator works with `cgroups/all` isolation option.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/gpu/isolator.cpp 
> d79c940498fe3cfeeaddad5f5e5e21fcdf4e04da 
> 
> 
> Diff: https://reviews.apache.org/r/67743/diff/1/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>



Re: Review Request 67743: Made `gpu/nvidia` isolator works with `cgroups/all` isolation option.

2018-06-26 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67743/#review205375
---



Patch looks great!

Reviews applied: [67743]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On June 26, 2018, 1:58 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67743/
> ---
> 
> (Updated June 26, 2018, 1:58 p.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Bugs: MESOS-9027
> https://issues.apache.org/jira/browse/MESOS-9027
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Made `gpu/nvidia` isolator works with `cgroups/all` isolation option.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/gpu/isolator.cpp 
> d79c940498fe3cfeeaddad5f5e5e21fcdf4e04da 
> 
> 
> Diff: https://reviews.apache.org/r/67743/diff/1/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>



Review Request 67743: Made `gpu/nvidia` isolator works with `cgroups/all` isolation option.

2018-06-26 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67743/
---

Review request for mesos and Gilbert Song.


Bugs: MESOS-9027
https://issues.apache.org/jira/browse/MESOS-9027


Repository: mesos


Description
---

Made `gpu/nvidia` isolator works with `cgroups/all` isolation option.


Diffs
-

  src/slave/containerizer/mesos/isolators/gpu/isolator.cpp 
d79c940498fe3cfeeaddad5f5e5e21fcdf4e04da 


Diff: https://reviews.apache.org/r/67743/diff/1/


Testing
---

sudo make check


Thanks,

Qian Zhang