[GitHub] spark issue #21654: [SPARK-24671][PySpark] DataFrame length using a dunder/m...
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21654 Thanks, @holdenk for addressing my concern. I will try to join as well. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #22666: [SPARK-25672][SQL] schema_of_csv() - schema infer...
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22666#discussion_r228949792
--- Diff: sql/core/src/test/resources/sql-tests/inputs/csv-functions.sql ---
@@ -7,3 +7,11 @@ select from_csv('1', 'a InvalidType');
select from_csv('1', 'a INT', named_struct('mode', 'PERMISSIVE'));
select from_csv('1', 'a INT', map('mode', 1));
select from_csv();
+-- infer schema of json literal
+select from_csv('1,abc', schema_of_csv('1,abc'));
+select schema_of_csv('1|abc', map('delimiter', '|'));
+select schema_of_csv(null);
+CREATE TEMPORARY VIEW csvTable(csvField, a) AS SELECT * FROM VALUES
('1,abc', 'a');
+SELECT schema_of_csv(csvField) FROM csvTable;
+-- Clean up
+DROP VIEW IF EXISTS csvTable;
--- End diff --
I see but isn't it still better to explicitly clean tables up?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22813: [SPARK-25818][CORE] WorkDirCleanup should only remove th...
Github user srowen commented on the issue: https://github.com/apache/spark/pull/22813 I don't know what else goes in the work dir. It isn't valid to reuse it for anything else. Can you simply avoid using a work dir that is or has been used by something else? The argument for making this change anyway is just that the code should delete just what it writes. But I am just not sure it can be something you rely on for correct behavior --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22877: [MINOR][SQL] Avoid hardcoded configuration keys in SQLCo...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22877 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22877: [MINOR][SQL] Avoid hardcoded configuration keys in SQLCo...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22877 **[Test build #98214 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98214/testReport)** for PR 22877 at commit [`d641209`](https://github.com/apache/spark/commit/d6412096ccb60e95eecfc9bf2f1673fd9833e4d8). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22877: [MINOR][SQL] Avoid hardcoded configuration keys in SQLCo...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22877 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4593/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #22617: [SPARK-25484][SQL][TEST] Refactor ExternalAppendO...
Github user peter-toth commented on a diff in the pull request:
https://github.com/apache/spark/pull/22617#discussion_r228944791
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/ExternalAppendOnlyUnsafeRowArrayBenchmark.scala
---
@@ -68,9 +100,7 @@ object ExternalAppendOnlyUnsafeRowArrayBenchmark {
benchmark.addCase("ExternalAppendOnlyUnsafeRowArray") { _: Int =>
var sum = 0L
for (_ <- 0L until iterations) {
-val array = new ExternalAppendOnlyUnsafeRowArray(
-
ExternalAppendOnlyUnsafeRowArray.DefaultInitialSizeOfInMemoryBuffer,
- numSpillThreshold)
+val array = new
ExternalAppendOnlyUnsafeRowArray(numSpillThreshold, numSpillThreshold)
--- End diff --
Actually, following my logic in the description, I think
```
val array = new ExternalAppendOnlyUnsafeRowArray(numSpillThreshold,
numSpillThreshold)
```
should be changed to
```
val array = new ExternalAppendOnlyUnsafeRowArray(0, numSpillThreshold)
```
in `testAgainstRawUnsafeExternalSorter` in "WITH SPILL" cases so as to
compare `ExternalAppendOnlyUnsafeRowArray` to `UnsafeExternalSorter` when it
behaves so.
But would be great if someone could confirm this idea.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21588: [SPARK-24590][BUILD] Make Jenkins tests passed with hado...
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21588 Yes, that was what I was thinking at worst case. For clarification, @wangyum made a try and all tests were passed at least - https://github.com/apache/spark/pull/20659. Given this try, I think it looks pretty much feasible to upgrade without breaking compatibility. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22873: [SPARK-25866][ML] Update KMeans formatVersion
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22873 **[Test build #98196 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98196/testReport)** for PR 22873 at commit [`874c9c0`](https://github.com/apache/spark/commit/874c9c039fbfa2094790a4538e8fa603c8f3). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22873: [SPARK-25866][ML] Update KMeans formatVersion
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22873 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98196/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21654: [SPARK-24671][PySpark] DataFrame length using a dunder/m...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21654 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98211/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21654: [SPARK-24671][PySpark] DataFrame length using a dunder/m...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21654 **[Test build #98211 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98211/testReport)** for PR 21654 at commit [`e580442`](https://github.com/apache/spark/commit/e5804422c2711b3b8f7989a909ef27ef4cacb056). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21654: [SPARK-24671][PySpark] DataFrame length using a dunder/m...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21654 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22146: [SPARK-24434][K8S] pod template files
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22146 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22146: [SPARK-24434][K8S] pod template files
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22146 **[Test build #98213 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98213/testReport)** for PR 22146 at commit [`9e6a4b2`](https://github.com/apache/spark/commit/9e6a4b2db16daad02d4c51d25b5e4ae1f4582292). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22146: [SPARK-24434][K8S] pod template files
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22146 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98213/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22852: [SPARK-25023] Clarify Spark security documentation
Github user srowen commented on the issue: https://github.com/apache/spark/pull/22852 A quick pointer to security issues in other key places sounds good. As long as it is increasing the chance users understand the specific issue and isn't more general text to skip past, it is helping --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22146: [SPARK-24434][K8S] pod template files
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22146 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4592/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22146: [SPARK-24434][K8S] pod template files
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22146 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22146: [SPARK-24434][K8S] pod template files
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22146 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/4592/ --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #22849: [SPARK-25852][Core] we should filter the workOffe...
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22849#discussion_r228936286
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala
---
@@ -240,7 +240,7 @@ class CoarseGrainedSchedulerBackend(scheduler:
TaskSchedulerImpl, val rpcEnv: Rp
val taskDescs = CoarseGrainedSchedulerBackend.this.synchronized {
// Filter out executors under killing
val activeExecutors = executorDataMap.filterKeys(executorIsAlive)
-val workOffers = activeExecutors.map {
+val workOffers = activeExecutors.filter(_._2.freeCores > 0).map {
--- End diff --
I'm saying there is a comment a few lines above that describes this as a
fake offer that explicitly intends to contact all executors. I think we need to
figure out if that's still relevant. I don't have git in front of me but check
git blame or GitHub to see when this was written?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22146: [SPARK-24434][K8S] pod template files
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22146 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/4592/ --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22146: [SPARK-24434][K8S] pod template files
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22146 **[Test build #98213 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98213/testReport)** for PR 22146 at commit [`9e6a4b2`](https://github.com/apache/spark/commit/9e6a4b2db16daad02d4c51d25b5e4ae1f4582292). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22875: [SPARK-25867][ML] Remove KMeans computeCost
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22875 **[Test build #98212 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98212/testReport)** for PR 22875 at commit [`62f8606`](https://github.com/apache/spark/commit/62f8606182b79231340e30c4a8eba7b5f9ed819b). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22875: [SPARK-25867][ML] Remove KMeans computeCost
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22875 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4591/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22309: [SPARK-20384][SQL] Support value class in schema of Data...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/22309 My only concern is, the value class handling is kind of spread out in `ScalaReflection`. Maybe we need a better abstraction. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22875: [SPARK-25867][ML] Remove KMeans computeCost
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22875 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21654: [SPARK-24671][PySpark] DataFrame length using a dunder/m...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21654 **[Test build #98211 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98211/testReport)** for PR 21654 at commit [`e580442`](https://github.com/apache/spark/commit/e5804422c2711b3b8f7989a909ef27ef4cacb056). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #22309: [SPARK-20384][SQL] Support value class in schema ...
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22309#discussion_r228925856
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala
---
@@ -128,6 +128,15 @@ object ScalaReflection extends ScalaReflection {
case _ => false
}
+ def isValueClass(tpe: `Type`): Boolean = {
+tpe.typeSymbol.asClass.isDerivedValueClass
+ }
+
+ /** Returns the name and type of the underlying parameter of value class
`tpe`. */
+ def getUnderlyingParameterOf(tpe: `Type`): (String, Type) = {
+getConstructorParameters(tpe).head
--- End diff --
is there a more official way to get the value class field name?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22875: [SPARK-25867][ML] Remove KMeans computeCost
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22875 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22875: [SPARK-25867][ML] Remove KMeans computeCost
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22875 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4590/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22875: [SPARK-25867][ML] Remove KMeans computeCost
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22875 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22875: [SPARK-25867][ML] Remove KMeans computeCost
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22875 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98210/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22875: [SPARK-25867][ML] Remove KMeans computeCost
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22875 **[Test build #98210 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98210/testReport)** for PR 22875 at commit [`9ee93b1`](https://github.com/apache/spark/commit/9ee93b14a838fda3b61d36c39e5ee77c032c8fb8). * This patch **fails MiMa tests**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22877: [MINOR][SQL] Avoid hardcoded configuration keys in SQLCo...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22877 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4589/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22852: [SPARK-25023] Clarify Spark security documentation
Github user tgravescs commented on the issue: https://github.com/apache/spark/pull/22852 I would be fine with adding it more places, including perhaps the overview page: http://spark.apache.org/docs/latest/ and quick start pages. Perhaps we should agree upon the wording here first though. I'm not exactly sure where this pr stands honestly. @srowen are you going to put up a different one with wording you prefer? > If someone lands on this page, do they pretty easily come away with the impression they need to set spark.authenticate and network security if they care about security? Everyone reads text slightly different and I'm by no means a doc expert, so I'm definitely open to reword if there is consensus on it. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22146: [SPARK-24434][K8S] pod template files
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22146 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22877: [MINOR][SQL] Avoid hardcoded configuration keys in SQLCo...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22877 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22146: [SPARK-24434][K8S] pod template files
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22146 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4588/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22146: [SPARK-24434][K8S] pod template files
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22146 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/4588/ --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21588: [SPARK-24590][BUILD] Make Jenkins tests passed with hado...
Github user tgravescs commented on the issue: https://github.com/apache/spark/pull/21588 Can you clarify what you mean by drop builtin metastore support? Are you just saying users must always provide jars to use it or something more? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22146: [SPARK-24434][K8S] pod template files
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22146 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/4588/ --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22875: [SPARK-25867][ML] Remove KMeans computeCost
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22875 **[Test build #98210 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98210/testReport)** for PR 22875 at commit [`9ee93b1`](https://github.com/apache/spark/commit/9ee93b14a838fda3b61d36c39e5ee77c032c8fb8). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22146: [SPARK-24434][K8S] pod template files
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22146 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22146: [SPARK-24434][K8S] pod template files
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22146 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98205/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22146: [SPARK-24434][K8S] pod template files
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22146 **[Test build #98205 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98205/testReport)** for PR 22146 at commit [`5faea62`](https://github.com/apache/spark/commit/5faea6277c2581844786f4367f04b0355e3d9788). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22845: [SPARK-25848][SQL][TEST] Refactor CSVBenchmarks to use m...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22845 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98198/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22875: [SPARK-25867][ML] Remove KMeans computeCost
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22875 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4586/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22875: [SPARK-25867][ML] Remove KMeans computeCost
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22875 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22875: [SPARK-25867][ML] Remove KMeans computeCost
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22875 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22845: [SPARK-25848][SQL][TEST] Refactor CSVBenchmarks to use m...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22845 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22875: [SPARK-25867][ML] Remove KMeans computeCost
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22875 **[Test build #98201 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98201/testReport)** for PR 22875 at commit [`9ee93b1`](https://github.com/apache/spark/commit/9ee93b14a838fda3b61d36c39e5ee77c032c8fb8). * This patch **fails build dependency tests**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22873: [SPARK-25866][ML] Update KMeans formatVersion
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22873 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4585/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22875: [SPARK-25867][ML] Remove KMeans computeCost
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22875 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98201/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22875: [SPARK-25867][ML] Remove KMeans computeCost
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/22875 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22823: [SPARK-25676][SQL][TEST] Improve BenchmarkWideTable: use...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22823 **[Test build #98208 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98208/testReport)** for PR 22823 at commit [`0cfac24`](https://github.com/apache/spark/commit/0cfac246aba9e8336f943e38e2afd4aee067399c). * This patch **fails to build**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22823: [SPARK-25676][SQL][TEST] Improve BenchmarkWideTable: use...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22823 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22823: [SPARK-25676][SQL][TEST] Improve BenchmarkWideTable: use...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22823 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98208/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22844: [SPARK-25847][SQL][TEST] Refactor JSONBenchmarks to use ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22844 **[Test build #98199 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98199/testReport)** for PR 22844 at commit [`fbdbf83`](https://github.com/apache/spark/commit/fbdbf83c98a6ee61260ab1af30dfe7dae2890a25). * This patch **fails to build**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22844: [SPARK-25847][SQL][TEST] Refactor JSONBenchmarks to use ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22844 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22844: [SPARK-25847][SQL][TEST] Refactor JSONBenchmarks to use ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22844 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98199/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22873: [SPARK-25866][ML] Update KMeans formatVersion
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22873 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22845: [SPARK-25848][SQL][TEST] Refactor CSVBenchmarks to use m...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22845 **[Test build #98198 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98198/testReport)** for PR 22845 at commit [`6d1f1f5`](https://github.com/apache/spark/commit/6d1f1f5b7246fcb1577354dd87f56f6c4dbaa738). * This patch **fails build dependency tests**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22877: [MINOR][SQL] Avoid hardcoded configuration keys in SQLCo...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22877 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98209/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22877: [MINOR][SQL] Avoid hardcoded configuration keys in SQLCo...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22877 **[Test build #98209 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98209/testReport)** for PR 22877 at commit [`5995570`](https://github.com/apache/spark/commit/599557012cc9f4d4e5f36744180121cc8845413c). * This patch **fails to build**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22877: [MINOR][SQL] Avoid hardcoded configuration keys in SQLCo...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22877 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22275: [SPARK-25274][PYTHON][SQL] In toPandas with Arrow send o...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22275 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22275: [SPARK-25274][PYTHON][SQL] In toPandas with Arrow send o...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22275 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4587/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22830: [SPARK-25838][ML] Remove formatVersion from Saveable
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22830 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22830: [SPARK-25838][ML] Remove formatVersion from Saveable
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22830 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4584/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22845: [SPARK-25848][SQL][TEST] Refactor CSVBenchmarks to use m...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22845 **[Test build #98195 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98195/testReport)** for PR 22845 at commit [`004ed13`](https://github.com/apache/spark/commit/004ed139c59fee3c863b52cd6ec1eba539fe9135). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22830: [SPARK-25838][ML] Remove formatVersion from Saveable
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22830 **[Test build #98194 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98194/testReport)** for PR 22830 at commit [`e9d9e0e`](https://github.com/apache/spark/commit/e9d9e0eb6a7caf0b3fda27bfb3d03fa419e4487e). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22823: [SPARK-25676][SQL][TEST] Improve BenchmarkWideTable: use...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22823 **[Test build #98208 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98208/testReport)** for PR 22823 at commit [`0cfac24`](https://github.com/apache/spark/commit/0cfac246aba9e8336f943e38e2afd4aee067399c). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22146: [SPARK-24434][K8S] pod template files
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22146 **[Test build #98205 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98205/testReport)** for PR 22146 at commit [`5faea62`](https://github.com/apache/spark/commit/5faea6277c2581844786f4367f04b0355e3d9788). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22875: [SPARK-25867][ML] Remove KMeans computeCost
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22875 **[Test build #98201 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98201/testReport)** for PR 22875 at commit [`9ee93b1`](https://github.com/apache/spark/commit/9ee93b14a838fda3b61d36c39e5ee77c032c8fb8). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22861: [SPARK-25663][SPARK-25661][SQL][TEST] Refactor BuiltInDa...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22861 **[Test build #98207 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98207/testReport)** for PR 22861 at commit [`59f167d`](https://github.com/apache/spark/commit/59f167dd1d22ecf6ce9868dd52614ef441416858). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22845: [SPARK-25848][SQL][TEST] Refactor CSVBenchmarks to use m...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22845 **[Test build #98198 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98198/testReport)** for PR 22845 at commit [`6d1f1f5`](https://github.com/apache/spark/commit/6d1f1f5b7246fcb1577354dd87f56f6c4dbaa738). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22755: [SPARK-25755][SQL][Test] Supplementation of non-CodeGen ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22755 **[Test build #98206 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98206/testReport)** for PR 22755 at commit [`50fb517`](https://github.com/apache/spark/commit/50fb517eb4eaa64c9f03bc3999f66aaaf14d6a8e). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22844: [SPARK-25847][SQL][TEST] Refactor JSONBenchmarks to use ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22844 **[Test build #98199 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98199/testReport)** for PR 22844 at commit [`fbdbf83`](https://github.com/apache/spark/commit/fbdbf83c98a6ee61260ab1af30dfe7dae2890a25). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22275: [SPARK-25274][PYTHON][SQL] In toPandas with Arrow send o...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22275 **[Test build #98202 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98202/testReport)** for PR 22275 at commit [`d6fefee`](https://github.com/apache/spark/commit/d6fefee68c30aa579b345c32d9f00b32bf9a505b). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22877: [MINOR][SQL] Avoid hardcoded configuration keys in SQLCo...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22877 **[Test build #98209 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98209/testReport)** for PR 22877 at commit [`5995570`](https://github.com/apache/spark/commit/599557012cc9f4d4e5f36744180121cc8845413c). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22872: [SPARK-25864][SQL][TEST] Make main args accessible for B...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22872 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22873: [SPARK-25866][ML] Update KMeans formatVersion
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22873 **[Test build #98196 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98196/testReport)** for PR 22873 at commit [`874c9c0`](https://github.com/apache/spark/commit/874c9c039fbfa2094790a4538e8fa603c8f3). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22868: [SPARK-25833][SQL][DOCS] Update migration guide for Hive...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22868 **[Test build #98197 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98197/testReport)** for PR 22868 at commit [`84d9e8c`](https://github.com/apache/spark/commit/84d9e8c20c12e5e3e3150de9a97f581858e3c9bd). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22309: [SPARK-20384][SQL] Support value class in schema of Data...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22309 **[Test build #98200 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98200/testReport)** for PR 22309 at commit [`893b6fc`](https://github.com/apache/spark/commit/893b6fc54e10c4200b50a056b97a465316e20462). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22872: [SPARK-25864][SQL][TEST] Make main args accessible for B...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22872 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98204/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22309: [SPARK-20384][SQL] Support value class in schema of Data...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22309 **[Test build #98203 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98203/testReport)** for PR 22309 at commit [`c31f7e7`](https://github.com/apache/spark/commit/c31f7e766a4b8b6cab9710ed30dbf1cdfd1998bc). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #22877: [MINOR][SQL] Avoid hardcoded configuration keys i...
GitHub user HyukjinKwon opened a pull request: https://github.com/apache/spark/pull/22877 [MINOR][SQL] Avoid hardcoded configuration keys in SQLConf's `doc` ## What changes were proposed in this pull request? This PR proposes to avoid hardcorded configuration keys in SQLConf's `doc. ## How was this patch tested? Manually verified. You can merge this pull request into a Git repository by running: $ git pull https://github.com/HyukjinKwon/spark minor-conf-name Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/22877.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #22877 commit 599557012cc9f4d4e5f36744180121cc8845413c Author: hyukjinkwon Date: 2018-10-29T12:42:54Z Avoid hardcoded configuration keys in SQLConf's `doc` --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22876: [SPARK-25869] [YARN] the original diagnostics is missing...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22876 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22876: [SPARK-25869] [YARN] the original diagnostics is missing...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22876 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22876: [SPARK-25869] [YARN] the original diagnostics is missing...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22876 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #22876: [SPARK-25869] [YARN] the original diagnostics is ...
GitHub user Cangyl opened a pull request: https://github.com/apache/spark/pull/22876 [SPARK-25869] [YARN] the original diagnostics is missing when job failed ma⦠When submit spark on yarn jobs, the diagnostics message may be missing when job failed maxAppAttempts times For more details, please check https://issues.apache.org/jira/browse/SPARK-25869 You can merge this pull request into a Git repository by running: $ git pull https://github.com/Cangyl/spark SPARK-25869 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/22876.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #22876 commit afce7a0986ae04610eb2a9cfb9d8c50fe8de69c1 Author: ä»ä¸äº® 10202330 Date: 2018-10-29T11:59:49Z Spark on YARN: the original diagnostics is missing when job failed maxAppAttempts times --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #22872: [SPARK-25864][SQL][TEST] Make main args accessibl...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/22872 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22872: [SPARK-25864][SQL][TEST] Make main args accessible for B...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/22872 thanks, merging to master! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22872: [SPARK-25864][SQL][TEST] Make main args accessible for B...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22872 **[Test build #98185 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98185/testReport)** for PR 22872 at commit [`2696321`](https://github.com/apache/spark/commit/269632148cac72c1e19a6d843a1ec647dfd10bf4). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22872: [SPARK-25864][SQL][TEST] Make main args accessible for B...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22872 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22872: [SPARK-25864][SQL][TEST] Make main args accessible for B...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22872 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98185/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #22617: [SPARK-25484][SQL][TEST] Refactor ExternalAppendO...
Github user peter-toth commented on a diff in the pull request:
https://github.com/apache/spark/pull/22617#discussion_r228889856
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/ExternalAppendOnlyUnsafeRowArrayBenchmark.scala
---
@@ -68,9 +100,7 @@ object ExternalAppendOnlyUnsafeRowArrayBenchmark {
benchmark.addCase("ExternalAppendOnlyUnsafeRowArray") { _: Int =>
var sum = 0L
for (_ <- 0L until iterations) {
-val array = new ExternalAppendOnlyUnsafeRowArray(
-
ExternalAppendOnlyUnsafeRowArray.DefaultInitialSizeOfInMemoryBuffer,
- numSpillThreshold)
+val array = new
ExternalAppendOnlyUnsafeRowArray(numSpillThreshold, numSpillThreshold)
--- End diff --
Thanks for the feedback @dongjoon-hyun. I added some details to the
description.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22844: [SPARK-25847][SQL][TEST] Refactor JSONBenchmarks to use ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22844 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22844: [SPARK-25847][SQL][TEST] Refactor JSONBenchmarks to use ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22844 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98192/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
