[GitHub] spark pull request: SPARK-7103: Fix crash with SparkContext.union ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5679#issuecomment-96618907 [Test build #716 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/716/consoleFull) for PR 5679 at commit [`5a3d846`](https://github.com/apache/spark/commit/5a3d84649b46df9fd670e951941e809e1e6d98a7). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-7103: Fix crash with SparkContext.union ...
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/5679#issuecomment-96618838 Jenkins has trouble posting this back, but it failed unit tests, however this seems to be for unrelated reasons. Let me try again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-7103: Fix crash with SparkContext.union ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5679#issuecomment-96657002 [Test build #716 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/716/consoleFull) for PR 5679 at commit [`5a3d846`](https://github.com/apache/spark/commit/5a3d84649b46df9fd670e951941e809e1e6d98a7). * This patch **passes all tests**. * This patch merges cleanly. * This patch adds no public classes. * This patch does not change any dependencies. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-7103: Fix crash with SparkContext.union ...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/5679 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-7103: Fix crash with SparkContext.union ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5679#issuecomment-96766677 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-7103: Fix crash with SparkContext.union ...
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/5679#issuecomment-96365916 Jenkins, retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-7103: Fix crash with SparkContext.union ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5679#issuecomment-96454919 [Test build #714 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/714/consoleFull) for PR 5679 at commit [`5a3d846`](https://github.com/apache/spark/commit/5a3d84649b46df9fd670e951941e809e1e6d98a7). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-7103: Fix crash with SparkContext.union ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5679#issuecomment-96286235 [Test build #705 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/705/consoleFull) for PR 5679 at commit [`5a3d846`](https://github.com/apache/spark/commit/5a3d84649b46df9fd670e951941e809e1e6d98a7). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-7103: Fix crash with SparkContext.union ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5679#issuecomment-96288688 [Test build #705 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/705/consoleFull) for PR 5679 at commit [`5a3d846`](https://github.com/apache/spark/commit/5a3d84649b46df9fd670e951941e809e1e6d98a7). * This patch **fails Scala style tests**. * This patch merges cleanly. * This patch adds no public classes. * This patch **adds the following new dependencies:** * `tachyon-0.6.4.jar` * `tachyon-client-0.6.4.jar` * This patch **removes the following dependencies:** * `tachyon-0.5.0.jar` * `tachyon-client-0.5.0.jar` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-7103: Fix crash with SparkContext.union ...
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/5679#issuecomment-96195182 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-7103: Fix crash with SparkContext.union ...
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/5679#discussion_r29041189
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -1055,7 +1055,7 @@ class SparkContext(config: SparkConf) extends Logging
with ExecutorAllocationCli
/** Build the union of a list of RDDs. */
def union[T: ClassTag](rdds: Seq[RDD[T]]): RDD[T] = {
val partitioners = rdds.flatMap(_.partitioner).toSet
-if (partitioners.size == 1) {
+if (rdds.forall(_.partitioner.isDefined) partitioners.size == 1) {
--- End diff --
Yeah I like this. I suppose that the pre-existing condition already caught
the empty RDD case, which `PartitionerAwareUnionRDD` will reject. Although
symmetry between this check and the following one would be nice I don't think
it's important. This looks correct since clearly `PartitionerAwareUnionRDD`
intends to operate only on RDDs with partitioners.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-7103: Fix crash with SparkContext.union ...
GitHub user stevencanopy opened a pull request: https://github.com/apache/spark/pull/5679 SPARK-7103: Fix crash with SparkContext.union when RDD has no partitioner Added a check to the SparkContext.union method to check that a partitioner is defined on all RDDs when instantiating a PartitionerAwareUnionRDD. You can merge this pull request into a Git repository by running: $ git pull https://github.com/stevencanopy/spark SPARK-7103 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/5679.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5679 commit 5a3d84649b46df9fd670e951941e809e1e6d98a7 Author: Steven She ste...@canopylabs.com Date: 2015-04-24T05:55:25Z SPARK-7103: Fix crash with SparkContext.union when at least one RDD has no partitioner --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-7103: Fix crash with SparkContext.union ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5679#issuecomment-95810737 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-7103: Fix crash with SparkContext.union ...
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/5679#issuecomment-96058807 Jenkins, test his please. This LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
