[GitHub] spark pull request #14503: [#SPARK-16911] Fix the links in the programming g...
GitHub user shiv4nsh opened a pull request: https://github.com/apache/spark/pull/14503 [#SPARK-16911] Fix the links in the programming guide ## What changes were proposed in this pull request? Fix the broken links in the programming guide of the Graphx Migration and understanding closures ## How was this patch tested? By running the test cases and checking the links. You can merge this pull request into a Git repository by running: $ git pull https://github.com/shiv4nsh/spark SPARK-16911 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/14503.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #14503 commit 39ba49c6ef22841e7a2d0aabc5dc1693c0f54db3 Author: Shivansh Date: 2016-08-05T05:12:29Z [#SPARK-16911] Fix the links in the programming guide --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #14503: [#SPARK-16911] Fix the links in the programming g...
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/14503#discussion_r73649516 --- Diff: docs/programming-guide.md --- @@ -1097,7 +1097,7 @@ for details. foreach(func) Run a function func on each element of the dataset. This is usually done for side effects such as updating an Accumulator or interacting with external storage systems. - Note: modifying variables other than Accumulators outside of the foreach() may result in undefined behavior. See Understanding closures for more details. + Note: modifying variables other than Accumulators outside of the foreach() may result in undefined behavior. See Understanding closures for more details. --- End diff -- These anchors don't exist, are you sure about this? or close this PR please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #14503: [#SPARK-16911] Fix the links in the programming g...
Github user shiv4nsh commented on a diff in the pull request: https://github.com/apache/spark/pull/14503#discussion_r73650870 --- Diff: docs/programming-guide.md --- @@ -1097,7 +1097,7 @@ for details. foreach(func) Run a function func on each element of the dataset. This is usually done for side effects such as updating an Accumulator or interacting with external storage systems. - Note: modifying variables other than Accumulators outside of the foreach() may result in undefined behavior. See Understanding closures for more details. + Note: modifying variables other than Accumulators outside of the foreach() may result in undefined behavior. See Understanding closures for more details. --- End diff -- @srowen : When we see on the documentation: https://spark.apache.org/docs/latest/programming-guide.html#understanding-closures-a-nameclosureslinka Points to the understanding Closure documentation part hence I replaced it here. I have also rechecked it by generating the docs --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #14503: [#SPARK-16911] Fix the links in the programming g...
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/14503#discussion_r73651675 --- Diff: docs/programming-guide.md --- @@ -1097,7 +1097,7 @@ for details. foreach(func) Run a function func on each element of the dataset. This is usually done for side effects such as updating an Accumulator or interacting with external storage systems. - Note: modifying variables other than Accumulators outside of the foreach() may result in undefined behavior. See Understanding closures for more details. + Note: modifying variables other than Accumulators outside of the foreach() may result in undefined behavior. See Understanding closures for more details. --- End diff -- Ah right this is an auto-generated anchor. this is OK. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #14503: [#SPARK-16911] Fix the links in the programming g...
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/14503#discussion_r73651695 --- Diff: docs/programming-guide.md --- @@ -1571,7 +1571,7 @@ have changed from returning (key, list of values) pairs to (key, iterable of val Migration guides are also available for [Spark Streaming](streaming-programming-guide.html#migration-guide-from-091-or-below-to-1x), -[MLlib](ml-guide.html#migration-guide) and [GraphX](graphx-programming-guide.html#migrating-from-spark-091). +[MLlib](ml-guide.html#migration-guide) and [GraphX](graphx-programming-guide.html#migrating-from-spark-11). --- End diff -- This is also OK, though at this stage, these links and the entire migration sections they refer to are very old. We can just remove them. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #14503: [#SPARK-16911] Fix the links in the programming g...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/14503 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org