[GitHub] spark issue #19363: [Minor]Override toString of KeyValueGroupedDataset
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19363 **[Test build #82548 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82548/testReport)** for PR 19363 at commit [`7e7ed19`](https://github.com/apache/spark/commit/7e7ed190c529d1bc14439d0c218640d30a4065e4). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19363: [Minor]Override toString of KeyValueGroupedDataset
Github user yaooqinn commented on the issue: https://github.com/apache/spark/pull/19363 Okï¼i will add a jira tgt and fix RelationalGroupedDataset --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19363: [Minor]Override toString of KeyValueGroupedDataset
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/19363 shall we fix RelationalGroupedDataset too? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19363: [Minor]Override toString of KeyValueGroupedDataset
Github user viirya commented on the issue: https://github.com/apache/spark/pull/19363 Btw, I think this might need a minor/trivial JIRA ticket. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19363: [Minor]Override toString of KeyValueGroupedDataset
Github user viirya commented on the issue: https://github.com/apache/spark/pull/19363 Although this `toString` in scala-shell looks good, when you print out directly, it might look weird because you just see: ```scala [key: [value: string], value: [value: string]] ``` It's better to add prefix of the class name, like. ```scala KeyValueGroupedDataset: [key: [value: string], value: [value: string]] ``` --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19363: [Minor]Override toString of KeyValueGroupedDataset
Github user viirya commented on the issue: https://github.com/apache/spark/pull/19363 Maybe add a simple test? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19363: [Minor]Override toString of KeyValueGroupedDataset
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/19363 cc @viirya Could you review this PR? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19363: [Minor]Override toString of KeyValueGroupedDataset
Github user yaooqinn commented on the issue: https://github.com/apache/spark/pull/19363 cc again @cloud-fan @gatorsmile --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19363: [Minor]Override toString of KeyValueGroupedDataset
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19363 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19363: [Minor]Override toString of KeyValueGroupedDataset
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19363 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82259/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19363: [Minor]Override toString of KeyValueGroupedDataset
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19363 **[Test build #82259 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82259/testReport)** for PR 19363 at commit [`289b23d`](https://github.com/apache/spark/commit/289b23d2536cf190a40f4a5494a57e0854771e10). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19363: [Minor]Override toString of KeyValueGroupedDataset
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19363 **[Test build #82259 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82259/testReport)** for PR 19363 at commit [`289b23d`](https://github.com/apache/spark/commit/289b23d2536cf190a40f4a5494a57e0854771e10). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19363: [Minor]Override toString of KeyValueGroupedDataset
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19363 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82238/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19363: [Minor]Override toString of KeyValueGroupedDataset
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19363 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19363: [Minor]Override toString of KeyValueGroupedDataset
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19363 **[Test build #82238 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82238/testReport)** for PR 19363 at commit [`a9b30bd`](https://github.com/apache/spark/commit/a9b30bd6508421de192d0d44b6bc03afd3e0a792). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19363: [Minor]Override toString of KeyValueGroupedDataset
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19363 **[Test build #82238 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82238/testReport)** for PR 19363 at commit [`a9b30bd`](https://github.com/apache/spark/commit/a9b30bd6508421de192d0d44b6bc03afd3e0a792). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19363: [Minor]Override toString of KeyValueGroupedDataset
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/19363 ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19363: [Minor]Override toString of KeyValueGroupedDataset
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19363 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
