[GitHub] spark issue #19685: [SPARK-19759][ML] not using blas in ALSModel.predict for...
Github user srowen commented on the issue: https://github.com/apache/spark/pull/19685 Merged to master --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19685: [SPARK-19759][ML] not using blas in ALSModel.predict for...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19685 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19685: [SPARK-19759][ML] not using blas in ALSModel.predict for...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19685 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83598/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19685: [SPARK-19759][ML] not using blas in ALSModel.predict for...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19685 **[Test build #83598 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83598/testReport)** for PR 19685 at commit [`4867345`](https://github.com/apache/spark/commit/486734502026c2eb2a7a92d12e12da676013d7dd). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19685: [SPARK-19759][ML] not using blas in ALSModel.predict for...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19685 **[Test build #83598 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83598/testReport)** for PR 19685 at commit [`4867345`](https://github.com/apache/spark/commit/486734502026c2eb2a7a92d12e12da676013d7dd). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19685: [SPARK-19759][ML] not using blas in ALSModel.predict for...
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/19685 @srowen I tried enabling native BLAS, but native BLAS implementation is still much slower: average on 10 runs is 2529,922753 ms against 515,510185 ms of the for loop. As a reference, I am using a OSX 2.5 GHz Intel Core i7. What is worth to notice, though, is that I tried to run the same code but performing the `toArray` before, thus excluding its time from the computation. In this case, native BLAS implementation is much faster: 100,969697 ms. Thus here the "performance killer" is the conversion to array, as you pointed out. @WeichenXu123 In the description od the PR and here you can see the tests I made. Do you think something else is needed? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19685: [SPARK-19759][ML] not using blas in ALSModel.predict for...
Github user WeichenXu123 commented on the issue: https://github.com/apache/spark/pull/19685 Have you made some test to check the performance difference for this ? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19685: [SPARK-19759][ML] not using blas in ALSModel.predict for...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19685 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83551/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19685: [SPARK-19759][ML] not using blas in ALSModel.predict for...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19685 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19685: [SPARK-19759][ML] not using blas in ALSModel.predict for...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19685 **[Test build #83551 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83551/testReport)** for PR 19685 at commit [`8b0add6`](https://github.com/apache/spark/commit/8b0add68ddf68939c0f5ac19836f9b3b9cc58432). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19685: [SPARK-19759][ML] not using blas in ALSModel.predict for...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19685 **[Test build #83551 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83551/testReport)** for PR 19685 at commit [`8b0add6`](https://github.com/apache/spark/commit/8b0add68ddf68939c0f5ac19836f9b3b9cc58432). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
