[GitHub] spark issue #21956: [MINOR][DOCS] Fix grammatical error in SortShuffleManage...

2018-08-08 Thread kiszk 
Github user kiszk commented on the issue:

https://github.com/apache/spark/pull/21956
  
@HyukjinKwon sure, I will open a PR.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21956: [MINOR][DOCS] Fix grammatical error in SortShuffleManage...

2018-08-06 Thread HyukjinKwon 
Github user HyukjinKwon commented on the issue:

https://github.com/apache/spark/pull/21956
  
@kiszk, I would appreciate if you feel free to open a PR fixing them, or 
suggest them in someone's PR fixing them.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21956: [MINOR][DOCS] Fix grammatical error in SortShuffleManage...

2018-08-06 Thread HyukjinKwon 
Github user HyukjinKwon commented on the issue:

https://github.com/apache/spark/pull/21956
  
Merged to master.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21956: [MINOR][DOCS] Fix grammatical error in SortShuffleManage...

2018-08-05 Thread deshanxiao 
Github user deshanxiao commented on the issue:

https://github.com/apache/spark/pull/21956
  
It's ok. Thank you for your suggestions!


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21956: [MINOR][DOCS] Fix grammatical error in SortShuffleManage...

2018-08-05 Thread kiszk 
Github user kiszk commented on the issue:

https://github.com/apache/spark/pull/21956
  
Would it be possible to address the following parts for `can ...`, `could 
...`, `may ...`, and `will ...`, too?

`JavaSparkContextSuite.scala`
```
/**
 * Java apps can uses both Java-friendly JavaSparkContext and Scala 
SparkContext.
 */
``` 

`CodeGeneratorWithInterpretedFallback`
```
/**
 * A codegen object generator which creates objects with codegen path 
first. Once any compile
 * error happens, it can fallbacks to interpreted implementation. In tests, 
we can use a SQL config
 * `SQLConf.CODEGEN_FACTORY_MODE` to control fallback behavior.
 */
```

`FileStreamSource.scala`
```
fs.makeQualified(new Path(path))  // can contains glob patterns
```

`UnsupportedOperationSuites.scala`
```
   * exception simply for not being a streaming plan, even though that plan 
could exists as batch
```

`CreateHiveTableAsSelectCommand`
```
 * @param tableDesc the Table Describe, which may contains serde, storage 
handler etc.
```

`SQLMetrics.scala`
```
// The final result of this metric in physical operator UI may looks 
like:
```

`KafkaDataConsumer.scala`
```
// which may causes a NonLocalReturnControl exception when this method 
is used as a function.
```

`UnsafeSorterSpillMerger.java`
```
  // does not return wrong result because hasNext will returns true
```

`ProgressReporter.scala`
```
  // even multiple times) points and considering it twice will leads to 
double counting. We
```

`DecimalPrecision.scala`
```
// which is out of range and therefore it will becomes DECIMAL(38, 
7), leading to
```

`SQLTestUtils.scala`
```
   * ConsoleAppender's `follow` should be set to `true` so that it will 
honors reassignments of
```

`HiveQuerySuite.scala`
```
  // We assume that the Broadcast Join Threshold will works since the src 
is a small table
```




---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21956: [MINOR][DOCS] Fix grammatical error in SortShuffleManage...

2018-08-04 Thread AmplabJenkins 
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/21956
  
Merged build finished. Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21956: [MINOR][DOCS] Fix grammatical error in SortShuffleManage...

2018-08-04 Thread AmplabJenkins 
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/21956
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94212/
Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21956: [MINOR][DOCS] Fix grammatical error in SortShuffleManage...

2018-08-04 Thread SparkQA 
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/21956
  
**[Test build #94212 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94212/testReport)**
 for PR 21956 at commit 
[`460e388`](https://github.com/apache/spark/commit/460e388060fd3d588cfb22647ffcfacea855f8e6).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21956: [MINOR][DOCS] Fix grammatical error in SortShuffleManage...

2018-08-04 Thread SparkQA 
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/21956
  
**[Test build #94212 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94212/testReport)**
 for PR 21956 at commit 
[`460e388`](https://github.com/apache/spark/commit/460e388060fd3d588cfb22647ffcfacea855f8e6).


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21956: [MINOR][DOCS] Fix grammatical error in SortShuffleManage...

2018-08-04 Thread HyukjinKwon 
Github user HyukjinKwon commented on the issue:

https://github.com/apache/spark/pull/21956
  
retest this please


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21956: [MINOR][DOCS] Fix grammatical error in SortShuffleManage...

2018-08-04 Thread AmplabJenkins 
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/21956
  
Merged build finished. Test FAILed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21956: [MINOR][DOCS] Fix grammatical error in SortShuffleManage...

2018-08-04 Thread AmplabJenkins 
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/21956
  
Test FAILed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94198/
Test FAILed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21956: [MINOR][DOCS] Fix grammatical error in SortShuffleManage...

2018-08-04 Thread SparkQA 
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/21956
  
**[Test build #94198 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94198/testReport)**
 for PR 21956 at commit 
[`460e388`](https://github.com/apache/spark/commit/460e388060fd3d588cfb22647ffcfacea855f8e6).
 * This patch **fails due to an unknown error code, -9**.
 * This patch merges cleanly.
 * This patch adds no public classes.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21956: [MINOR][DOCS] Fix grammatical error in SortShuffleManage...

2018-08-03 Thread deshanxiao 
Github user deshanxiao commented on the issue:

https://github.com/apache/spark/pull/21956
  
Thanks a lot, I am sorry that I'm not able to find more clear errors. As a 
beginner, I am very glad to write more docs to help others understanding the 
spark core easier.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21956: [MINOR][DOCS] Fix grammatical error in SortShuffleManage...

2018-08-03 Thread SparkQA 
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/21956
  
**[Test build #94198 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94198/testReport)**
 for PR 21956 at commit 
[`460e388`](https://github.com/apache/spark/commit/460e388060fd3d588cfb22647ffcfacea855f8e6).


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21956: [MINOR][DOCS] Fix grammatical error in SortShuffleManage...

2018-08-03 Thread HyukjinKwon 
Github user HyukjinKwon commented on the issue:

https://github.com/apache/spark/pull/21956
  
ok to test


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21956: [MINOR][DOCS] Fix grammatical error in SortShuffleManage...

2018-08-01 Thread HyukjinKwon 
Github user HyukjinKwon commented on the issue:

https://github.com/apache/spark/pull/21956
  
It's okay @deshanxiao but mind taking another look and see if there are 
other typos in this module? I am pretty sure there are more and it should be 
good to fix them in a batch while we are here.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21956: [MINOR][DOCS] Fix grammatical error in SortShuffleManage...

2018-08-01 Thread AmplabJenkins 
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/21956
  
Can one of the admins verify this patch?


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21956: [MINOR][DOCS] Fix grammatical error in SortShuffleManage...

2018-08-01 Thread AmplabJenkins 
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/21956
  
Can one of the admins verify this patch?


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21956: [MINOR][DOCS] Fix grammatical error in SortShuffleManage...

2018-08-01 Thread AmplabJenkins 
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/21956
  
Can one of the admins verify this patch?


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21956: [MINOR][DOCS] Fix grammatical error in SortShuffleManage...

2018-08-01 Thread holdensmagicalunicorn 
Github user holdensmagicalunicorn commented on the issue:

https://github.com/apache/spark/pull/21956
  
@deshanxiao, thanks! I am a bot who has found some folks who might be able 
to help with the review:@JoshRosen, @rxin and @cloud-fan


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org