[GitHub] spark issue #22577: [CORE][MINOR] Fix obvious error and compiling for Scala ...
Github user srowen commented on the issue: https://github.com/apache/spark/pull/22577 Merged to master/2.4/2.3 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22577: [CORE][MINOR] Fix obvious error and compiling for Scala ...
Github user srowen commented on the issue: https://github.com/apache/spark/pull/22577 I think we can consider this more of the same in SPARK-25398, and attach it to that JIRA. If we end up passing the current 2.4 RC I'll untangle it. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22577: [CORE][MINOR] Fix obvious error and compiling for Scala ...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/22577 Can you create a jira ticket and put more description? This is a bug fix and strictly speaking it's nothing about scala 2.12. It's just the scala 2.12.7 compiler helps you to find this bug. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22577: [CORE][MINOR] Fix obvious error and compiling for Scala ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22577 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96737/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22577: [CORE][MINOR] Fix obvious error and compiling for Scala ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22577 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22577: [CORE][MINOR] Fix obvious error and compiling for Scala ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22577 **[Test build #96737 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96737/testReport)** for PR 22577 at commit [`1fa5618`](https://github.com/apache/spark/commit/1fa56185d69e5ba9a23d911ccaf844a967880068). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22577: [CORE][MINOR] Fix obvious error and compiling for Scala ...
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/22577 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22577: [CORE][MINOR] Fix obvious error and compiling for Scala ...
Github user sadhen commented on the issue: https://github.com/apache/spark/pull/22577 @HyukjinKwon Yes, just confirmed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22577: [CORE][MINOR] Fix obvious error and compiling for Scala ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22577 **[Test build #96737 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96737/testReport)** for PR 22577 at commit [`1fa5618`](https://github.com/apache/spark/commit/1fa56185d69e5ba9a23d911ccaf844a967880068). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22577: [CORE][MINOR] Fix obvious error and compiling for Scala ...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/22577 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22577: [CORE][MINOR] Fix obvious error and compiling for Scala ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22577 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96732/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22577: [CORE][MINOR] Fix obvious error and compiling for Scala ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22577 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22577: [CORE][MINOR] Fix obvious error and compiling for Scala ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22577 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22577: [CORE][MINOR] Fix obvious error and compiling for Scala ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22577 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96734/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22577: [CORE][MINOR] Fix obvious error and compiling for Scala ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22577 **[Test build #96734 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96734/testReport)** for PR 22577 at commit [`1fa5618`](https://github.com/apache/spark/commit/1fa56185d69e5ba9a23d911ccaf844a967880068). * This patch **fails due to an unknown error code, -9**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22577: [CORE][MINOR] Fix obvious error and compiling for Scala ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22577 **[Test build #96732 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96732/testReport)** for PR 22577 at commit [`1fa5618`](https://github.com/apache/spark/commit/1fa56185d69e5ba9a23d911ccaf844a967880068). * This patch **fails due to an unknown error code, -9**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22577: [CORE][MINOR] Fix obvious error and compiling for Scala ...
Github user sadhen commented on the issue: https://github.com/apache/spark/pull/22577 @cloud-fan The bug is introduced by #19748 branch-2.2 is fine, but branch-2.3 should be fixed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22577: [CORE][MINOR] Fix obvious error and compiling for Scala ...
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/22577 BTW, is this the only error related to compiling for Scala 2.12.7? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22577: [CORE][MINOR] Fix obvious error and compiling for Scala ...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/22577 ah so scala 2.12.7 is smarter on finding mistakes. LGTM then. Do you know how long this bug exists? It will decide how far we should backport it. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22577: [CORE][MINOR] Fix obvious error and compiling for Scala ...
Github user sadhen commented on the issue: https://github.com/apache/spark/pull/22577 @cloud-fan see: https://github.com/scala/scala/blob/2.12.x/src/compiler/scala/tools/nsc/typechecker/RefChecks.scala --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22577: [CORE][MINOR] Fix obvious error and compiling for Scala ...
Github user sadhen commented on the issue: https://github.com/apache/spark/pull/22577 Error Message: ``` $ dev/change-scala-version.sh 2.12 â spark git:(branch-2.4) â sbt -Dscala.version=2.12.7 sbt (spark)> project core sbt (core)> clean sbt (core)> compile [error] [warn] /Users/rendong/wdi/spark/core/src/main/scala/org/apache/spark/status/api/v1/OneApplicationResource.scala:178: Option[String] and String are unrelated: they will most likely never compare equal [error] [warn] app.attempts.filter(_.attemptId == attemptId).headOption [error] [warn] ``` --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22577: [CORE][MINOR] Fix obvious error and compiling for Scala ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22577 **[Test build #96734 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96734/testReport)** for PR 22577 at commit [`1fa5618`](https://github.com/apache/spark/commit/1fa56185d69e5ba9a23d911ccaf844a967880068). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22577: [CORE][MINOR] Fix obvious error and compiling for Scala ...
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/22577 ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22577: [CORE][MINOR] Fix obvious error and compiling for Scala ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22577 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22577: [CORE][MINOR] Fix obvious error and compiling for Scala ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22577 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22577: [CORE][MINOR] Fix obvious error and compiling for Scala ...
Github user sadhen commented on the issue: https://github.com/apache/spark/pull/22577 Dear Maintainers, please backport it to branch-2.4 if it is accepted. @cloud-fan @srowen --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22577: [CORE][MINOR] Fix obvious error and compiling for Scala ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22577 **[Test build #96732 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96732/testReport)** for PR 22577 at commit [`1fa5618`](https://github.com/apache/spark/commit/1fa56185d69e5ba9a23d911ccaf844a967880068). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
