[GitHub] spark issue #22940: [MINOR][R] Rename SQLUtils name to RSQLUtils in R
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/22940 Hm .. okay. let me close this for now. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22940: [MINOR][R] Rename SQLUtils name to RSQLUtils in R
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/22940 Hmmm yea but like .. some of classes similar with this case have been renamed time to time, for instancem `json InferSchema` -> `json JSONInferSchema` when CSV datasource was added (because there was `csv InferSchema`, which renamed `csv ... CSVInferSchema` as well). Every time I see `SQLUtils`, it's pretty confusing and somehow a bit annoying. The only reason I didn't change this so far was that it needs to change here and there .. This is somewhat what I guess we should eventually change tho. I thought it's better to do given it's 3.0.0. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22940: [MINOR][R] Rename SQLUtils name to RSQLUtils in R
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/22940 hmhm .. it's trivial and yea it is a logical change. I happened to take a look some codes around here lately, and the name `SQLUtils` actually annoyed me few times :(. I will leave it to @felixcheung. I don;t mind closing this. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22940: [MINOR][R] Rename SQLUtils name to RSQLUtils in R
Github user srowen commented on the issue: https://github.com/apache/spark/pull/22940 I'm neutral on it... seems like a logical change but is there any issue (like ambiguous imports that are annoying) other than not matching the pattern? I am not super concerned about back-porting conflicts, but still it's a non-trivial concern. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22940: [MINOR][R] Rename SQLUtils name to RSQLUtils in R
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22940 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98443/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22940: [MINOR][R] Rename SQLUtils name to RSQLUtils in R
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22940 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22940: [MINOR][R] Rename SQLUtils name to RSQLUtils in R
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22940 **[Test build #98443 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98443/testReport)** for PR 22940 at commit [`fa4b6f9`](https://github.com/apache/spark/commit/fa4b6f91f0f0b69d54142132be1d7f07cc3dd9b9). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22940: [MINOR][R] Rename SQLUtils name to RSQLUtils in R
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22940 **[Test build #98443 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98443/testReport)** for PR 22940 at commit [`fa4b6f9`](https://github.com/apache/spark/commit/fa4b6f91f0f0b69d54142132be1d7f07cc3dd9b9). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22940: [MINOR][R] Rename SQLUtils name to RSQLUtils in R
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22940 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4750/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22940: [MINOR][R] Rename SQLUtils name to RSQLUtils in R
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22940 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22940: [MINOR][R] Rename SQLUtils name to RSQLUtils in R
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/22940 @felixcheung, I don't feel super strongly about it but it bugged me. WDYT? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
