[GitHub] spark pull request: [SPARK-12966][SQL] Support ArrayType(DecimalTy...

[blbradley]

Github user blbradley commented on the pull request:

https://github.com/apache/spark/pull/10898#issuecomment-176380347
  
@maropu I see a corner case in `schemaString`. I believe I can get the 
right behavior now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12966][SQL] Support ArrayType(DecimalTy...

[maropu]

Github user maropu commented on the pull request:

https://github.com/apache/spark/pull/10898#issuecomment-176511873
  
I'll close this pr and I discuss this in #10928.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12966][SQL] Support ArrayType(DecimalTy...

[maropu]

Github user maropu closed the pull request at:

https://github.com/apache/spark/pull/10898


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12966][SQL] Support ArrayType(DecimalTy...

[maropu]

Github user maropu commented on the pull request:

https://github.com/apache/spark/pull/10898#issuecomment-176511689
  
I'll close this pr and discuss this in #10928.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12966][SQL] Support ArrayType(DecimalTy...

[blbradley]

Github user blbradley commented on the pull request:

https://github.com/apache/spark/pull/10898#issuecomment-176232874
  
@maropu I have submitted an implementation of this in #10928 and am not 
getting the error you describe.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12966][SQL] Support ArrayType(DecimalTy...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/10898#issuecomment-175978667
  
**[Test build #50251 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50251/consoleFull)**
 for PR 10898 at commit 
[`52eaebe`](https://github.com/apache/spark/commit/52eaebea0cf2650ee1aff4c0eb2d7dfd706d655b).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12966][SQL] Support ArrayType(DecimalTy...

[maropu]

Github user maropu commented on the pull request:

https://github.com/apache/spark/pull/10898#issuecomment-175992128
  
I found that it's not easy to support this type in postgresql in the 
current interface of `JdbcDialect`.
This is because the `postgresql-jdbc` implementation cannot handle a 
decimal type name with precision and scale such as `DECIMAL(xx, xx)` in 
`Connection#createArrayOf`.
To fix this issue, we can add a specific entry in 
`PostgresDialect#getJDBCType` 
(https://github.com/apache/spark/pull/10898/files#diff-23da60722bc6bfc160cbb59bd99f5925R64).
However, this fix makes things worse; `JdbcUtils#schemaString` cannot pass 
precision and scale for `Decimal` when relation defined in postgresql through 
`DataFrameWriter`.

I'm not sure how to fix this though, it seems okay to just add TODO 
comments and throw an unsupported exception for this type for the time being.
cc: @marmbrus 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12966][SQL] Support ArrayType(DecimalTy...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/10898#issuecomment-176010324
  
Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12966][SQL] Support ArrayType(DecimalTy...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/10898#issuecomment-176010035
  
**[Test build #50251 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50251/consoleFull)**
 for PR 10898 at commit 
[`52eaebe`](https://github.com/apache/spark/commit/52eaebea0cf2650ee1aff4c0eb2d7dfd706d655b).
 * This patch **fails Spark unit tests**.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12966][SQL] Support ArrayType(DecimalTy...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/10898#issuecomment-176010326
  
Test FAILed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50251/
Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12966][SQL] Support ArrayType(DecimalTy...

[blbradley]

Github user blbradley commented on the pull request:

https://github.com/apache/spark/pull/10898#issuecomment-174528746
  
You should not be converting to doubles when testing BigDecimal or 
DecimalType..


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12966][SQL] Support ArrayType(DecimalTy...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/10898#issuecomment-174525711
  
**[Test build #49993 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49993/consoleFull)**
 for PR 10898 at commit 
[`304d3d0`](https://github.com/apache/spark/commit/304d3d0bd5e57837bf14a457d12f5d248598d8b9).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12966][SQL] Support ArrayType(DecimalTy...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/10898#issuecomment-174516038
  
Test FAILed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/49989/
Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12966][SQL] Support ArrayType(DecimalTy...

[maropu]

Github user maropu commented on the pull request:

https://github.com/apache/spark/pull/10898#issuecomment-174522086
  
retest this please


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12966][SQL] Support ArrayType(DecimalTy...

[blbradley]

Github user blbradley commented on the pull request:

https://github.com/apache/spark/pull/10898#issuecomment-174529393
  
Also, we should be handling the precision and scale returned from Postgres. 
I've looked deep enough to see that this is possible.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12966][SQL] Support ArrayType(DecimalTy...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/10898#issuecomment-174516035
  
Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12966][SQL] Support ArrayType(DecimalTy...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/10898#issuecomment-174515843
  
**[Test build #49989 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49989/consoleFull)**
 for PR 10898 at commit 
[`304d3d0`](https://github.com/apache/spark/commit/304d3d0bd5e57837bf14a457d12f5d248598d8b9).
 * This patch **fails PySpark unit tests**.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12966][SQL] Support ArrayType(DecimalTy...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/10898#issuecomment-174639028
  
Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12966][SQL] Support ArrayType(DecimalTy...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/10898#issuecomment-174639031
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/49998/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12966][SQL] Support ArrayType(DecimalTy...

[maropu]

Github user maropu commented on the pull request:

https://github.com/apache/spark/pull/10898#issuecomment-174547504
  
ISTM precision and scale returned by postgres are filled with 
`ResultSetMetaData.getPrecision` and `ResultSetMetaData.getScale` in `JDBCRDD`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12966][SQL] Support ArrayType(DecimalTy...

[maropu]

Github user maropu commented on a diff in the pull request:

https://github.com/apache/spark/pull/10898#discussion_r50722428
  
--- Diff: 
docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/PostgresIntegrationSuite.scala
 ---
@@ -82,6 +83,10 @@ class PostgresIntegrationSuite extends 
DockerJDBCIntegrationSuite {
 assert(rows(0).getSeq(10) == Seq(1, 2))
 assert(rows(0).getSeq(11) == Seq("a", null, "b"))
 assert(rows(0).getSeq(12).toSeq == Seq(0.11f, 0.22f))
+val c13Expected = Seq(1.5, 3.25).map(new java.math.BigDecimal(_))
+assert(rows(0).getSeq[java.math.BigDecimal](13).zipWithIndex.forall { 
case (v, idx) =>
+v.compareTo(c13Expected(idx)) == 0
+})
--- End diff --

The test fails because the behaviour of `BigDecimal#equals` and 
`BigDecimal#compareTo` are different.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12966][SQL] Support ArrayType(DecimalTy...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/10898#issuecomment-174638686
  
**[Test build #49998 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49998/consoleFull)**
 for PR 10898 at commit 
[`3626132`](https://github.com/apache/spark/commit/36261329702c1657573654412ae16aef68e6).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12966][SQL] Support ArrayType(DecimalTy...

[blbradley]

Github user blbradley commented on the pull request:

https://github.com/apache/spark/pull/10898#issuecomment-174574309
  
@maropu Indeed, but they are not available in the metadata pased to 
`dialect.getCatalystType`. They probably need to be added to the metadata and 
logic added to `PostgresDialect` to handle that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12966][SQL] Support ArrayType(DecimalTy...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/10898#issuecomment-174567168
  
Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12966][SQL] Support ArrayType(DecimalTy...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/10898#issuecomment-174567175
  
Test FAILed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/49993/
Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12966][SQL] Support ArrayType(DecimalTy...

[blbradley]

Github user blbradley commented on a diff in the pull request:

https://github.com/apache/spark/pull/10898#discussion_r50717619
  
--- Diff: 
docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/PostgresIntegrationSuite.scala
 ---
@@ -82,6 +83,10 @@ class PostgresIntegrationSuite extends 
DockerJDBCIntegrationSuite {
 assert(rows(0).getSeq(10) == Seq(1, 2))
 assert(rows(0).getSeq(11) == Seq("a", null, "b"))
 assert(rows(0).getSeq(12).toSeq == Seq(0.11f, 0.22f))
+val c13Expected = Seq(1.5, 3.25).map(new java.math.BigDecimal(_))
+assert(rows(0).getSeq[java.math.BigDecimal](13).zipWithIndex.forall { 
case (v, idx) =>
+v.compareTo(c13Expected(idx)) == 0
+})
--- End diff --

Something like

```scala
assert(rows(0).getSeq(13) == Seq[BigDecimal](0.11, 0.22))
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12966][SQL] Support ArrayType(DecimalTy...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/10898#issuecomment-174566506
  
**[Test build #49993 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49993/consoleFull)**
 for PR 10898 at commit 
[`304d3d0`](https://github.com/apache/spark/commit/304d3d0bd5e57837bf14a457d12f5d248598d8b9).
 * This patch **fails Spark unit tests**.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12966][SQL] Support ArrayType(DecimalTy...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/10898#issuecomment-174546755
  
**[Test build #49995 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49995/consoleFull)**
 for PR 10898 at commit 
[`3626132`](https://github.com/apache/spark/commit/36261329702c1657573654412ae16aef68e6).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12966][SQL] Support ArrayType(DecimalTy...

[blbradley]

Github user blbradley commented on a diff in the pull request:

https://github.com/apache/spark/pull/10898#discussion_r50716977
  
--- Diff: 
docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/PostgresIntegrationSuite.scala
 ---
@@ -82,6 +83,10 @@ class PostgresIntegrationSuite extends 
DockerJDBCIntegrationSuite {
 assert(rows(0).getSeq(10) == Seq(1, 2))
 assert(rows(0).getSeq(11) == Seq("a", null, "b"))
 assert(rows(0).getSeq(12).toSeq == Seq(0.11f, 0.22f))
+val c13Expected = Seq(1.5, 3.25).map(new java.math.BigDecimal(_))
+assert(rows(0).getSeq[java.math.BigDecimal](13).zipWithIndex.forall { 
case (v, idx) =>
+v.compareTo(c13Expected(idx)) == 0
+})
--- End diff --

Why not follow the style of the test?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12966][SQL] Support ArrayType(DecimalTy...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/10898#issuecomment-174601018
  
**[Test build #49995 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49995/consoleFull)**
 for PR 10898 at commit 
[`3626132`](https://github.com/apache/spark/commit/36261329702c1657573654412ae16aef68e6).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12966][SQL] Support ArrayType(DecimalTy...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/10898#issuecomment-174601343
  
Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12966][SQL] Support ArrayType(DecimalTy...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/10898#issuecomment-174601344
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/49995/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12966][SQL] Support ArrayType(DecimalTy...

[maropu]

Github user maropu commented on the pull request:

https://github.com/apache/spark/pull/10898#issuecomment-174595373
  
Jenkins, retest this please.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12966][SQL] Support ArrayType(DecimalTy...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/10898#issuecomment-174599539
  
**[Test build #49998 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49998/consoleFull)**
 for PR 10898 at commit 
[`3626132`](https://github.com/apache/spark/commit/36261329702c1657573654412ae16aef68e6).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12966][SQL] Support ArrayType(DecimalTy...

[maropu]

GitHub user maropu opened a pull request:

https://github.com/apache/spark/pull/10898

[SPARK-12966][SQL] Support ArrayType(DecimalType) in Postgre JDBC

The current master throws an exception below;
```
org.postgresql.util.PSQLException: Unable to find server array type for 
provided name decimal(38,18)
```
This pr fixes this issue.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/maropu/spark SPARK-12747

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/10898.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #10898


commit 304d3d0bd5e57837bf14a457d12f5d248598d8b9
Author: Takeshi YAMAMURO 
Date:   2016-01-25T10:08:00Z

Support ArrayType(DecimalType) in Postgre JDBC




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12966][SQL] Support ArrayType(DecimalTy...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/10898#issuecomment-174484724
  
**[Test build #49989 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49989/consoleFull)**
 for PR 10898 at commit 
[`304d3d0`](https://github.com/apache/spark/commit/304d3d0bd5e57837bf14a457d12f5d248598d8b9).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org