[GitHub] spark pull request: [SQL] Made Command.sideEffectResult protected
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/2431 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SQL] Made Command.sideEffectResult protected
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/2431#issuecomment-57555461 Thanks! Merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SQL] Made Command.sideEffectResult protected
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2431#issuecomment-55946577 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20471/consoleFull) for PR 2431 at commit [`1bfc16a`](https://github.com/apache/spark/commit/1bfc16aea370ad94bd634dfc724d040b1531eaf4). * This patch **passes** unit tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SQL] Made Command.sideEffectResult protected
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/2431#issuecomment-55934389 @marmbrus Would be good to merge after #2226 since I made `InsertIntoHiveTable` a `Command` there and would have minor conflict with this one. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SQL] Made Command.sideEffectResult protected
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2431#issuecomment-55934164 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20471/consoleFull) for PR 2431 at commit [`1bfc16a`](https://github.com/apache/spark/commit/1bfc16aea370ad94bd634dfc724d040b1531eaf4). * This patch merges cleanly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SQL] Made Command.sideEffectResult protected
GitHub user liancheng opened a pull request: https://github.com/apache/spark/pull/2431 [SQL] Made Command.sideEffectResult protected Considering `Command.executeCollect()` simply delegates to `Command.sideEffectResult`, we no longer need to leave the latter `protected[sql]`. You can merge this pull request into a Git repository by running: $ git pull https://github.com/liancheng/spark narrow-scope Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/2431.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2431 commit 1bfc16aea370ad94bd634dfc724d040b1531eaf4 Author: Cheng Lian Date: 2014-09-17T17:52:56Z Made Command.sideEffectResult protected --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
