[GitHub] spark pull request #19143: [SPARK-21932][SQL]Remove package name similar 'lo...
GitHub user heary-cao opened a pull request: https://github.com/apache/spark/pull/19143 [SPARK-21932][SQL]Remove package name similar 'logical.Join' to 'Join' in JoinSelection ## What changes were proposed in this pull request? this PR to fix two problemsï¼ 1. similar 'logical.Join' in JoinSelection, is not right, to be consistent in SparkStrategies.scala. fix to remove package name. 2. add two test case. test CartesianProduct join and BroadcastNestedLoop join. We understand the effect of CodeGen on them. ## How was this patch tested? add new test case. You can merge this pull request into a Git repository by running: $ git pull https://github.com/heary-cao/spark CartesianProduct Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/19143.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #19143 commit 8aea2062fa258eb0247428b062887020c156fae4 Author: caoxuewen Date: 2017-09-06T06:36:16Z Remove package name similar 'logical.Join' to 'Join' in JoinSelection --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #19143: [SPARK-21932][SQL]Remove package name similar 'lo...
Github user heary-cao closed the pull request at: https://github.com/apache/spark/pull/19143 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #19143: [SPARK-21932][SQL]Remove package name similar 'lo...
GitHub user heary-cao reopened a pull request: https://github.com/apache/spark/pull/19143 [SPARK-21932][SQL]Remove package name similar 'logical.Join' to 'Join' in JoinSelection ## What changes were proposed in this pull request? this PR to fix two problemsï¼ 1. similar 'logical.Join' in JoinSelection, is not right, to be consistent in SparkStrategies.scala. fix to remove package name. 2. add two test case. test CartesianProduct join and BroadcastNestedLoop join. We understand the effect of CodeGen on them. ## How was this patch tested? add new test case. You can merge this pull request into a Git repository by running: $ git pull https://github.com/heary-cao/spark CartesianProduct Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/19143.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #19143 commit 8aea2062fa258eb0247428b062887020c156fae4 Author: caoxuewen Date: 2017-09-06T06:36:16Z Remove package name similar 'logical.Join' to 'Join' in JoinSelection --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org