[GitHub] spark pull request #19528: [SPARK-20393][WEBU UI][1.6] Strengthen Spark to p...

2018-08-21 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/19528


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #19528: [SPARK-20393][WEBU UI][1.6] Strengthen Spark to p...

2017-10-21 Thread felixcheung 
Github user felixcheung commented on a diff in the pull request:

https://github.com/apache/spark/pull/19528#discussion_r146098569
  
--- Diff: core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala ---
@@ -22,6 +22,7 @@ import javax.servlet.http.HttpServletRequest
 
 import scala.collection.mutable.{HashMap, ListBuffer}
 import scala.xml._
+import scala.collection.JavaConverters._
--- End diff --

is this needed?


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #19528: [SPARK-20393][WEBU UI][1.6] Strengthen Spark to p...

2017-10-20 Thread ambauma 
Github user ambauma commented on a diff in the pull request:

https://github.com/apache/spark/pull/19528#discussion_r146095022
  
--- Diff: 
resource-managers/mesos/src/main/scala/org/apache/spark/deploy/mesos/ui/DriverPage.scala
 ---
@@ -0,0 +1,180 @@
+/*
--- End diff --

I'm not sure what I did to make this whole file look new, but I've copied 
the 1.6 current and reapplied stripXSS locally.  Waiting for my build to pass 
to commit again.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #19528: [SPARK-20393][WEBU UI][1.6] Strengthen Spark to p...

2017-10-20 Thread ambauma 
Github user ambauma commented on a diff in the pull request:

https://github.com/apache/spark/pull/19528#discussion_r146084730
  
--- Diff: python/pyspark/mllib/classification.py ---
@@ -173,7 +173,7 @@ def __init__(self, weights, intercept, numFeatures, 
numClasses):
 self._dataWithBiasSize = None
 self._weightsMatrix = None
 else:
-self._dataWithBiasSize = self._coeff.size / (self._numClasses 
- 1)
+self._dataWithBiasSize = self._coeff.size // (self._numClasses 
- 1)
--- End diff --

The NewSparkPullRequestBuilder failed on python tests.  I was only able to 
duplicate the failure with Python 3.4 and numpy 1.12.1, which I'm guessing is 
the versions that NewSparkPullRequestBuilder is using.  Older and newer 
versions of numpy build clean either way.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #19528: [SPARK-20393][WEBU UI][1.6] Strengthen Spark to p...

2017-10-20 Thread ambauma 
Github user ambauma commented on a diff in the pull request:

https://github.com/apache/spark/pull/19528#discussion_r146084021
  
--- Diff: core/src/main/scala/org/apache/spark/ui/jobs/JobsTab.scala ---
@@ -16,9 +16,9 @@
  */
 
 package org.apache.spark.ui.jobs
-
+import javax.servlet.http.HttpServletRequest
--- End diff --

Agreed, will remove.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #19528: [SPARK-20393][WEBU UI][1.6] Strengthen Spark to p...

2017-10-20 Thread ambauma 
Github user ambauma commented on a diff in the pull request:

https://github.com/apache/spark/pull/19528#discussion_r146080377
  
--- Diff: 
resource-managers/mesos/src/main/scala/org/apache/spark/deploy/mesos/ui/DriverPage.scala
 ---
@@ -0,0 +1,180 @@
+/*
--- End diff --

I'll look into this as well...


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #19528: [SPARK-20393][WEBU UI][1.6] Strengthen Spark to p...

2017-10-20 Thread ambauma 
Github user ambauma commented on a diff in the pull request:

https://github.com/apache/spark/pull/19528#discussion_r146080311
  
--- Diff: python/pyspark/mllib/classification.py ---
@@ -173,7 +173,7 @@ def __init__(self, weights, intercept, numFeatures, 
numClasses):
 self._dataWithBiasSize = None
 self._weightsMatrix = None
 else:
-self._dataWithBiasSize = self._coeff.size / (self._numClasses 
- 1)
+self._dataWithBiasSize = self._coeff.size // (self._numClasses 
- 1)
--- End diff --

This is already fixed in the 2.0 branch, btw.  Just was never applied to 
1.6.  [SPARK-20862]


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #19528: [SPARK-20393][WEBU UI][1.6] Strengthen Spark to p...

2017-10-20 Thread ambauma 
Github user ambauma commented on a diff in the pull request:

https://github.com/apache/spark/pull/19528#discussion_r146080177
  
--- Diff: core/src/main/scala/org/apache/spark/ui/jobs/JobsTab.scala ---
@@ -16,9 +16,9 @@
  */
 
 package org.apache.spark.ui.jobs
-
+import javax.servlet.http.HttpServletRequest
--- End diff --

Will look into this...


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #19528: [SPARK-20393][WEBU UI][1.6] Strengthen Spark to p...

2017-10-20 Thread ambauma 
Github user ambauma commented on a diff in the pull request:

https://github.com/apache/spark/pull/19528#discussion_r146080089
  
--- Diff: python/pyspark/mllib/classification.py ---
@@ -173,7 +173,7 @@ def __init__(self, weights, intercept, numFeatures, 
numClasses):
 self._dataWithBiasSize = None
 self._weightsMatrix = None
 else:
-self._dataWithBiasSize = self._coeff.size / (self._numClasses 
- 1)
+self._dataWithBiasSize = self._coeff.size // (self._numClasses 
- 1)
--- End diff --

I had to apply this to get past a python unit test failure.  My assumption 
is that the NewSparkPullRequestBuilder is on a different version of numpy than 
when the Spark 1.6 branch was last built.  The current python unit test failure 
looks like it has to do with a novel version of SciPy.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #19528: [SPARK-20393][WEBU UI][1.6] Strengthen Spark to p...

2017-10-20 Thread srowen 
Github user srowen commented on a diff in the pull request:

https://github.com/apache/spark/pull/19528#discussion_r145895276
  
--- Diff: core/src/main/scala/org/apache/spark/ui/jobs/JobsTab.scala ---
@@ -16,9 +16,9 @@
  */
 
 package org.apache.spark.ui.jobs
-
+import javax.servlet.http.HttpServletRequest
--- End diff --

Hm, I'm not sure if this back-port is correct. This file's change doesn't 
look like it does anything and I don't see this change in the original: 
https://github.com/apache/spark/pull/17686/files


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #19528: [SPARK-20393][WEBU UI][1.6] Strengthen Spark to p...

2017-10-20 Thread srowen 
Github user srowen commented on a diff in the pull request:

https://github.com/apache/spark/pull/19528#discussion_r145895316
  
--- Diff: python/pyspark/mllib/classification.py ---
@@ -173,7 +173,7 @@ def __init__(self, weights, intercept, numFeatures, 
numClasses):
 self._dataWithBiasSize = None
 self._weightsMatrix = None
 else:
-self._dataWithBiasSize = self._coeff.size / (self._numClasses 
- 1)
+self._dataWithBiasSize = self._coeff.size // (self._numClasses 
- 1)
--- End diff --

Nor this?


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #19528: [SPARK-20393][WEBU UI][1.6] Strengthen Spark to p...

2017-10-20 Thread srowen 
Github user srowen commented on a diff in the pull request:

https://github.com/apache/spark/pull/19528#discussion_r145895305
  
--- Diff: 
resource-managers/mesos/src/main/scala/org/apache/spark/deploy/mesos/ui/DriverPage.scala
 ---
@@ -0,0 +1,180 @@
+/*
--- End diff --

Likewise this isn't part of the backport is it? 
https://github.com/apache/spark/pull/17686/files


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org