[GitHub] spark pull request #20338: [SPARK-23174][BUILD][PYTHON] python code style ch...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20338 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #20338: [SPARK-23174][BUILD][PYTHON] python code style ch...
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20338#discussion_r163467168 --- Diff: dev/tox.ini --- @@ -13,7 +13,7 @@ # See the License for the specific language governing permissions and # limitations under the License. -[pep8] -ignore=E402,E731,E241,W503,E226 +[pycodestyle] +ignore=E402,E731,E241,W503,E226,E722,E741,E305 --- End diff -- Yea .. there look actually many instances about it. I manually ran it against this PR. Will maybe take this one and open a PR separately after double checking each rule. Didn't take a look carefully yet. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #20338: [SPARK-23174][BUILD][PYTHON] python code style ch...
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/20338#discussion_r163465854 --- Diff: dev/tox.ini --- @@ -13,7 +13,7 @@ # See the License for the specific language governing permissions and # limitations under the License. -[pep8] -ignore=E402,E731,E241,W503,E226 +[pycodestyle] +ignore=E402,E731,E241,W503,E226,E722,E741,E305 --- End diff -- should we fix the code that violates E722: "do not use bare except'" E741: "ambiguous variable name 'l'", E305: "expected 2 blank lines after class or function definition" ? Or that's another PR/JIRA? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #20338: [SPARK-23174][BUILD][PYTHON] python code style ch...
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20338#discussion_r163243073
--- Diff: dev/lint-python ---
@@ -35,11 +35,10 @@ compile_status="${PIPESTATUS[0]}"
# Get pep8 at runtime so that we don't rely on it being installed on the
build server.
#+ See: https://github.com/apache/spark/pull/1744#issuecomment-50982162
-#+ TODOs:
-#+ - Download pep8 from PyPI. It's more "official".
-PEP8_VERSION="1.7.0"
+# Updated to latest official version for pep8.pep8 is formally renamed to
pycodestyle.
--- End diff --
nit .. : `pep8.pep8` -> `pep8. pep8`
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #20338: [SPARK-23174][BUILD][PYTHON] python code style ch...
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20338#discussion_r162852255
--- Diff: dev/lint-python ---
@@ -35,11 +35,10 @@ compile_status="${PIPESTATUS[0]}"
# Get pep8 at runtime so that we don't rely on it being installed on the
build server.
#+ See: https://github.com/apache/spark/pull/1744#issuecomment-50982162
-#+ TODOs:
-#+ - Download pep8 from PyPI. It's more "official".
-PEP8_VERSION="1.7.0"
+# Updated to latest official version for pep8.pep8 is formally renamed to
pycodestyle.
+PEP8_VERSION="2.3.1"
--- End diff --
Should we also use `pycodestyle` instead of `pep8` for variable names or
script names?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #20338: [SPARK-23174][BUILD][PYTHON] python code style ch...
Github user rekhajoshm commented on a diff in the pull request: https://github.com/apache/spark/pull/20338#discussion_r162838933 --- Diff: dev/tox.ini --- @@ -13,7 +13,7 @@ # See the License for the specific language governing permissions and # limitations under the License. -[pep8] -ignore=E402,E731,E241,W503,E226 +[pycodestyle] +ignore=E402,E731,E241,W503,E226,E722,E741,E305 --- End diff -- Updated SPARK-11222. Added https://issues.apache.org/jira/browse/SPARK-23174. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
