[GitHub] spark pull request #20358: [SPARK-20749][SQL][FOLLOW-UP] Override prettyName...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/20358


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #20358: [SPARK-20749][SQL][FOLLOW-UP] Override prettyName...

[HyukjinKwon]

Github user HyukjinKwon commented on a diff in the pull request:

https://github.com/apache/spark/pull/20358#discussion_r163145263
  
--- Diff: 
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -141,7 +141,7 @@ statement
 (LIKE? pattern=STRING)?
#showTables
 | SHOW TABLE EXTENDED ((FROM | IN) db=identifier)?
 LIKE pattern=STRING partitionSpec? 
#showTable
-| SHOW DATABASES (LIKE? pattern=STRING)?
#showDatabases
+| SHOW DATABASES (LIKE? pattern=STRING)?   
#showDatabases
--- End diff --

Nit: seems unrelated?


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #20358: [SPARK-20749][SQL][FOLLOW-UP] Override prettyName...

[gatorsmile]

GitHub user gatorsmile opened a pull request:

https://github.com/apache/spark/pull/20358

[SPARK-20749][SQL][FOLLOW-UP] Override prettyName for bit_length and 
octet_length

## What changes were proposed in this pull request?
We need to override the prettyName for bit_length and octet_length for 
getting the expected auto-generated alias name.

## How was this patch tested?
The existing tests

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gatorsmile/spark test2.3More

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/20358.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #20358


commit 4f4032d52e25b4dd83bdbe223e32625992fbe88b
Author: gatorsmile 
Date:   2018-01-23T04:28:25Z

fix

commit 53d74a203ccbafd0942d83b647957e07dd8f1d31
Author: gatorsmile 
Date:   2018-01-23T04:28:54Z

indent




---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org