Re: [PR] [SPARK-45827][SQL] Move data type checks to CreatableRelationProvider [spark]

[via GitHub]

cloud-fan closed pull request #45409: [SPARK-45827][SQL] Move data type checks 
to CreatableRelationProvider
URL: https://github.com/apache/spark/pull/45409


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Re: [PR] [SPARK-45827][SQL] Move data type checks to CreatableRelationProvider [spark]

[via GitHub]

cloud-fan commented on PR #45409:
URL: https://github.com/apache/spark/pull/45409#issuecomment-1983973892

   thanks, merging to master!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Re: [PR] [SPARK-45827][SQL] Move data type checks to CreatableRelationProvider [spark]

[via GitHub]

cashmand commented on code in PR #45409:
URL: https://github.com/apache/spark/pull/45409#discussion_r1516216789


##
sql/core/src/main/scala/org/apache/spark/sql/sources/interfaces.scala:
##
@@ -175,6 +175,25 @@ trait CreatableRelationProvider {
   mode: SaveMode,
   parameters: Map[String, String],
   data: DataFrame): BaseRelation
+
+  /**
+   * Check if the relation supports the given data type.
+   *
+   * @param dt Data type to check
+   * @return True if the data type is supported

Review Comment:
   Done.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org